-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elasticsearch adding vpc endpoint resource #33925
Elasticsearch adding vpc endpoint resource #33925
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccElasticsearchDomain_VPC_update\|TestAccElasticsearchVPCEndpoint_\|TestAccElasticsearchDomainDataSource_advanced' PKG=elasticsearch ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticsearch/... -v -count 1 -parallel 2 -run=TestAccElasticsearchDomain_VPC_update\|TestAccElasticsearchVPCEndpoint_\|TestAccElasticsearchDomainDataSource_advanced -timeout 720m
=== RUN TestAccElasticsearchDomainDataSource_advanced
=== PAUSE TestAccElasticsearchDomainDataSource_advanced
=== RUN TestAccElasticsearchDomain_VPC_update
=== PAUSE TestAccElasticsearchDomain_VPC_update
=== RUN TestAccElasticsearchVPCEndpoint_basic
=== PAUSE TestAccElasticsearchVPCEndpoint_basic
=== RUN TestAccElasticsearchVPCEndpoint_disappears
=== PAUSE TestAccElasticsearchVPCEndpoint_disappears
=== RUN TestAccElasticsearchVPCEndpoint_update
=== PAUSE TestAccElasticsearchVPCEndpoint_update
=== CONT TestAccElasticsearchDomainDataSource_advanced
=== CONT TestAccElasticsearchVPCEndpoint_disappears
--- PASS: TestAccElasticsearchVPCEndpoint_disappears (2088.42s)
=== CONT TestAccElasticsearchVPCEndpoint_update
--- PASS: TestAccElasticsearchDomainDataSource_advanced (2291.66s)
=== CONT TestAccElasticsearchVPCEndpoint_basic
--- PASS: TestAccElasticsearchVPCEndpoint_basic (1851.45s)
=== CONT TestAccElasticsearchDomain_VPC_update
--- PASS: TestAccElasticsearchVPCEndpoint_update (2322.95s)
--- PASS: TestAccElasticsearchDomain_VPC_update (3937.59s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch 8085.812s
@mikekinlock Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Change
Added the elasticsearch vpc-endpoint resource
Description
Added the option to configure a resource which manages the VPC-Endpoint of elasticsearch
Relations
Closes #27978.
Closes #28140.
Relates #32435.
References
https://docs.aws.amazon.com/cli/latest/reference/es/create-vpc-endpoint.html
Output from Acceptance Testing