-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws_schemas_schema): add JSON Schema support #33442
feat(aws_schemas_schema): add JSON Schema support #33442
Conversation
This commit relies on types exposed by `aws-sdk-go-v2` to compose the validation of the `aws_schemas_schema` types as it includes `JSONSchemaDraft4`. This is a long supported featured by AWS and a years long request from Terraform users. Ref. hashicorp#23753
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @brennovich 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSchemasSchema_' PKG=schemas ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/schemas/... -v -count 1 -parallel 2 -run=TestAccSchemasSchema_ -timeout 180m
=== RUN TestAccSchemasSchema_openAPI3
=== PAUSE TestAccSchemasSchema_openAPI3
=== RUN TestAccSchemasSchema_jsonSchemaDraftv4
=== PAUSE TestAccSchemasSchema_jsonSchemaDraftv4
=== RUN TestAccSchemasSchema_disappears
=== PAUSE TestAccSchemasSchema_disappears
=== RUN TestAccSchemasSchema_contentDescription
=== PAUSE TestAccSchemasSchema_contentDescription
=== RUN TestAccSchemasSchema_tags
=== PAUSE TestAccSchemasSchema_tags
=== CONT TestAccSchemasSchema_openAPI3
=== CONT TestAccSchemasSchema_contentDescription
--- PASS: TestAccSchemasSchema_openAPI3 (26.07s)
=== CONT TestAccSchemasSchema_tags
--- PASS: TestAccSchemasSchema_contentDescription (60.49s)
=== CONT TestAccSchemasSchema_disappears
--- PASS: TestAccSchemasSchema_disappears (20.76s)
=== CONT TestAccSchemasSchema_jsonSchemaDraftv4
--- PASS: TestAccSchemasSchema_tags (58.50s)
--- PASS: TestAccSchemasSchema_jsonSchemaDraftv4 (23.15s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/schemas 109.599s
@brennovich Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This commit relies on types exposed by
aws-sdk-go-v2
to compose the validation of theaws_schemas_schema
types as it includesJSONSchemaDraft4
.This is a long supported featured by AWS and a years long request from Terraform users.
Relations
Closes #23753
References
Output from Acceptance Testing
Add TestAccSchemasSchema_jsonSchemaDraftv4