Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document for SNS filter policy #3322

Merged
merged 2 commits into from
Feb 11, 2018

Conversation

yohei1126
Copy link
Contributor

#2806 did not include fix for the document.
Need to add document about the SNS filter policy here.
https://www.terraform.io/docs/providers/aws/r/sns_topic_subscription.html

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Feb 10, 2018
@radeksimko radeksimko added the service/sns Issues and PRs that pertain to the sns service. label Feb 11, 2018
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the follow-up. 👍

@radeksimko radeksimko merged commit 55ce9b4 into hashicorp:master Feb 11, 2018
@yohei1126 yohei1126 deleted the sns-filter-doc branch February 11, 2018 11:28
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/sns Issues and PRs that pertain to the sns service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants