r/aws_kms_key: Fix tag propagation timeout errors when ignore_tags is configured

[ewbankkit]

Description

Fixes tag propagation: timeout while waiting for state to become 'TRUE' errors when ignore_tags has been configured.

Relations

Closes #26174.
Relates #33154.

Output from Acceptance Testing

Previously

% make testacc TESTARGS='-run=TestAccKMSKey_ignoreTags' PKG=kms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 20  -run=TestAccKMSKey_ignoreTags -timeout 180m
=== RUN   TestAccKMSKey_ignoreTags
=== PAUSE TestAccKMSKey_ignoreTags
=== CONT  TestAccKMSKey_ignoreTags
    key_test.go:526: Step 3/3 error: Error running apply: exit status 1
        
        Error: updating tags for KMS (Key Management) Key (89404ac1-aaeb-4879-a58f-c233fdfaa9ec): waiting for resource (89404ac1-aaeb-4879-a58f-c233fdfaa9ec) tag propagation: timeout while waiting for state to become 'TRUE' (last state: 'FALSE', timeout: 10m0s)
        
          with aws_kms_key.test,
          on terraform_plugin_test.tf line 13, in resource "aws_kms_key" "test":
          13: resource "aws_kms_key" "test" {
        
--- FAIL: TestAccKMSKey_ignoreTags (686.51s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/kms	692.089s
FAIL
make: *** [testacc] Error 1

% make testacc TESTARGS='-run=TestAccKMSKey_' PKG=kms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 3  -run=TestAccKMSKey_ -timeout 180m
=== RUN   TestAccKMSKey_basic
=== PAUSE TestAccKMSKey_basic
=== RUN   TestAccKMSKey_disappears
=== PAUSE TestAccKMSKey_disappears
=== RUN   TestAccKMSKey_multiRegion
=== PAUSE TestAccKMSKey_multiRegion
=== RUN   TestAccKMSKey_asymmetricKey
=== PAUSE TestAccKMSKey_asymmetricKey
=== RUN   TestAccKMSKey_hmacKey
=== PAUSE TestAccKMSKey_hmacKey
=== RUN   TestAccKMSKey_Policy_basic
=== PAUSE TestAccKMSKey_Policy_basic
=== RUN   TestAccKMSKey_Policy_bypass
=== PAUSE TestAccKMSKey_Policy_bypass
=== RUN   TestAccKMSKey_Policy_bypassUpdate
=== PAUSE TestAccKMSKey_Policy_bypassUpdate
=== RUN   TestAccKMSKey_Policy_iamRole
=== PAUSE TestAccKMSKey_Policy_iamRole
=== RUN   TestAccKMSKey_Policy_iamRoleUpdate
=== PAUSE TestAccKMSKey_Policy_iamRoleUpdate
=== RUN   TestAccKMSKey_Policy_iamRoleOrder
=== PAUSE TestAccKMSKey_Policy_iamRoleOrder
=== RUN   TestAccKMSKey_Policy_iamServiceLinkedRole
=== PAUSE TestAccKMSKey_Policy_iamServiceLinkedRole
=== RUN   TestAccKMSKey_Policy_booleanCondition
=== PAUSE TestAccKMSKey_Policy_booleanCondition
=== RUN   TestAccKMSKey_isEnabled
=== PAUSE TestAccKMSKey_isEnabled
=== RUN   TestAccKMSKey_tags
=== PAUSE TestAccKMSKey_tags
=== RUN   TestAccKMSKey_ignoreTags
=== PAUSE TestAccKMSKey_ignoreTags
=== CONT  TestAccKMSKey_basic
=== CONT  TestAccKMSKey_ignoreTags
=== CONT  TestAccKMSKey_Policy_iamRole
--- PASS: TestAccKMSKey_basic (81.05s)
=== CONT  TestAccKMSKey_hmacKey
--- PASS: TestAccKMSKey_Policy_iamRole (83.47s)
=== CONT  TestAccKMSKey_Policy_bypassUpdate
--- PASS: TestAccKMSKey_ignoreTags (122.25s)
=== CONT  TestAccKMSKey_Policy_bypass
--- PASS: TestAccKMSKey_hmacKey (44.54s)
=== CONT  TestAccKMSKey_Policy_basic
--- PASS: TestAccKMSKey_Policy_bypassUpdate (79.15s)
=== CONT  TestAccKMSKey_multiRegion
--- PASS: TestAccKMSKey_Policy_basic (75.45s)
=== CONT  TestAccKMSKey_asymmetricKey
--- PASS: TestAccKMSKey_multiRegion (44.84s)
=== CONT  TestAccKMSKey_Policy_booleanCondition
--- PASS: TestAccKMSKey_asymmetricKey (37.93s)
=== CONT  TestAccKMSKey_tags
--- PASS: TestAccKMSKey_Policy_booleanCondition (43.02s)
=== CONT  TestAccKMSKey_isEnabled
--- PASS: TestAccKMSKey_Policy_bypass (186.74s)
=== CONT  TestAccKMSKey_disappears
--- PASS: TestAccKMSKey_disappears (34.89s)
=== CONT  TestAccKMSKey_Policy_iamRoleOrder
--- PASS: TestAccKMSKey_tags (180.34s)
=== CONT  TestAccKMSKey_Policy_iamServiceLinkedRole
--- PASS: TestAccKMSKey_isEnabled (187.08s)
=== CONT  TestAccKMSKey_Policy_iamRoleUpdate
--- PASS: TestAccKMSKey_Policy_iamRoleOrder (136.97s)
--- PASS: TestAccKMSKey_Policy_iamServiceLinkedRole (72.67s)
--- PASS: TestAccKMSKey_Policy_iamRoleUpdate (86.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	530.142s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

% make testacc PKG=kms TESTS=TestAccKMSKey_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 20 -run='TestAccKMSKey_'  -timeout 180m

--- PASS: TestAccKMSKey_disappears (39.37s)
--- PASS: TestAccKMSKey_asymmetricKey (42.41s)
--- PASS: TestAccKMSKey_hmacKey (44.89s)
--- PASS: TestAccKMSKey_Policy_booleanCondition (50.74s)
--- PASS: TestAccKMSKey_multiRegion (51.48s)
--- PASS: TestAccKMSKey_Policy_iamRole (64.57s)
--- PASS: TestAccKMSKey_Policy_basic (80.05s)
--- PASS: TestAccKMSKey_Policy_bypassUpdate (80.10s)
--- PASS: TestAccKMSKey_basic (80.61s)
--- PASS: TestAccKMSKey_Policy_iamServiceLinkedRole (88.82s)
--- PASS: TestAccKMSKey_Policy_iamRoleUpdate (93.16s)
--- PASS: TestAccKMSKey_ignoreTags (112.23s)
--- PASS: TestAccKMSKey_Policy_iamRoleOrder (113.01s)
--- PASS: TestAccKMSKey_tags (151.04s)
--- PASS: TestAccKMSKey_isEnabled (172.14s)
--- PASS: TestAccKMSKey_Policy_bypass (175.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kms        178.769s

[github-actions]

This functionality has been released in v5.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.