r/aws_ec2_traffic_mirror_filter_rule: Fix crash when updating rule_number
#32594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/L
github-actions
bot
added
the
size/L
ewbankkit
added
bug
johnsonaj
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
LGTM 🚀
$ make testacc TESTARGS='-run=TestAccVPCTrafficMirrorFilterRule_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCTrafficMirrorFilterRule_ -timeout 180m
--- PASS: TestAccVPCTrafficMirrorFilterRule_disappears (17.48s)
--- PASS: TestAccVPCTrafficMirrorFilterRule_basic (57.30s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 60.619s$ make sweep SWEEPARGS=-sweep-run=aws_ec2_traffic_mirror_filter,aws_ec2_traffic_mirror_target
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2,us-west-1 -sweep-run=aws_ec2_traffic_mirror_filter,aws_ec2_traffic_mirror_target -timeout 60m
2023/07/19 11:55:28 [DEBUG] Running Sweepers for region (us-west-2):
2023/07/19 11:55:28 [DEBUG] Sweeper (aws_ec2_traffic_mirror_filter) has dependency (aws_ec2_traffic_mirror_session), running..
2023/07/19 11:55:28 [DEBUG] Running Sweeper (aws_ec2_traffic_mirror_session) in region (us-west-2)
2023/07/19 11:55:28 [DEBUG] Completed Sweeper (aws_ec2_traffic_mirror_session) in region (us-west-2) in 749.436375ms
2023/07/19 11:55:28 [DEBUG] Running Sweeper (aws_ec2_traffic_mirror_filter) in region (us-west-2)
2023/07/19 11:55:28 [DEBUG] Completed Sweeper (aws_ec2_traffic_mirror_filter) in region (us-west-2) in 129.701042ms
2023/07/19 11:55:28 [DEBUG] Sweeper (aws_ec2_traffic_mirror_session) already ran in region (us-west-2)
2023/07/19 11:55:28 [DEBUG] Sweeper (aws_ec2_traffic_mirror_target) has dependency (aws_ec2_traffic_mirror_session), running..
2023/07/19 11:55:28 [DEBUG] Sweeper (aws_ec2_traffic_mirror_session) already ran in region (us-west-2)
2023/07/19 11:55:28 [DEBUG] Running Sweeper (aws_ec2_traffic_mirror_target) in region (us-west-2)
2023/07/19 11:55:29 [DEBUG] Completed Sweeper (aws_ec2_traffic_mirror_target) in region (us-west-2) in 128.374542ms
2023/07/19 11:55:29 Completed Sweepers for region (us-west-2) in 1.007884333s
2023/07/19 11:55:29 Sweeper Tests for region (us-west-2) ran successfully:
- aws_ec2_traffic_mirror_target
- aws_ec2_traffic_mirror_session
- aws_ec2_traffic_mirror_filter
2023/07/19 11:55:29 [DEBUG] Running Sweepers for region (us-east-1):
2023/07/19 11:55:29 [DEBUG] Sweeper (aws_ec2_traffic_mirror_filter) has dependency (aws_ec2_traffic_mirror_session), running..
2023/07/19 11:55:29 [DEBUG] Running Sweeper (aws_ec2_traffic_mirror_session) in region (us-east-1)
2023/07/19 11:55:29 [DEBUG] Completed Sweeper (aws_ec2_traffic_mirror_session) in region (us-east-1) in 760.916375ms
2023/07/19 11:55:29 [DEBUG] Running Sweeper (aws_ec2_traffic_mirror_filter) in region (us-east-1)
2023/07/19 11:55:29 [DEBUG] Completed Sweeper (aws_ec2_traffic_mirror_filter) in region (us-east-1) in 117.751042ms
2023/07/19 11:55:29 [DEBUG] Sweeper (aws_ec2_traffic_mirror_session) already ran in region (us-east-1)
2023/07/19 11:55:29 [DEBUG] Sweeper (aws_ec2_traffic_mirror_target) has dependency (aws_ec2_traffic_mirror_session), running..
2023/07/19 11:55:29 [DEBUG] Sweeper (aws_ec2_traffic_mirror_session) already ran in region (us-east-1)
2023/07/19 11:55:29 [DEBUG] Running Sweeper (aws_ec2_traffic_mirror_target) in region (us-east-1)
2023/07/19 11:55:30 [DEBUG] Completed Sweeper (aws_ec2_traffic_mirror_target) in region (us-east-1) in 118.69725ms
2023/07/19 11:55:30 Completed Sweepers for region (us-east-1) in 997.618667ms
2023/07/19 11:55:30 Sweeper Tests for region (us-east-1) ran successfully:
- aws_ec2_traffic_mirror_session
- aws_ec2_traffic_mirror_filter
- aws_ec2_traffic_mirror_target
2023/07/19 11:55:30 [DEBUG] Running Sweepers for region (us-east-2):
2023/07/19 11:55:30 [DEBUG] Sweeper (aws_ec2_traffic_mirror_filter) has dependency (aws_ec2_traffic_mirror_session), running..
2023/07/19 11:55:30 [DEBUG] Running Sweeper (aws_ec2_traffic_mirror_session) in region (us-east-2)
2023/07/19 11:55:30 [DEBUG] Completed Sweeper (aws_ec2_traffic_mirror_session) in region (us-east-2) in 589.645917ms
2023/07/19 11:55:30 [DEBUG] Running Sweeper (aws_ec2_traffic_mirror_filter) in region (us-east-2)
2023/07/19 11:55:30 [DEBUG] Completed Sweeper (aws_ec2_traffic_mirror_filter) in region (us-east-2) in 94.913834ms
2023/07/19 11:55:30 [DEBUG] Sweeper (aws_ec2_traffic_mirror_session) already ran in region (us-east-2)
2023/07/19 11:55:30 [DEBUG] Sweeper (aws_ec2_traffic_mirror_target) has dependency (aws_ec2_traffic_mirror_session), running..
2023/07/19 11:55:30 [DEBUG] Sweeper (aws_ec2_traffic_mirror_session) already ran in region (us-east-2)
2023/07/19 11:55:30 [DEBUG] Running Sweeper (aws_ec2_traffic_mirror_target) in region (us-east-2)
2023/07/19 11:55:30 [DEBUG] Completed Sweeper (aws_ec2_traffic_mirror_target) in region (us-east-2) in 96.2395ms
2023/07/19 11:55:30 Completed Sweepers for region (us-east-2) in 781.011375ms
2023/07/19 11:55:30 Sweeper Tests for region (us-east-2) ran successfully:
- aws_ec2_traffic_mirror_session
- aws_ec2_traffic_mirror_filter
- aws_ec2_traffic_mirror_target
2023/07/19 11:55:30 [DEBUG] Running Sweepers for region (us-west-1):
2023/07/19 11:55:30 [DEBUG] Sweeper (aws_ec2_traffic_mirror_filter) has dependency (aws_ec2_traffic_mirror_session), running..
2023/07/19 11:55:30 [DEBUG] Running Sweeper (aws_ec2_traffic_mirror_session) in region (us-west-1)
2023/07/19 11:55:31 [DEBUG] Completed Sweeper (aws_ec2_traffic_mirror_session) in region (us-west-1) in 742.058959ms
2023/07/19 11:55:31 [DEBUG] Running Sweeper (aws_ec2_traffic_mirror_filter) in region (us-west-1)
2023/07/19 11:55:31 [DEBUG] Completed Sweeper (aws_ec2_traffic_mirror_filter) in region (us-west-1) in 131.744416ms
2023/07/19 11:55:31 [DEBUG] Sweeper (aws_ec2_traffic_mirror_session) already ran in region (us-west-1)
2023/07/19 11:55:31 [DEBUG] Sweeper (aws_ec2_traffic_mirror_target) has dependency (aws_ec2_traffic_mirror_session), running..
2023/07/19 11:55:31 [DEBUG] Sweeper (aws_ec2_traffic_mirror_session) already ran in region (us-west-1)
2023/07/19 11:55:31 [DEBUG] Running Sweeper (aws_ec2_traffic_mirror_target) in region (us-west-1)
2023/07/19 11:55:31 [DEBUG] Completed Sweeper (aws_ec2_traffic_mirror_target) in region (us-west-1) in 108.94525ms
2023/07/19 11:55:31 Completed Sweepers for region (us-west-1) in 982.929542ms
2023/07/19 11:55:31 Sweeper Tests for region (us-west-1) ran successfully:
- aws_ec2_traffic_mirror_session
- aws_ec2_traffic_mirror_filter
- aws_ec2_traffic_mirror_target
ok github.com/hashicorp/terraform-provider-aws/internal/sweep 7.033s
|
This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrects attribute name in resource Update.
Relations
Closes #32588.
Output from Acceptance Testing