Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve doc accuracy for aws_vpc_security_group_ingress_rule and `a… #32148

Merged

Commits on Jun 21, 2023

  1. Improve doc accuracy for aws_vpc_security_group_ingress_rule and `a…

    …ws_vpc_security_group_egress_rule`
    
    * `ip_protocol` was marked as `Required` in the schema but `Optional` in the docs
    * `security_group_id` is `Required` but was `Optional` in the schema
    * Try to clarify the situations where `Optional` arguments are actually `Required`
    * Make examples less confusing by using a single port; using different ports makes it look like some kind of port mapping
    mattburgess committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    ee8af4f View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Justin Retzolk <[email protected]>
    mattburgess and justinretzolk authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a4f6b03 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    571a5d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2023

  1. Add Changelog entry

    mattburgess committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    907a04a View commit details
    Browse the repository at this point in the history