data-source/aws_ssm_parameter: Fix wrong arn attribute for full path parameter names #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
bug
bflad
changed the title
bflad
approved these changes
Jan 31, 2018
There was a problem hiding this comment.
Thank you so much for this contribution without knowing Go! It worked great. I added an acceptance test for you similar to the one I implemented for the aws_ssm_parameter resource 😄
make testacc TEST=./aws TESTARGS='-run=TestAccAwsSsmParameterDataSource'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAwsSsmParameterDataSource -timeout 120m
=== RUN TestAccAwsSsmParameterDataSource_basic
--- PASS: TestAccAwsSsmParameterDataSource_basic (18.73s)
=== RUN TestAccAwsSsmParameterDataSource_fullPath
--- PASS: TestAccAwsSsmParameterDataSource_fullPath (12.30s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 31.075s
|
This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue described in #2593
As I'm not experienced with programming in Go, I couldn't implement a respective testcase for this.