-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/memorydb_user: Support IAM authentication mode #32027
Conversation
Community NoteVoting for Prioritization
For Submitters
|
9baf65c
to
dc155a2
Compare
dc155a2
to
bfd80ee
Compare
8460b72
to
8cb7833
Compare
8cb7833
to
7339445
Compare
What needs to happen for this to get merged in? |
We're needing this support for our current project. Anything I can do to help get this merged in? |
Simplifies the configuration by removing tags (tested in other configurations) and applies consistent naming to both tests and associated configurations. ```console % make testacc PKG=memorydb TESTS="TestAccMemoryDBUser|TestAccMemoryDBUserDataSource" ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBUser|TestAccMemoryDBUserDataSource' -timeout 360m --- PASS: TestAccMemoryDBUser_tags (45.96s) --- PASS: TestAccMemoryDBUserDataSource_authenticationModeIAM (49.38s) --- PASS: TestAccMemoryDBUserDataSource_basic (49.38s) --- PASS: TestAccMemoryDBUser_basic (52.16s) --- PASS: TestAccMemoryDBUser_authenticationModeIAM (52.20s) --- PASS: TestAccMemoryDBUser_disappears (58.02s) --- PASS: TestAccMemoryDBUser_update_accessString (105.60s) --- PASS: TestAccMemoryDBUser_update_passwords (173.49s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 178.422s ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=memorydb TESTS="TestAccMemoryDBUser|TestAccMemoryDBUserDataSource"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBUser|TestAccMemoryDBUserDataSource' -timeout 360m
--- PASS: TestAccMemoryDBUser_tags (45.96s)
--- PASS: TestAccMemoryDBUserDataSource_authenticationModeIAM (49.38s)
--- PASS: TestAccMemoryDBUserDataSource_basic (49.38s)
--- PASS: TestAccMemoryDBUser_basic (52.16s)
--- PASS: TestAccMemoryDBUser_authenticationModeIAM (52.20s)
--- PASS: TestAccMemoryDBUser_disappears (58.02s)
--- PASS: TestAccMemoryDBUser_update_accessString (105.60s)
--- PASS: TestAccMemoryDBUser_update_passwords (173.49s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 178.422s
Thank you for your contribution, @exoego! |
This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Allow IAM authentication support for
aws_memorydb_user
Relations
Closes #31528
References
I've followed the styles in docs and implementation for
elasticache_user
Output from Acceptance Testing