Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/memorydb_user: Support IAM authentication mode #32027

Merged
merged 10 commits into from
Apr 25, 2024

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jun 16, 2023

Description

Allow IAM authentication support for aws_memorydb_user

Relations

Closes #31528

References

I've followed the styles in docs and implementation for elasticache_user

Output from Acceptance Testing

$ make testacc TESTS=TestAccMemoryDBUser PKG=memorydb

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBUser'  -timeout 180m
=== RUN   TestAccMemoryDBUserDataSource_basic
=== PAUSE TestAccMemoryDBUserDataSource_basic
=== RUN   TestAccMemoryDBUserDataSource_iam
=== PAUSE TestAccMemoryDBUserDataSource_iam
=== RUN   TestAccMemoryDBUser_basic
=== PAUSE TestAccMemoryDBUser_basic
=== RUN   TestAccMemoryDBUser_iam_auth_mode
=== PAUSE TestAccMemoryDBUser_iam_auth_mode
=== RUN   TestAccMemoryDBUser_disappears
=== PAUSE TestAccMemoryDBUser_disappears
=== RUN   TestAccMemoryDBUser_update_accessString
=== PAUSE TestAccMemoryDBUser_update_accessString
=== RUN   TestAccMemoryDBUser_update_passwords
=== PAUSE TestAccMemoryDBUser_update_passwords
=== RUN   TestAccMemoryDBUser_tags
=== PAUSE TestAccMemoryDBUser_tags
=== CONT  TestAccMemoryDBUserDataSource_basic
=== CONT  TestAccMemoryDBUser_disappears
=== CONT  TestAccMemoryDBUser_update_passwords
=== CONT  TestAccMemoryDBUser_update_accessString
=== CONT  TestAccMemoryDBUser_tags
=== CONT  TestAccMemoryDBUser_basic
=== CONT  TestAccMemoryDBUser_iam_auth_mode
=== CONT  TestAccMemoryDBUserDataSource_iam
--- PASS: TestAccMemoryDBUser_disappears (47.06s)
--- PASS: TestAccMemoryDBUser_tags (92.96s)
--- PASS: TestAccMemoryDBUserDataSource_iam (97.35s)
--- PASS: TestAccMemoryDBUserDataSource_basic (97.57s)
--- PASS: TestAccMemoryDBUser_iam_auth_mode (102.17s)
--- PASS: TestAccMemoryDBUser_basic (102.85s)
--- PASS: TestAccMemoryDBUser_update_accessString (164.18s)
--- PASS: TestAccMemoryDBUser_update_passwords (222.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   225.004s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/memorydb Issues and PRs that pertain to the memorydb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jun 16, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 16, 2023
@exoego exoego force-pushed the b-memory_db-feat-31528 branch 2 times, most recently from 9baf65c to dc155a2 Compare June 16, 2023 23:46
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Aug 16, 2023
@exoego exoego force-pushed the b-memory_db-feat-31528 branch 2 times, most recently from 8460b72 to 8cb7833 Compare August 16, 2023 04:10
@bigwheels16
Copy link

What needs to happen for this to get merged in?

@GilUpstream
Copy link

We're needing this support for our current project. Anything I can do to help get this merged in?

@jar-b jar-b self-assigned this Apr 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 25, 2024
Simplifies the configuration by removing tags (tested in other
configurations) and applies consistent naming to both tests and
associated configurations.

```console
% make testacc PKG=memorydb TESTS="TestAccMemoryDBUser|TestAccMemoryDBUserDataSource"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBUser|TestAccMemoryDBUserDataSource'  -timeout 360m

--- PASS: TestAccMemoryDBUser_tags (45.96s)
--- PASS: TestAccMemoryDBUserDataSource_authenticationModeIAM (49.38s)
--- PASS: TestAccMemoryDBUserDataSource_basic (49.38s)
--- PASS: TestAccMemoryDBUser_basic (52.16s)
--- PASS: TestAccMemoryDBUser_authenticationModeIAM (52.20s)
--- PASS: TestAccMemoryDBUser_disappears (58.02s)
--- PASS: TestAccMemoryDBUser_update_accessString (105.60s)
--- PASS: TestAccMemoryDBUser_update_passwords (173.49s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   178.422s
```
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=memorydb TESTS="TestAccMemoryDBUser|TestAccMemoryDBUserDataSource"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBUser|TestAccMemoryDBUserDataSource'  -timeout 360m

--- PASS: TestAccMemoryDBUser_tags (45.96s)
--- PASS: TestAccMemoryDBUserDataSource_authenticationModeIAM (49.38s)
--- PASS: TestAccMemoryDBUserDataSource_basic (49.38s)
--- PASS: TestAccMemoryDBUser_basic (52.16s)
--- PASS: TestAccMemoryDBUser_authenticationModeIAM (52.20s)
--- PASS: TestAccMemoryDBUser_disappears (58.02s)
--- PASS: TestAccMemoryDBUser_update_accessString (105.60s)
--- PASS: TestAccMemoryDBUser_update_passwords (173.49s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   178.422s

@jar-b
Copy link
Member

jar-b commented Apr 25, 2024

Thank you for your contribution, @exoego!

@jar-b jar-b merged commit 11ef371 into hashicorp:main Apr 25, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.47.0 milestone Apr 25, 2024
@exoego exoego deleted the b-memory_db-feat-31528 branch April 25, 2024 21:52
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 26, 2024
Copy link

This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/memorydb Issues and PRs that pertain to the memorydb service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws memorydb for redis IAM authentication support
5 participants