Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/cognito_user_pool: Update Cognito email message length to 20,000 #2692

Merged
merged 2 commits into from
Dec 19, 2017
Merged

resource/cognito_user_pool: Update Cognito email message length to 20,000 #2692

merged 2 commits into from
Dec 19, 2017

Conversation

loivis
Copy link
Contributor

@loivis loivis commented Dec 18, 2017 •
edited by Ninir
Loading

Fixes #2600
Not sure it was typo or recent change from aws.

@loivis
Copy link
Contributor Author

loivis commented Dec 18, 2017 

⎇  go test ./aws -v -run=TestValidateCognitoUserPoolEmailVerificationMessage
=== RUN   TestValidateCognitoUserPoolEmailVerificationMessage
--- PASS: TestValidateCognitoUserPoolEmailVerificationMessage (0.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.053s

@Ninir Ninir added the bug Addresses a defect in current functionality. label Dec 18, 2017
@Ninir Ninir changed the title fix length validation to 20,000 for cognito email message resource/cognito_user_pool: Update Cognito email message length to 20,000 Dec 18, 2017
Ninir
Ninir approved these changes Dec 19, 2017
View reviewed changes
Copy link
Contributor

@Ninir Ninir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @loivis

This looks good to me, thanks for the update :)

Tried to look at web.archive.org, and it seemed to be 20k even in may. Not sure what was done here exactly :/

Still, thanks!

@Ninir Ninir merged commit 3916ab7 into hashicorp:master Dec 19, 2017
catsby added a commit that referenced this pull request Dec 19, 2017
@catsby
Merge branch 'master' into pr-2422
01ca386 
* master: (147 commits)
  Cleaned Data Sources
  Update CHANGELOG.md
  resource/cognito_user_pool: Update Cognito email message length to 20,000 (#2692)
  Update ecs_service.html.markdown (#2694)
  Documentation: r/ecs_task_definition note about quote escaping container_definition (#2162)
  Cleanup after v1.6.0 release
  v1.6.0
  Make depends_on consistent with note (#2526)
  removing duplicate
  Update CHANGELOG.md
  r/aws_ssm_parameter: Fix arn attribute for full path names and improve testing
  Update CHANGELOG.md
  Update CHANGELOG.md
  s3: Add validation for SSE Algorithm and correct spelling
  #2217: fixed when encryption is AES256
  #2217: documentation
  #2217: re-enable default encryption after disabling in via UI
  #2217: wrote additional acceptance test
  #2217: wrote typical acceptance test
  #2217: make fmt
  ...
@bflad bflad added this to the v1.7.0 milestone Jan 12, 2018
@bflad
Copy link
Contributor

bflad commented Jan 12, 2018

This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ninir Ninir Ninir approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Cognito User Pool email_verification_message won't accept more than 2000 characters
3 participants
@loivis @bflad @Ninir