Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vpc/security_group: Fix complex dependency violations #26553

Merged
merged 11 commits into from
Aug 31, 2022
Merged

vpc/security_group: Fix complex dependency violations #26553

merged 11 commits into from
Aug 31, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 30, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1671
Closes #8285
Closes #8769
Relates #10329
Closes #12394
Relates #12396
Closes #12420
Closes #13228
Closes #16165
Relates #18559
Closes #19932
Closes #20035
Closes #20405
Closes #20743
Closes #20925
Relates #23488
Closes #26090

Output from acceptance testing:

% make testacc TESTS=TestAccVPCSecurityGroup_ PKG=ec2         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSecurityGroup_'  -timeout 180m
--- PASS: TestAccVPCSecurityGroup_invalidCIDRBlock (9.79s)
--- PASS: TestAccVPCSecurityGroup_drift (93.59s)
--- PASS: TestAccVPCSecurityGroup_cidrAndGroups (104.10s)
--- PASS: TestAccVPCSecurityGroup_failWithDiffMismatch (105.54s)
--- PASS: TestAccVPCSecurityGroup_basic (111.49s)
--- PASS: TestAccVPCSecurityGroup_vpcNegOneIngress (111.68s)
--- PASS: TestAccVPCSecurityGroup_self (102.55s)
--- PASS: TestAccVPCSecurityGroup_vpc (112.34s)
--- PASS: TestAccVPCSecurityGroup_ipRangesWithSameRules (112.54s)
--- PASS: TestAccVPCSecurityGroup_driftComplex (114.84s)
--- PASS: TestAccVPCSecurityGroup_ingressWithCIDRAndSGsVPC (115.03s)
--- PASS: TestAccVPCSecurityGroup_ipv4AndIPv6Egress (121.28s)
--- PASS: TestAccVPCSecurityGroup_egressWithPrefixList (127.12s)
--- PASS: TestAccVPCSecurityGroup_ingressWithPrefixList (129.94s)
--- PASS: TestAccVPCSecurityGroup_rulesDropOnError (171.17s)
--- PASS: TestAccVPCSecurityGroup_RuleLimit_cidrBlockExceededAppend (187.09s)
--- PASS: TestAccVPCSecurityGroup_ipv6 (103.98s)
--- PASS: TestAccVPCSecurityGroup_defaultEgressVPC (96.23s)
--- PASS: TestAccVPCSecurityGroup_RuleLimit_exceededAppend (244.95s)
--- PASS: TestAccVPCSecurityGroup_namePrefixTerraform (106.25s)
--- PASS: TestAccVPCSecurityGroup_sourceSecurityGroup (115.38s)
--- PASS: TestAccVPCSecurityGroup_allowAll (115.61s)
--- PASS: TestAccVPCSecurityGroup_RuleLimit_exceededAllNew (230.75s)
--- PASS: TestAccVPCSecurityGroup_ipRangeAndSecurityGroupWithSameRules (118.60s)
--- PASS: TestAccVPCSecurityGroup_ruleGathering (125.96s)
--- PASS: TestAccVPCSecurityGroup_multiIngress (110.93s)
--- PASS: TestAccVPCSecurityGroup_RuleLimit_exceededPrepend (240.74s)
--- PASS: TestAccVPCSecurityGroup_vpcProtoNumIngress (87.60s)
--- PASS: TestAccVPCSecurityGroup_change (157.58s)
--- PASS: TestAccVPCSecurityGroup_nameTerraformPrefix (83.18s)
--- PASS: TestAccVPCSecurityGroup_disappears (59.65s)
--- PASS: TestAccVPCSecurityGroup_namePrefix (79.78s)
--- PASS: TestAccVPCSecurityGroup_nameGenerated (75.91s)
--- PASS: TestAccVPCSecurityGroup_ingressMode (186.22s)
--- PASS: TestAccVPCSecurityGroup_egressMode (173.33s)
--- PASS: TestAccVPCSecurityGroup_tags (182.14s)
--- PASS: TestAccVPCSecurityGroup_ruleDescription (128.42s)
--- PASS: TestAccVPCSecurityGroup_forceRevokeRulesTrue (487.29s)
--- PASS: TestAccVPCSecurityGroup_emrDependencyViolation (819.83s)
--- PASS: TestAccVPCSecurityGroup_forceRevokeRulesFalse (1213.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1243.196s
% make testacc TESTS=TestAccVPCDefaultSecurityGroup_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCDefaultSecurityGroup_'  -timeout 180m
--- PASS: TestAccVPCDefaultSecurityGroup_empty (45.12s)
--- PASS: TestAccVPCDefaultSecurityGroup_basic (63.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	64.994s
% make testacc TESTS=TestAccVPCSecurityGroupRule_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSecurityGroupRule_'  -timeout 180m
--- PASS: TestAccVPCSecurityGroupRule_expectInvalidTypeError (8.14s)
--- PASS: TestAccVPCSecurityGroupRule_prefixListEmptyString (8.45s)
--- PASS: TestAccVPCSecurityGroupRule_expectInvalidCIDR (10.47s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_icmpv6 (113.47s)
--- PASS: TestAccVPCSecurityGroupRule_selfReference (122.56s)
--- PASS: TestAccVPCSecurityGroupRule_egress (123.42s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_protocol (124.46s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_vpc (124.96s)
--- PASS: TestAccVPCSecurityGroupRule_issue5310 (124.97s)
--- PASS: TestAccVPCSecurityGroupRule_egressDescription (118.29s)
--- PASS: TestAccVPCSecurityGroupRule_selfSource (130.95s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_ipv6 (131.29s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource (137.94s)
--- PASS: TestAccVPCSecurityGroupRule_prefixListEgress (139.94s)
--- PASS: TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash (142.10s)
--- PASS: TestAccVPCSecurityGroupRule_PartialMatching_source (143.64s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_peeredVPC (138.29s)
--- PASS: TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts (173.84s)
--- PASS: TestAccVPCSecurityGroupRule_EgressDescription_updates (177.10s)
--- PASS: TestAccVPCSecurityGroupRule_IngressDescription_updates (176.52s)
--- PASS: TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id (81.66s)
--- PASS: TestAccVPCSecurityGroupRule_ingressDescription (81.45s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6 (88.87s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf (99.13s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_multipleIPv6 (83.11s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists (93.01s)
--- PASS: TestAccVPCSecurityGroupRule_PartialMatching_basic (100.79s)
--- PASS: TestAccVPCSecurityGroupRule_protocolChange (232.63s)
--- PASS: TestAccVPCSecurityGroupRule_Description_allPorts (113.62s)
--- PASS: TestAccVPCSecurityGroupRule_multiDescription (245.23s)
--- PASS: TestAccVPCSecurityGroupRule_race (264.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	265.527s
% make testacc TESTS=TestAccVPCSecurityGroupDataSource_ PKG=vpc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSecurityGroupDataSource_'  -timeout 180m
--- PASS: TestAccVPCSecurityGroupDataSource_basic (41.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	43.270s
% make testacc TESTS=TestAccVPCSecurityGroupsDataSource_ PKG=vpc   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSecurityGroupsDataSource_'  -timeout 180m
--- PASS: TestAccVPCSecurityGroupsDataSource_empty (27.66s)
--- PASS: TestAccVPCSecurityGroupsDataSource_filter (42.80s)
--- PASS: TestAccVPCSecurityGroupsDataSource_tag (43.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	45.272s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Aug 30, 2022
@YakDriver YakDriver mentioned this pull request Aug 30, 2022
Closed
@github-actions github-actions bot added the repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. label Aug 30, 2022
@ewbankkit
Copy link
Contributor

The go test error is a timeout in the internal/service/ec2 package:

panic: test timed out after 10m0s

goroutine 1101 [running]:
testing.(*M).startAlarm.func1()
	/opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:2029 +0x8e
created by time.goFunc
	/opt/hostedtoolcache/go/1.18.4/x64/src/time/sleep.go:176 +0x32

goroutine 1 [chan receive, 9 minutes]:
testing.(*T).Run(0xc002034ea0, {0xa56ea82?, 0x516285?}, 0xa6ae3e0)
	/opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1487 +0x37a
testing.runTests.func1(0xc002034ea0?)
	/opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1839 +0x6e
testing.tRunner(0xc00[203](https://github.com/hashicorp/terraform-provider-aws/runs/8103733354?check_suite_focus=true#step:7:204)4ea0, 0xc0016bfcd8)
	/opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1439 +0x102
testing.runTests(0xc00[204](https://github.com/hashicorp/terraform-provider-aws/runs/8103733354?check_suite_focus=true#step:7:205)46e0?, {0x10b6b3c0, 0x46b, 0x46b}, {0x7f263b5c85b8?, 0x40?, 0x10b79da0?})
	/opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1837 +0x457
testing.(*M).Run(0xc0020446e0)
	/opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1719 +0x5d9
main.main()
	_testmain.go:2309 +0x1aa

goroutine 50 [chan receive, 10 minutes]:
testing.(*T).Parallel(0xc002072d00)
	/opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1264 +0x1bf
github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.ParallelTest({0xb2dc748, 0xc002072d00}, {0x0, 0xc000947140, 0x0, 0xc00203b560, 0x0, 0x0, 0x0, 0x0, ...})
	/home/runner/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/[email protected]/helper/resource/testing.go:646 +0x55
github.com/hashicorp/terraform-provider-aws/internal/service/ec2_test.TestAccEC2EBSDefaultKMSKeyDataSource_basic(0xc002072d00)
	/home/runner/work/terraform-provider-aws/terraform-provider-aws/internal/service/ec2/ebs_default_kms_key_data_source_test.go:12 +0x207
testing.tRunner(0xc002072d00, 0xa6ac088)
	/opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1439 +0x102
created by testing.(*T).Run
	/opt/hostedtoolcache/go/1.18.4/x64/src/testing/testing.go:1486 +0x35f
...

ewbankkit
ewbankkit approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccVPCSecurityGroup\|TestAccVPCDefaultSecurityGroup' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCSecurityGroup\|TestAccVPCDefaultSecurityGroup -timeout 360m
=== RUN   TestAccVPCDefaultSecurityGroup_basic
=== PAUSE TestAccVPCDefaultSecurityGroup_basic
=== RUN   TestAccVPCDefaultSecurityGroup_empty
=== PAUSE TestAccVPCDefaultSecurityGroup_empty
=== RUN   TestAccVPCSecurityGroupDataSource_basic
=== PAUSE TestAccVPCSecurityGroupDataSource_basic
=== RUN   TestAccVPCSecurityGroupRule_Ingress_vpc
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_vpc
=== RUN   TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
=== PAUSE TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
=== RUN   TestAccVPCSecurityGroupRule_Ingress_protocol
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_protocol
=== RUN   TestAccVPCSecurityGroupRule_Ingress_icmpv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_icmpv6
=== RUN   TestAccVPCSecurityGroupRule_Ingress_ipv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_ipv6
=== RUN   TestAccVPCSecurityGroupRule_egress
=== PAUSE TestAccVPCSecurityGroupRule_egress
=== RUN   TestAccVPCSecurityGroupRule_selfReference
=== PAUSE TestAccVPCSecurityGroupRule_selfReference
=== RUN   TestAccVPCSecurityGroupRule_expectInvalidTypeError
=== PAUSE TestAccVPCSecurityGroupRule_expectInvalidTypeError
=== RUN   TestAccVPCSecurityGroupRule_expectInvalidCIDR
=== PAUSE TestAccVPCSecurityGroupRule_expectInvalidCIDR
=== RUN   TestAccVPCSecurityGroupRule_PartialMatching_basic
=== PAUSE TestAccVPCSecurityGroupRule_PartialMatching_basic
=== RUN   TestAccVPCSecurityGroupRule_PartialMatching_source
=== PAUSE TestAccVPCSecurityGroupRule_PartialMatching_source
=== RUN   TestAccVPCSecurityGroupRule_issue5310
=== PAUSE TestAccVPCSecurityGroupRule_issue5310
=== RUN   TestAccVPCSecurityGroupRule_race
=== PAUSE TestAccVPCSecurityGroupRule_race
=== RUN   TestAccVPCSecurityGroupRule_selfSource
=== PAUSE TestAccVPCSecurityGroupRule_selfSource
=== RUN   TestAccVPCSecurityGroupRule_prefixListEgress
=== PAUSE TestAccVPCSecurityGroupRule_prefixListEgress
=== RUN   TestAccVPCSecurityGroupRule_prefixListEmptyString
=== PAUSE TestAccVPCSecurityGroupRule_prefixListEmptyString
=== RUN   TestAccVPCSecurityGroupRule_ingressDescription
=== PAUSE TestAccVPCSecurityGroupRule_ingressDescription
=== RUN   TestAccVPCSecurityGroupRule_egressDescription
=== PAUSE TestAccVPCSecurityGroupRule_egressDescription
=== RUN   TestAccVPCSecurityGroupRule_IngressDescription_updates
=== PAUSE TestAccVPCSecurityGroupRule_IngressDescription_updates
=== RUN   TestAccVPCSecurityGroupRule_EgressDescription_updates
=== PAUSE TestAccVPCSecurityGroupRule_EgressDescription_updates
=== RUN   TestAccVPCSecurityGroupRule_Description_allPorts
=== PAUSE TestAccVPCSecurityGroupRule_Description_allPorts
=== RUN   TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
=== PAUSE TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
=== RUN   TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
=== PAUSE TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
=== RUN   TestAccVPCSecurityGroupRule_multiDescription
=== PAUSE TestAccVPCSecurityGroupRule_multiDescription
=== RUN   TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
=== RUN   TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
=== RUN   TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== RUN   TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
=== RUN   TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
=== RUN   TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
=== RUN   TestAccVPCSecurityGroupRule_protocolChange
=== PAUSE TestAccVPCSecurityGroupRule_protocolChange
=== RUN   TestAccVPCSecurityGroup_basic
=== PAUSE TestAccVPCSecurityGroup_basic
=== RUN   TestAccVPCSecurityGroup_disappears
=== PAUSE TestAccVPCSecurityGroup_disappears
=== RUN   TestAccVPCSecurityGroup_nameGenerated
=== PAUSE TestAccVPCSecurityGroup_nameGenerated
=== RUN   TestAccVPCSecurityGroup_nameTerraformPrefix
=== PAUSE TestAccVPCSecurityGroup_nameTerraformPrefix
=== RUN   TestAccVPCSecurityGroup_namePrefix
=== PAUSE TestAccVPCSecurityGroup_namePrefix
=== RUN   TestAccVPCSecurityGroup_namePrefixTerraform
=== PAUSE TestAccVPCSecurityGroup_namePrefixTerraform
=== RUN   TestAccVPCSecurityGroup_tags
=== PAUSE TestAccVPCSecurityGroup_tags
=== RUN   TestAccVPCSecurityGroup_allowAll
=== PAUSE TestAccVPCSecurityGroup_allowAll
=== RUN   TestAccVPCSecurityGroup_sourceSecurityGroup
=== PAUSE TestAccVPCSecurityGroup_sourceSecurityGroup
=== RUN   TestAccVPCSecurityGroup_ipRangeAndSecurityGroupWithSameRules
=== PAUSE TestAccVPCSecurityGroup_ipRangeAndSecurityGroupWithSameRules
=== RUN   TestAccVPCSecurityGroup_ipRangesWithSameRules
=== PAUSE TestAccVPCSecurityGroup_ipRangesWithSameRules
=== RUN   TestAccVPCSecurityGroup_egressMode
=== PAUSE TestAccVPCSecurityGroup_egressMode
=== RUN   TestAccVPCSecurityGroup_ingressMode
=== PAUSE TestAccVPCSecurityGroup_ingressMode
=== RUN   TestAccVPCSecurityGroup_ruleGathering
=== PAUSE TestAccVPCSecurityGroup_ruleGathering
=== RUN   TestAccVPCSecurityGroup_forceRevokeRulesTrue
=== PAUSE TestAccVPCSecurityGroup_forceRevokeRulesTrue
=== RUN   TestAccVPCSecurityGroup_forceRevokeRulesFalse
=== PAUSE TestAccVPCSecurityGroup_forceRevokeRulesFalse
=== RUN   TestAccVPCSecurityGroup_change
=== PAUSE TestAccVPCSecurityGroup_change
=== RUN   TestAccVPCSecurityGroup_ipv6
=== PAUSE TestAccVPCSecurityGroup_ipv6
=== RUN   TestAccVPCSecurityGroup_self
=== PAUSE TestAccVPCSecurityGroup_self
=== RUN   TestAccVPCSecurityGroup_vpc
=== PAUSE TestAccVPCSecurityGroup_vpc
=== RUN   TestAccVPCSecurityGroup_vpcNegOneIngress
=== PAUSE TestAccVPCSecurityGroup_vpcNegOneIngress
=== RUN   TestAccVPCSecurityGroup_vpcProtoNumIngress
=== PAUSE TestAccVPCSecurityGroup_vpcProtoNumIngress
=== RUN   TestAccVPCSecurityGroup_multiIngress
=== PAUSE TestAccVPCSecurityGroup_multiIngress
=== RUN   TestAccVPCSecurityGroup_ruleDescription
=== PAUSE TestAccVPCSecurityGroup_ruleDescription
=== RUN   TestAccVPCSecurityGroup_defaultEgressVPC
=== PAUSE TestAccVPCSecurityGroup_defaultEgressVPC
=== RUN   TestAccVPCSecurityGroup_drift
=== PAUSE TestAccVPCSecurityGroup_drift
=== RUN   TestAccVPCSecurityGroup_driftComplex
=== PAUSE TestAccVPCSecurityGroup_driftComplex
=== RUN   TestAccVPCSecurityGroup_invalidCIDRBlock
=== PAUSE TestAccVPCSecurityGroup_invalidCIDRBlock
=== RUN   TestAccVPCSecurityGroup_cidrAndGroups
=== PAUSE TestAccVPCSecurityGroup_cidrAndGroups
=== RUN   TestAccVPCSecurityGroup_ingressWithCIDRAndSGsVPC
=== PAUSE TestAccVPCSecurityGroup_ingressWithCIDRAndSGsVPC
=== RUN   TestAccVPCSecurityGroup_egressWithPrefixList
=== PAUSE TestAccVPCSecurityGroup_egressWithPrefixList
=== RUN   TestAccVPCSecurityGroup_ingressWithPrefixList
=== PAUSE TestAccVPCSecurityGroup_ingressWithPrefixList
=== RUN   TestAccVPCSecurityGroup_ipv4AndIPv6Egress
=== PAUSE TestAccVPCSecurityGroup_ipv4AndIPv6Egress
=== RUN   TestAccVPCSecurityGroup_failWithDiffMismatch
=== PAUSE TestAccVPCSecurityGroup_failWithDiffMismatch
=== RUN   TestAccVPCSecurityGroup_RuleLimit_exceededAppend
=== PAUSE TestAccVPCSecurityGroup_RuleLimit_exceededAppend
=== RUN   TestAccVPCSecurityGroup_RuleLimit_cidrBlockExceededAppend
=== PAUSE TestAccVPCSecurityGroup_RuleLimit_cidrBlockExceededAppend
=== RUN   TestAccVPCSecurityGroup_RuleLimit_exceededPrepend
=== PAUSE TestAccVPCSecurityGroup_RuleLimit_exceededPrepend
=== RUN   TestAccVPCSecurityGroup_RuleLimit_exceededAllNew
=== PAUSE TestAccVPCSecurityGroup_RuleLimit_exceededAllNew
=== RUN   TestAccVPCSecurityGroup_rulesDropOnError
=== PAUSE TestAccVPCSecurityGroup_rulesDropOnError
=== RUN   TestAccVPCSecurityGroup_emrDependencyViolation
=== PAUSE TestAccVPCSecurityGroup_emrDependencyViolation
=== RUN   TestAccVPCSecurityGroupsDataSource_tag
=== PAUSE TestAccVPCSecurityGroupsDataSource_tag
=== RUN   TestAccVPCSecurityGroupsDataSource_filter
=== PAUSE TestAccVPCSecurityGroupsDataSource_filter
=== RUN   TestAccVPCSecurityGroupsDataSource_empty
=== PAUSE TestAccVPCSecurityGroupsDataSource_empty
=== CONT  TestAccVPCDefaultSecurityGroup_basic
=== CONT  TestAccVPCSecurityGroup_namePrefixTerraform
--- PASS: TestAccVPCSecurityGroup_namePrefixTerraform (27.28s)
=== CONT  TestAccVPCSecurityGroup_defaultEgressVPC
--- PASS: TestAccVPCDefaultSecurityGroup_basic (35.15s)
=== CONT  TestAccVPCSecurityGroupsDataSource_empty
--- PASS: TestAccVPCSecurityGroupsDataSource_empty (12.39s)
=== CONT  TestAccVPCSecurityGroupsDataSource_filter
--- PASS: TestAccVPCSecurityGroup_defaultEgressVPC (26.32s)
=== CONT  TestAccVPCSecurityGroupsDataSource_tag
--- PASS: TestAccVPCSecurityGroupsDataSource_filter (25.13s)
=== CONT  TestAccVPCSecurityGroup_emrDependencyViolation
--- PASS: TestAccVPCSecurityGroupsDataSource_tag (23.79s)
=== CONT  TestAccVPCSecurityGroup_rulesDropOnError
--- PASS: TestAccVPCSecurityGroup_rulesDropOnError (44.80s)
=== CONT  TestAccVPCSecurityGroup_RuleLimit_exceededAllNew
--- PASS: TestAccVPCSecurityGroup_RuleLimit_exceededAllNew (52.68s)
=== CONT  TestAccVPCSecurityGroup_RuleLimit_exceededPrepend
--- PASS: TestAccVPCSecurityGroup_RuleLimit_exceededPrepend (50.88s)
=== CONT  TestAccVPCSecurityGroup_RuleLimit_cidrBlockExceededAppend
--- PASS: TestAccVPCSecurityGroup_RuleLimit_cidrBlockExceededAppend (41.33s)
=== CONT  TestAccVPCSecurityGroup_RuleLimit_exceededAppend
--- PASS: TestAccVPCSecurityGroup_RuleLimit_exceededAppend (65.25s)
=== CONT  TestAccVPCSecurityGroup_failWithDiffMismatch
--- PASS: TestAccVPCSecurityGroup_failWithDiffMismatch (29.13s)
=== CONT  TestAccVPCSecurityGroup_forceRevokeRulesFalse
--- PASS: TestAccVPCSecurityGroup_emrDependencyViolation (831.65s)
=== CONT  TestAccVPCSecurityGroup_ruleDescription
--- PASS: TestAccVPCSecurityGroup_ruleDescription (56.41s)
=== CONT  TestAccVPCSecurityGroup_multiIngress
--- PASS: TestAccVPCSecurityGroup_multiIngress (32.76s)
=== CONT  TestAccVPCSecurityGroup_vpcProtoNumIngress
--- PASS: TestAccVPCSecurityGroup_vpcProtoNumIngress (25.52s)
=== CONT  TestAccVPCSecurityGroup_vpcNegOneIngress
--- PASS: TestAccVPCSecurityGroup_vpcNegOneIngress (23.64s)
=== CONT  TestAccVPCSecurityGroup_ipv4AndIPv6Egress
--- PASS: TestAccVPCSecurityGroup_ipv4AndIPv6Egress (34.17s)
=== CONT  TestAccVPCSecurityGroup_ingressWithPrefixList
--- PASS: TestAccVPCSecurityGroup_ingressWithPrefixList (38.59s)
=== CONT  TestAccVPCSecurityGroup_egressWithPrefixList
--- PASS: TestAccVPCSecurityGroup_egressWithPrefixList (40.30s)
=== CONT  TestAccVPCSecurityGroup_vpc
--- PASS: TestAccVPCSecurityGroup_vpc (27.85s)
=== CONT  TestAccVPCSecurityGroup_ingressWithCIDRAndSGsVPC
--- PASS: TestAccVPCSecurityGroup_ingressWithCIDRAndSGsVPC (31.76s)
=== CONT  TestAccVPCSecurityGroup_self
--- PASS: TestAccVPCSecurityGroup_self (25.03s)
=== CONT  TestAccVPCSecurityGroupRule_egressDescription
--- PASS: TestAccVPCSecurityGroupRule_egressDescription (19.97s)
=== CONT  TestAccVPCSecurityGroup_cidrAndGroups
--- PASS: TestAccVPCSecurityGroup_cidrAndGroups (28.23s)
=== CONT  TestAccVPCSecurityGroup_ipv6
--- PASS: TestAccVPCSecurityGroup_ipv6 (25.25s)
=== CONT  TestAccVPCSecurityGroup_invalidCIDRBlock
--- PASS: TestAccVPCSecurityGroup_invalidCIDRBlock (1.98s)
=== CONT  TestAccVPCSecurityGroup_change
--- PASS: TestAccVPCSecurityGroup_change (37.43s)
=== CONT  TestAccVPCSecurityGroup_namePrefix
--- PASS: TestAccVPCSecurityGroup_namePrefix (24.30s)
=== CONT  TestAccVPCSecurityGroup_driftComplex
--- PASS: TestAccVPCSecurityGroup_driftComplex (30.90s)
=== CONT  TestAccVPCSecurityGroup_nameTerraformPrefix
--- PASS: TestAccVPCSecurityGroup_forceRevokeRulesFalse (1080.95s)
=== CONT  TestAccVPCSecurityGroup_drift
--- PASS: TestAccVPCSecurityGroup_nameTerraformPrefix (26.97s)
=== CONT  TestAccVPCSecurityGroup_ipRangesWithSameRules
--- PASS: TestAccVPCSecurityGroup_drift (19.70s)
=== CONT  TestAccVPCSecurityGroup_ruleGathering
--- PASS: TestAccVPCSecurityGroup_ipRangesWithSameRules (25.78s)
=== CONT  TestAccVPCSecurityGroup_nameGenerated
--- PASS: TestAccVPCSecurityGroup_nameGenerated (24.44s)
=== CONT  TestAccVPCSecurityGroup_forceRevokeRulesTrue
--- PASS: TestAccVPCSecurityGroup_ruleGathering (40.36s)
=== CONT  TestAccVPCSecurityGroup_disappears
--- PASS: TestAccVPCSecurityGroup_disappears (21.36s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_protocol
--- PASS: TestAccVPCSecurityGroupRule_Ingress_protocol (24.98s)
=== CONT  TestAccVPCSecurityGroup_basic
--- PASS: TestAccVPCSecurityGroup_basic (24.54s)
=== CONT  TestAccVPCSecurityGroupRule_selfReference
--- PASS: TestAccVPCSecurityGroupRule_selfReference (25.55s)
=== CONT  TestAccVPCSecurityGroupRule_protocolChange
--- PASS: TestAccVPCSecurityGroupRule_protocolChange (61.72s)
=== CONT  TestAccVPCSecurityGroupRule_egress
--- PASS: TestAccVPCSecurityGroupRule_egress (21.10s)
=== CONT  TestAccVPCSecurityGroupRule_expectInvalidTypeError
--- PASS: TestAccVPCSecurityGroupRule_expectInvalidTypeError (0.89s)
=== CONT  TestAccVPCSecurityGroup_ingressMode
--- PASS: TestAccVPCSecurityGroup_ingressMode (47.87s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_ipv6
--- PASS: TestAccVPCSecurityGroupRule_Ingress_ipv6 (26.11s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
--- PASS: TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource (34.80s)
=== CONT  TestAccVPCSecurityGroupRule_ingressDescription
--- PASS: TestAccVPCSecurityGroupRule_ingressDescription (26.31s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_icmpv6
--- PASS: TestAccVPCSecurityGroup_forceRevokeRulesTrue (338.71s)
=== CONT  TestAccVPCSecurityGroup_egressMode
--- PASS: TestAccVPCSecurityGroupRule_Ingress_icmpv6 (28.40s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
--- PASS: TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf (33.20s)
=== CONT  TestAccVPCSecurityGroupRule_prefixListEmptyString
--- PASS: TestAccVPCSecurityGroupRule_prefixListEmptyString (0.96s)
=== CONT  TestAccVPCSecurityGroupRule_issue5310
--- PASS: TestAccVPCSecurityGroup_egressMode (53.69s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
--- PASS: TestAccVPCSecurityGroupRule_issue5310 (20.02s)
=== CONT  TestAccVPCSecurityGroupRule_selfSource
--- PASS: TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6 (25.24s)
=== CONT  TestAccVPCSecurityGroupRule_race
--- PASS: TestAccVPCSecurityGroupRule_selfSource (26.10s)
=== CONT  TestAccVPCSecurityGroupRule_PartialMatching_source
--- PASS: TestAccVPCSecurityGroupRule_PartialMatching_source (28.67s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_peeredVPC
    acctest.go:644: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccVPCSecurityGroupRule_Ingress_peeredVPC (0.00s)
=== CONT  TestAccVPCSecurityGroupRule_prefixListEgress
--- PASS: TestAccVPCSecurityGroupRule_prefixListEgress (35.67s)
=== CONT  TestAccVPCSecurityGroup_sourceSecurityGroup
--- PASS: TestAccVPCSecurityGroup_sourceSecurityGroup (27.59s)
=== CONT  TestAccVPCSecurityGroupRule_PartialMatching_basic
--- PASS: TestAccVPCSecurityGroupRule_PartialMatching_basic (33.56s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
--- PASS: TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists (31.13s)
=== CONT  TestAccVPCSecurityGroupRule_expectInvalidCIDR
--- PASS: TestAccVPCSecurityGroupRule_expectInvalidCIDR (1.35s)
=== CONT  TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
--- PASS: TestAccVPCSecurityGroupRule_race (177.33s)
=== CONT  TestAccVPCSecurityGroupRule_Description_allPorts
--- PASS: TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts (33.55s)
=== CONT  TestAccVPCSecurityGroup_ipRangeAndSecurityGroupWithSameRules
--- PASS: TestAccVPCSecurityGroupRule_Description_allPorts (32.37s)
=== CONT  TestAccVPCSecurityGroupRule_multiDescription
--- PASS: TestAccVPCSecurityGroup_ipRangeAndSecurityGroupWithSameRules (29.52s)
=== CONT  TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
--- PASS: TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash (26.82s)
=== CONT  TestAccVPCSecurityGroupRule_EgressDescription_updates
--- PASS: TestAccVPCSecurityGroupRule_multiDescription (70.66s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_vpc
--- PASS: TestAccVPCSecurityGroupRule_EgressDescription_updates (33.08s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
--- PASS: TestAccVPCSecurityGroupRule_Ingress_vpc (22.07s)
=== CONT  TestAccVPCSecurityGroupRule_IngressDescription_updates
--- PASS: TestAccVPCSecurityGroupRule_Ingress_multipleIPv6 (26.61s)
=== CONT  TestAccVPCSecurityGroup_allowAll
--- PASS: TestAccVPCSecurityGroupRule_IngressDescription_updates (34.84s)
=== CONT  TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
--- PASS: TestAccVPCSecurityGroup_allowAll (27.86s)
=== CONT  TestAccVPCSecurityGroup_tags
--- PASS: TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id (23.26s)
=== CONT  TestAccVPCSecurityGroupDataSource_basic
--- PASS: TestAccVPCSecurityGroupDataSource_basic (25.46s)
=== CONT  TestAccVPCDefaultSecurityGroup_empty
--- PASS: TestAccVPCSecurityGroup_tags (58.69s)
--- PASS: TestAccVPCDefaultSecurityGroup_empty (22.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	2332.892s

@YakDriver YakDriver force-pushed the b-sg-inline-rule-dep-violation branch 2 times, most recently from e357672 to cc5602c Compare August 31, 2022 15:30
@YakDriver YakDriver force-pushed the b-sg-inline-rule-dep-violation branch from cc5602c to 16b47c9 Compare August 31, 2022 15:57
@YakDriver YakDriver merged commit 53a488d into main Aug 31, 2022
@YakDriver YakDriver deleted the b-sg-inline-rule-dep-violation branch August 31, 2022 19:27
@github-actions github-actions bot added this to the v4.29.0 milestone Aug 31, 2022
github-actions bot pushed a commit that referenced this pull request Aug 31, 2022
Update CHANGELOG.md for #26553
294acce
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.29.0
Development

Successfully merging this pull request may close these issues.

Security Group /security Group-rule recreation error resource_aws_security_group: DependencyViolation assumes ENI HyperPlane deletion issue Terraform sending incorrect parameters to AWS API when revoking security group rules Terraform is unable to destroy AWS VPC on of EMR cluster aws_security_group: DependencyViolation: resource sg-XXX has a dependent object
DependencyViolation on changing aws_alb security group DependencyViolation when deleting security group associated to lambda and vpc_endpoint Terraform plan or destroy fails when an aws resource that is referenced by another resource is removed outside of terraform. Security Group resource fails to destroy when a rule references another group or entity that does not exist EKS node group deletion fails due to "Ec2SecurityGroupDeletionFailure: DependencyViolation - resource has a dependent object. Resource IDs: [sg-example]
2 participants
@YakDriver @ewbankkit