Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws_ce_anomaly_subscription crash on update of monitor_arn_list #25941

Merged
merged 4 commits into from
Jul 22, 2022
Merged

Fix aws_ce_anomaly_subscription crash on update of monitor_arn_list #25941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eea362d
Adjust test to not force recreate of resource
ahuseby Jul 22, 2022
c25bb67
Use function expandAnomalySubscriptionMonitorARNList for updating sub…
ahuseby Jul 22, 2022
fbbc34a
Adding changelog file
ahuseby Jul 22, 2022
81016c8
Remove unnecessary edit of 'frequency'
ahuseby Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/25941.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_ce_anomaly_subscription:Fix crash upon adding or removing monitor ARNs to `monitor_arn_list`.
```
2 changes: 1 addition & 1 deletion internal/service/ce/anomaly_subscription.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func resourceAnomalySubscriptionUpdate(ctx context.Context, d *schema.ResourceDa
}

if d.HasChange("monitor_arn_list") {
input.MonitorArnList = aws.StringSlice(d.Get("monitor_arn_list").([]string))
input.MonitorArnList = aws.StringSlice(expandAnomalySubscriptionMonitorARNList(d.Get("monitor_arn_list").([]interface{})))
requestUpdate = true
}

Expand Down
3 changes: 1 addition & 2 deletions internal/service/ce/anomaly_subscription_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ func TestAccCEAnomalySubscription_MonitorARNList(t *testing.T) {
resourceName := "aws_ce_anomaly_subscription.test"
rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
rName2 := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
rName3 := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
domain := acctest.RandomDomainName()
address := acctest.RandomEmailAddress(domain)

Expand All @@ -143,7 +142,7 @@ func TestAccCEAnomalySubscription_MonitorARNList(t *testing.T) {
ImportStateVerify: true,
},
{
Config: testAccAnomalySubscriptionConfig_monitorARNList(rName2, rName3, address),
Config: testAccAnomalySubscriptionConfig_monitorARNList(rName, rName2, address),
Check: resource.ComposeAggregateTestCheckFunc(
testAccCheckAnomalySubscriptionExists(resourceName, &subscription),
resource.TestCheckResourceAttrPair(resourceName, "monitor_arn_list.0", "aws_ce_anomaly_monitor.test", "arn"),
Expand Down