Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/aws sagemaker export 23968 #24004

Closed
wants to merge 10,000 commits into from
Closed

F/aws sagemaker export 23968 #24004

wants to merge 10,000 commits into from

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 2, 2022 •
edited by justinretzolk
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23968

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@nikhil-goenka
f/aws_securityhub_member: email is optional variable
aa10f09
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
07acfdf
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
730f05a
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
f4720fe
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
5f8696e
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
caffc1b
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
92f64eb
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
cb66379
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
a82cb48
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
d59b962
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
2265c19
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
d608550
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
24585b8
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
a5cc9e5
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
3d0053e
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
9b90969
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
f9ee82b
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
da57256
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
b44d093
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
d6de354
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
47eb713
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
fdfe6a7
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
751513f
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
49e7dd0
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
ffb24d1
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
404cb94
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
395f7b5
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
9bd1aa0
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
173390d
@nikhil-goenka
f/aws_securityhub_member: email is optional variable
41ae4f3
nikhil-goenka and others added 12 commits September 2, 2021 09:54
@nikhil-goenka
support for EBS Multi-Attach for io2 volumes
aafd993
@nikhil-goenka
support for EBS Multi-Attach for io2 volumes
c1e3017
@nikhil-goenka
Support for s3_object_acl
46c4cf0
@nikhil-goenka
Delegated Option for CloudFormation create-stack-set
9f6f441
@nikhil-goenka
Support for Delegated Option for CloudFormation create-stack-set
4114a94
@craiggenner @nikhil-goenka
ASG - as per the docs and the error given on the API the min value fo…
98612d3 
…r max_instance_lifetime is 86400
@nicwaller @nikhil-goenka
Correcting aws_launch_template.metadata_options.http_endpoint (hashic…
7f9beb5 
…orp#20701)

As shown in hashicorp#20493 the documentation does not accurately reflect the current observed behaviour of this provider. The docs say that metadata_options.http_endpoint is optional, but the provider gives an error if http_endpoint is omitted.
@nikhil-goenka
Merge remote-tracking branch 'origin/master'
ff8cf6b
@nikhil-goenka
Merge remote-tracking branch 'upstream/main'
e9a686e 
# Conflicts:
#	aws/resource_aws_cloudformation_stack_set.go
#	aws/resource_aws_ebs_volume.go
#	aws/resource_aws_ebs_volume_test.go
#	aws/resource_aws_securityhub_member_test.go
#	website/docs/r/autoscaling_group.html.markdown
@nikhil-goenka
Merge branch 'hashicorp:main' into master
1c525e0
@nikhil-goenka
f/aws_sagemaker_23968
766ee8a
@nikhil-goenka
f/aws_sagemaker_23968
b861fed
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/sagemaker Issues and PRs that pertain to the sagemaker service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Apr 2, 2022
@bschaatsbergen
Copy link
Member

bschaatsbergen commented Apr 4, 2022 •
edited
Loading

Few drive-by comments:

Now that the image attribute became optional I would suggest treating the image attribute the same as the other attributes in flattenContainer() and expandContainer().

Also, please create/update tests to include a test for the attribute you've added and add the output of the tests you ran to the PR.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Apr 4, 2022
@michaelrod64
Copy link

Are there any plans to merge this change?

@AlbertoRossettini
Copy link

Hi, any chance of this being merged soon?

@bschaatsbergen
Copy link
Member

I'm happy to pick up this PR if @nikhil-goenka can't make the suggested changes

@bschaatsbergen bschaatsbergen self-assigned this May 31, 2023
@holly-evans holly-evans mentioned this pull request Jun 4, 2023
Merged
@holly-evans
Copy link
Contributor

@bschaatsbergen I addressed your feedback in #31755. Please use it if it is helpful to you!

@bschaatsbergen
Copy link
Member

Ah great, I'll check this out tonight @holly-evans

@bschaatsbergen
Copy link
Member

Thanks for picking this up @holly-evans, we're closing to having your PR merged 🥇

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mateuszboryn mateuszboryn mateuszboryn approved these changes

Assignees

@bschaatsbergen bschaatsbergen

Labels
documentation Introduces or discusses updates to documentation. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_sagemaker_model support for ModelPackage ARN
9 participants
@nikhil-goenka @bschaatsbergen @michaelrod64 @AlbertoRossettini @holly-evans @mateuszboryn @justinretzolk @craiggenner @nicwaller