Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close account w/tests #23950

Closed
wants to merge 7 commits into from
Closed

close account w/tests #23950

wants to merge 7 commits into from

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Mar 30, 2022 •
edited
Loading

This PR is a continuation branch of #23931 with the recommended changes for testing. Since I have exceeded my quota on my personal accounts, I can not run this. This also increases the tshirt size so feel free to consider that when reviewing.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #23931

Output from acceptance testing:

$ export TEST_AWS_ORGANIZATION_ACCOUNT_EMAIL_DOMAIN="amazon.com"
$ make testacc TESTARGS="-run=TestAccAccount_" PKG_NAME="./internal/service/organizations" ACCTEST_PARALLELISM=1
## Can not execute due to quota exceeded
...

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/macie2 Issues and PRs that pertain to the macie2 service. service/organizations Issues and PRs that pertain to the organizations service. service/securityhub Issues and PRs that pertain to the securityhub service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Mar 30, 2022
drewmullen
drewmullen reviewed Mar 30, 2022
View reviewed changes
internal/service/organizations/account_test.go
@@ -14,8 +14,7 @@ import (
"github.com/hashicorp/terraform-provider-aws/internal/conns"
)

func testAccAccount_basic(t *testing.T) {
acctest.Skip(t, "AWS Organizations Account testing is not currently automated due to manual account deletion steps.")
Copy link
Collaborator

@drewmullen drewmullen Mar 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add environment varlables to make it easier to run tests when desired vs always skipping

@danquack danquack closed this Mar 30, 2022
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Mar 30, 2022
@danquack
Copy link
Contributor Author

danquack commented Mar 30, 2022 •
edited
Loading

Im just going to merge this into #23931 and can work off of that.

@github-actions
Copy link

github-actions bot commented May 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drewmullen drewmullen drewmullen left review comments

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/macie2 Issues and PRs that pertain to the macie2 service. service/organizations Issues and PRs that pertain to the organizations service. service/securityhub Issues and PRs that pertain to the securityhub service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danquack @drewmullen