Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/s3_bucket_versioning: backport #23723; support management of resource with disabled versioning #23731

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Mar 17, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23718, #23723

Output from acceptance testing:

--- PASS: TestAccS3BucketVersioning_disappears (280.76s)
--- PASS: TestAccS3BucketVersioning_basic (290.73s)
--- PASS: TestAccS3BucketVersioning_MFADelete (290.74s)
--- PASS: TestAccS3BucketVersioning_Status_disabled (300.21s)
--- PASS: TestAccS3BucketVersioning_Status_enabledToDisabled (321.62s)
--- PASS: TestAccS3BucketVersioning_Status_suspendedToDisabled (321.81s)
--- PASS: TestAccS3BucketVersioning_migrate_versioningEnabledNoChange (370.38s)
--- PASS: TestAccS3BucketVersioning_migrate_versioningEnabledWithChange (370.43s)
--- PASS: TestAccS3BucketVersioning_migrate_mfaDeleteNoChange (370.49s)
--- PASS: TestAccS3BucketVersioning_migrate_versioningDisabledWithChange (370.49s)
--- PASS: TestAccS3BucketVersioning_migrate_versioningDisabledNoChange (380.05s)
--- PASS: TestAccS3BucketVersioning_Status_disabledToEnabled (397.90s)
--- PASS: TestAccS3BucketVersioning_Status_disabledToSuspended (401.68s)
--- PASS: TestAccS3BucketVersioning_update (426.75s)

@anGie44 anGie44 marked this pull request as ready for review March 17, 2022 15:26
@anGie44 anGie44 added this to the v3.75.0 milestone Mar 17, 2022
@anGie44 anGie44 force-pushed the backport-bucket-versioning-fix branch from 7191153 to e246f57 Compare March 17, 2022 17:05
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 17, 2022
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 17, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 merged commit 3dc5e08 into release/3.x Mar 17, 2022
@anGie44 anGie44 deleted the backport-bucket-versioning-fix branch March 17, 2022 17:42
github-actions bot pushed a commit that referenced this pull request Mar 17, 2022
@github-actions
Copy link

This functionality has been released in v3.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants