Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2218 Allow adding/removing of ElastiCache Clusters to an existing ElastiCache Replication Group #2287

Closed
wants to merge 2 commits into from

Conversation

delphyne
Copy link
Contributor

Hello all, I'm looking for feedback on this PR. This covers issue #2218. The current provider implementation requires updates to the number_cache_clusters property of the aws_elasticache_replication_group resource. This is a "force new" operation, which means you cannot dynamically scale your cluster.

@radeksimko radeksimko added enhancement Requests to existing resources that expand the functionality or scope. size/L Managed by automation to categorize the size of a PR. labels Nov 15, 2017
@delphyne delphyne changed the title [WIP] #2218 Allow adding/removing of ElastiCache Clusters to an existing ElastiCache Replication Group #2218 Allow adding/removing of ElastiCache Clusters to an existing ElastiCache Replication Group Nov 28, 2017
@delphyne
Copy link
Contributor Author

@radeksimko any motion on this? are there any issues that you wish to have addressed?

@bflad bflad added the service/elasticache Issues and PRs that pertain to the elasticache service. label Jan 28, 2018
@bflad
Copy link
Contributor

bflad commented Mar 22, 2018

Hi @delphyne 👋 We're really sorry no one got back to you sooner about this pull request. It was mostly in good shape except for needing acceptance testing, some additional documentation, and addressing the interface conversion panics. We had some internal priority for finishing this up so I went ahead and submitted a continuation PR (with your commits in tact 😄 ) at #3869. It should land into master in the next few days and release with v1.12.0 of the AWS provider.

Again, thanks so much for your contribution. We're looking at ways we can reduce the review/merge lag for enhancement pull requests like this one.

@delphyne
Copy link
Contributor Author

Thanks @bflad.

this PR replaced and extended by PR #3869

@delphyne delphyne closed this Mar 22, 2018
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants