Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump aws sdk to v1.12.25 #2229

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Bump aws sdk to v1.12.25 #2229

merged 1 commit into from
Nov 9, 2017

Conversation

atsushi-ishibashi
Copy link
Contributor

Required for #2227

Depend on #2214

govendor fetch github.com/aws/aws-sdk-go/aws/[email protected]
govendor fetch github.com/aws/aws-sdk-go/internal/[email protected]
govendor fetch github.com/aws/aws-sdk-go/private/[email protected]
govendor fetch github.com/aws/aws-sdk-go/service/[email protected]

radeksimko
radeksimko approved these changes Nov 9, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think we don't need to wait for #2214 - skipping a version is OK, IMO.

@radeksimko radeksimko added the dependencies Used to indicate dependency changes. label Nov 9, 2017
@radeksimko radeksimko merged commit ab4bf3b into hashicorp:master Nov 9, 2017
@radeksimko radeksimko mentioned this pull request Nov 9, 2017
Closed
@atsushi-ishibashi atsushi-ishibashi deleted the bump-aws-sdk-1.12.25 branch December 13, 2017 15:16
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atsushi-ishibashi @radeksimko