-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sweep/servicatalog_provisioned_product: set accessLevelFilter.value
with self
#21371
Conversation
Pull request #21306 has significantly refactored the AWS Provider codebase. As Specifically, PR #21306 relocated the code for all AWS resources and data We recognize that many pull requests have been open for some time without yet For a more complete description of this refactor, including examples of how old For a quick guide on how to amend your pull request to resolve the merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% go test ./internal/sweep -v -tags=sweep -sweep=us-east-1,us-east-2,us-west-1,us-west-2 -sweep-run=aws_servicecatalog_provisioned_product -timeout 60m
2021/10/19 12:01:00 [DEBUG] Running Sweepers for region (us-east-1):
2021/10/19 12:01:00 [DEBUG] Running Sweeper (aws_servicecatalog_provisioned_product) in region (us-east-1)
2021/10/19 12:01:00 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 12:01:00 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:01 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:01 [DEBUG] Completed Sweeper (aws_servicecatalog_provisioned_product) in region (us-east-1) in 892.120573ms
2021/10/19 12:01:01 Completed Sweepers for region (us-east-1) in 892.301428ms
2021/10/19 12:01:01 Sweeper Tests for region (us-east-1) ran successfully:
- aws_servicecatalog_provisioned_product
2021/10/19 12:01:01 [DEBUG] Running Sweepers for region (us-east-2):
2021/10/19 12:01:01 [DEBUG] Running Sweeper (aws_servicecatalog_provisioned_product) in region (us-east-2)
2021/10/19 12:01:01 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 12:01:01 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:01 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:02 [DEBUG] Completed Sweeper (aws_servicecatalog_provisioned_product) in region (us-east-2) in 668.988444ms
2021/10/19 12:01:02 Completed Sweepers for region (us-east-2) in 669.069535ms
2021/10/19 12:01:02 Sweeper Tests for region (us-east-2) ran successfully:
- aws_servicecatalog_provisioned_product
2021/10/19 12:01:02 [DEBUG] Running Sweepers for region (us-west-1):
2021/10/19 12:01:02 [DEBUG] Running Sweeper (aws_servicecatalog_provisioned_product) in region (us-west-1)
2021/10/19 12:01:02 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 12:01:02 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:02 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:03 [DEBUG] Completed Sweeper (aws_servicecatalog_provisioned_product) in region (us-west-1) in 1.198021823s
2021/10/19 12:01:03 Completed Sweepers for region (us-west-1) in 1.19811266s
2021/10/19 12:01:03 Sweeper Tests for region (us-west-1) ran successfully:
- aws_servicecatalog_provisioned_product
2021/10/19 12:01:03 [DEBUG] Running Sweepers for region (us-west-2):
2021/10/19 12:01:03 [DEBUG] Running Sweeper (aws_servicecatalog_provisioned_product) in region (us-west-2)
2021/10/19 12:01:03 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 12:01:03 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:03 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:04 [DEBUG] Completed Sweeper (aws_servicecatalog_provisioned_product) in region (us-west-2) in 1.169912217s
2021/10/19 12:01:04 Completed Sweepers for region (us-west-2) in 1.169991262s
2021/10/19 12:01:04 Sweeper Tests for region (us-west-2) ran successfully:
- aws_servicecatalog_provisioned_product
ok github.com/hashicorp/terraform-provider-aws/internal/sweep 6.706s
This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #21370
Output from acceptance testing: