Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sweep/servicatalog_provisioned_product: set accessLevelFilter.value with self #21371

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Oct 19, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21370

Output from acceptance testing:

SWEEP=us-west-2 SWEEPARGS=-sweep-run=aws_servicecatalog_provisioned_product make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2 -sweep-run=aws_servicecatalog_provisioned_product -timeout 60m
2021/10/19 11:04:40 [DEBUG] Running Sweepers for region (us-west-2):
2021/10/19 11:04:40 [DEBUG] Running Sweeper (aws_servicecatalog_provisioned_product) in region (us-west-2)
2021/10/19 11:04:40 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 11:04:40 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 11:04:41 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 11:04:42 [DEBUG] Completed Sweeper (aws_servicecatalog_provisioned_product) in region (us-west-2) in 1.096087403s
2021/10/19 11:04:42 Completed Sweepers for region (us-west-2) in 1.096276406s
2021/10/19 11:04:42 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_servicecatalog_provisioned_product
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	3.342s

@anGie44 anGie44 added the sweeper Pertains to changes to or issues with the sweeper. label Oct 19, 2021
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. labels Oct 19, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As
a result, most PRs opened prior to the refactor now have merge conflicts that
must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data
sources from a single aws directory to a large number of separate directories
in internal/service, each corresponding to a particular AWS service. This
separation of code has also allowed for us to simplify the names of underlying
functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet
being addressed by our maintainers. Therefore, we want to make it clear that
resolving these conflicts in no way affect the prioritization of a particular
pull request. Once a pull request has been prioritized for review, the
necessary changes will be made by a maintainer -- either directly on in
collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old
filepaths and function names correspond to their new counterparts: please refer
to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge
conflicts resulting from this refactor and bring it in line with our new code
patterns: please refer to our Service Package Refactor Pull Request
Guide
.

@ewbankkit ewbankkit self-assigned this Oct 19, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test ./internal/sweep -v -tags=sweep -sweep=us-east-1,us-east-2,us-west-1,us-west-2 -sweep-run=aws_servicecatalog_provisioned_product -timeout 60m
2021/10/19 12:01:00 [DEBUG] Running Sweepers for region (us-east-1):
2021/10/19 12:01:00 [DEBUG] Running Sweeper (aws_servicecatalog_provisioned_product) in region (us-east-1)
2021/10/19 12:01:00 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 12:01:00 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:01 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:01 [DEBUG] Completed Sweeper (aws_servicecatalog_provisioned_product) in region (us-east-1) in 892.120573ms
2021/10/19 12:01:01 Completed Sweepers for region (us-east-1) in 892.301428ms
2021/10/19 12:01:01 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_servicecatalog_provisioned_product
2021/10/19 12:01:01 [DEBUG] Running Sweepers for region (us-east-2):
2021/10/19 12:01:01 [DEBUG] Running Sweeper (aws_servicecatalog_provisioned_product) in region (us-east-2)
2021/10/19 12:01:01 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 12:01:01 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:01 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:02 [DEBUG] Completed Sweeper (aws_servicecatalog_provisioned_product) in region (us-east-2) in 668.988444ms
2021/10/19 12:01:02 Completed Sweepers for region (us-east-2) in 669.069535ms
2021/10/19 12:01:02 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_servicecatalog_provisioned_product
2021/10/19 12:01:02 [DEBUG] Running Sweepers for region (us-west-1):
2021/10/19 12:01:02 [DEBUG] Running Sweeper (aws_servicecatalog_provisioned_product) in region (us-west-1)
2021/10/19 12:01:02 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 12:01:02 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:02 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:03 [DEBUG] Completed Sweeper (aws_servicecatalog_provisioned_product) in region (us-west-1) in 1.198021823s
2021/10/19 12:01:03 Completed Sweepers for region (us-west-1) in 1.19811266s
2021/10/19 12:01:03 Sweeper Tests for region (us-west-1) ran successfully:
	- aws_servicecatalog_provisioned_product
2021/10/19 12:01:03 [DEBUG] Running Sweepers for region (us-west-2):
2021/10/19 12:01:03 [DEBUG] Running Sweeper (aws_servicecatalog_provisioned_product) in region (us-west-2)
2021/10/19 12:01:03 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/19 12:01:03 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:03 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/19 12:01:04 [DEBUG] Completed Sweeper (aws_servicecatalog_provisioned_product) in region (us-west-2) in 1.169912217s
2021/10/19 12:01:04 Completed Sweepers for region (us-west-2) in 1.169991262s
2021/10/19 12:01:04 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_servicecatalog_provisioned_product
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	6.706s

@anGie44 anGie44 added this to the v3.64.0 milestone Oct 19, 2021
@anGie44 anGie44 merged commit 549300f into main Oct 19, 2021
@anGie44 anGie44 deleted the td-servicecat-provisioned-prod-sweep branch October 19, 2021 16:23
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/XS Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sweep/servicecatalog_provisioned_product: failing with ValidationException
3 participants