Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/service/ssm: Include additional information for aws_ssm_parameter value sensitivity #18936

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 19, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #9090
Reference: #18925

Output from acceptance testing: N/A (documentation)

@bflad bflad requested a review from a team as a code owner April 19, 2021 14:36
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. labels Apr 19, 2021
@bflad bflad force-pushed the d-aws_ssm_parameter-0.15-sensitivity branch from c812620 to 923554c Compare April 19, 2021 14:37
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bflad bflad merged commit 474178a into main Apr 19, 2021
@bflad bflad deleted the d-aws_ssm_parameter-0.15-sensitivity branch April 19, 2021 15:35
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 19, 2021
@WhyNotHugo
Copy link

This makes it sound like the new behaviour is here to stay.

AWS uses SSM to PUBLISH information. It's an ideal place to store all kinds of useful variables.

Having to mark my code as "nonsensitive" all over the place is a ridiculous workaround; just treat values an non-sensitive by default, and let anyone handling sensitive values mark it as such.

@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@igreg
Copy link

igreg commented May 4, 2021

I'm with @WhyNotHugo on that one. We have mostly non sensitive information stored in SSM parameters and this decision is very appears to be very shortsighted and adds un-necessary complexity everywhere in our stacks as we have to keep flagging references as non-sensitive. Anyways, better continue the conversation in #9090. At that questionable decision is clearly documented now.

@ghost
Copy link

ghost commented May 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants