Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Support default tags (resources aws_s*) #18804

Merged
merged 4 commits into from
Apr 21, 2021
Merged

provider: Support default tags (resources aws_s*) #18804

merged 4 commits into from
Apr 21, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 12, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #7926

Output from acceptance testing: Will be handled via CI, review, and daily acceptance testing

@bflad bflad requested a review from a team as a code owner April 12, 2021 19:47
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 12, 2021
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. service/databasemigrationservice service/datapipeline Issues and PRs that pertain to the datapipeline service. service/datasync Issues and PRs that pertain to the datasync service. service/dax Issues and PRs that pertain to the dax service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dlm Issues and PRs that pertain to the dlm service. service/ec2 Issues and PRs that pertain to the ec2 service. service/fsx Issues and PRs that pertain to the fsx service. service/rds Issues and PRs that pertain to the rds service. labels Apr 12, 2021
@bflad bflad force-pushed the f-default-tags-s branch from edfbaec to ed9a03f Compare April 12, 2021 20:40
@ghost ghost added service/cloudformation Issues and PRs that pertain to the cloudformation service. service/s3 Issues and PRs that pertain to the s3 service. service/s3control Issues and PRs that pertain to the s3control service. service/sagemaker Issues and PRs that pertain to the sagemaker service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/sfn Issues and PRs that pertain to the sfn service. service/signer Issues and PRs that pertain to the signer service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. service/ssm Issues and PRs that pertain to the ssm service. labels Apr 12, 2021
@bflad bflad removed service/datapipeline Issues and PRs that pertain to the datapipeline service. service/datasync Issues and PRs that pertain to the datasync service. service/dax Issues and PRs that pertain to the dax service. service/directconnect Issues and PRs that pertain to the directconnect service. service/directoryservice service/dlm Issues and PRs that pertain to the dlm service. service/rds Issues and PRs that pertain to the rds service. labels Apr 12, 2021
ewbankkit
ewbankkit approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@bflad bflad merged commit 0578e55 into main Apr 21, 2021
@bflad bflad deleted the f-default-tags-s branch April 21, 2021 17:40
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 21, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/ec2 Issues and PRs that pertain to the ec2 service. service/fsx Issues and PRs that pertain to the fsx service. service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. service/sagemaker Issues and PRs that pertain to the sagemaker service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/sfn Issues and PRs that pertain to the sfn service. service/signer Issues and PRs that pertain to the signer service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. service/ssm Issues and PRs that pertain to the ssm service. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bflad @ewbankkit @anGie44