Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/elasticache_parameter_group: Retry resetting group on pending changes #1821

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

radeksimko
Copy link
Member

This is to address the following test failure:

=== RUN   TestAccAWSElasticacheParameterGroup_removeParam
--- FAIL: TestAccAWSElasticacheParameterGroup_removeParam (8.71s)
    testing.go:434: Step 1 error: Error applying: 1 error(s) occurred:
        
        * aws_elasticache_parameter_group.bar: 1 error(s) occurred:
        
        * aws_elasticache_parameter_group.bar: Error resetting Cache Parameter Group: InvalidCacheParameterGroupState: Cannot reset the parameter group because the parameter appendfsync has pending changes.
            status code: 400, request id: 32179f6e-a73a-11e7-85aa-c99861294b17

I picked an arbitrary value of 15 seconds to start with and we'll see if it needs raising based on test results and failures in the future.

Test results

TF_ACC=1 go test ./aws -v -run=TestAccAWSElasticacheParameterGroup_removeParam -timeout 120m
=== RUN   TestAccAWSElasticacheParameterGroup_removeParam
--- PASS: TestAccAWSElasticacheParameterGroup_removeParam (59.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.977s

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Oct 5, 2017
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@radeksimko radeksimko merged commit bd88007 into master Oct 9, 2017
@radeksimko radeksimko deleted the b-elasticache-param-retry-reset branch October 9, 2017 19:42
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants