Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor updates for servicecatalog #1693

Merged
merged 3 commits into from
Sep 18, 2017
Merged

vendor updates for servicecatalog #1693

merged 3 commits into from
Sep 18, 2017

Conversation

bw-intuit
Copy link
Contributor

First of series of PRs to add AWS service catalog support.

More info: #1663

"checksumSHA1": "TsLkr/jtNxQY3RSJjbCZXEaopG0=",
"path": "github.com/aws/aws-sdk-go/service/servicecatalog",
"revision": "f43761405cff341da21289c4f14800c41ccdc10b",
"revisionTime": "2017-08-25T16:44:15Z"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see the version here, like v1.10.44
Can you please provide the govendor command you used?

Thanks! 😄

@Ninir Ninir added the dependencies Used to indicate dependency changes. label Sep 18, 2017
@bw-intuit
Copy link
Contributor Author

@Ninir I just used:

govendor add github.com/aws/aws-sdk-go/service/servicecatalog

Do you have a recommended cmd?

Thanks

@Ninir
Copy link
Contributor

Ninir commented Sep 18, 2017

Would be better to use govendor fetch github.com/aws/aws-sdk-go/service/servicecatalog@=v1.10.44, so that it fetches the exact version and lock it.

I often use this cheatsheet to better handle vendoring.

Thanks @bw-intuit :)

@bw-intuit
Copy link
Contributor Author

@Ninir gotcha, updated with:

govendor fetch github.com/aws/aws-sdk-go/service/[email protected]

@Ninir
Copy link
Contributor

Ninir commented Sep 18, 2017

@bw-intuit As you specified 1.10.46, we need to first update other vendors to 1.10.46, so that every vendor has the same version. Let me open the PR for that, and I'll merge this one afterwards :)

(or you can use 1.10.44 directly, so that it's easier :) )

@bw-intuit
Copy link
Contributor Author

1.10.44 should be fine, will change. Thanks

Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the efforts @bw-intuit ! 👍 :)

@Ninir Ninir merged commit 46dc379 into hashicorp:master Sep 18, 2017
@bw-intuit
Copy link
Contributor Author

@Ninir thanks, Updated first resource here: #1694

nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this pull request Sep 26, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants