-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor updates for servicecatalog #1693
Conversation
vendor/vendor.json
Outdated
"checksumSHA1": "TsLkr/jtNxQY3RSJjbCZXEaopG0=", | ||
"path": "github.com/aws/aws-sdk-go/service/servicecatalog", | ||
"revision": "f43761405cff341da21289c4f14800c41ccdc10b", | ||
"revisionTime": "2017-08-25T16:44:15Z" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see the version here, like v1.10.44
Can you please provide the govendor command you used?
Thanks! 😄
@Ninir I just used:
Do you have a recommended cmd? Thanks |
Would be better to use I often use this cheatsheet to better handle vendoring. Thanks @bw-intuit :) |
@Ninir gotcha, updated with:
|
@bw-intuit As you specified 1.10.46, we need to first update other vendors to 1.10.46, so that every vendor has the same version. Let me open the PR for that, and I'll merge this one afterwards :) (or you can use 1.10.44 directly, so that it's easier :) ) |
1.10.44 should be fine, will change. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for the efforts @bw-intuit ! 👍 :)
vendor updates for servicecatalog
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
First of series of PRs to add AWS service catalog support.
More info: #1663