Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_appautoscaling_policy: Nest step scaling policy cfg #1620

Merged
merged 1 commit into from
Sep 11, 2017
Merged

r/aws_appautoscaling_policy: Nest step scaling policy cfg #1620

merged 1 commit into from
Sep 11, 2017

Conversation

radeksimko
Copy link
Member

This is a first step towards supporting DynamoDB autoscaling as mentioned in #919 (review)

Test results

TF_ACC=1 go test ./aws -v -run=TestAccAWSAppautoScalingPolicy_ -timeout 120m
=== RUN   TestAccAWSAppautoScalingPolicy_basic
--- PASS: TestAccAWSAppautoScalingPolicy_basic (133.65s)
=== RUN   TestAccAWSAppautoScalingPolicy_nestedSchema
--- PASS: TestAccAWSAppautoScalingPolicy_nestedSchema (132.69s)
=== RUN   TestAccAWSAppautoScalingPolicy_spotFleetRequest
--- PASS: TestAccAWSAppautoScalingPolicy_spotFleetRequest (100.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	367.255s

@radeksimko radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 8, 2017
catsby
catsby approved these changes Sep 11, 2017
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko merged commit e68c88d into master Sep 11, 2017
@radeksimko radeksimko deleted the appautoscaling-policy-deprecation branch September 11, 2017 18:05
@radeksimko radeksimko mentioned this pull request Sep 13, 2017
Merged
nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this pull request Sep 26, 2017
@radeksimko
Merge pull request hashicorp#1620 from terraform-providers/appautosca…
863380f 
…ling-policy-deprecation

r/aws_appautoscaling_policy: Nest step scaling policy cfg
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @catsby