added support for disable_execute_api_endpoint to api gateway rest api

[matt-mercer]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15220

Release note for CHANGELOG:

resource/aws_api_gateway_rest_api: Add `disable_execute_api_endpoint` attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAPIGatewayRestApi_'

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayRestApi -timeout 120m
=== RUN   TestAccAWSAPIGatewayRestApi_basic
=== PAUSE TestAccAWSAPIGatewayRestApi_basic
=== RUN   TestAccAWSAPIGatewayRestApi_create_disable_execute_api_endpoint
=== PAUSE TestAccAWSAPIGatewayRestApi_create_disable_execute_api_endpoint
=== RUN   TestAccAWSAPIGatewayRestApi_tags
=== PAUSE TestAccAWSAPIGatewayRestApi_tags
=== RUN   TestAccAWSAPIGatewayRestApi_disappears
=== PAUSE TestAccAWSAPIGatewayRestApi_disappears
=== RUN   TestAccAWSAPIGatewayRestApi_EndpointConfiguration
=== PAUSE TestAccAWSAPIGatewayRestApi_EndpointConfiguration
=== RUN   TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private
=== PAUSE TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private
=== RUN   TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint
=== PAUSE TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint
=== RUN   TestAccAWSAPIGatewayRestApi_api_key_source
=== PAUSE TestAccAWSAPIGatewayRestApi_api_key_source
=== RUN   TestAccAWSAPIGatewayRestApi_policy
=== PAUSE TestAccAWSAPIGatewayRestApi_policy
=== RUN   TestAccAWSAPIGatewayRestApi_openapi
=== PAUSE TestAccAWSAPIGatewayRestApi_openapi
=== CONT  TestAccAWSAPIGatewayRestApi_basic
=== CONT  TestAccAWSAPIGatewayRestApi_openapi
=== CONT  TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private
=== CONT  TestAccAWSAPIGatewayRestApi_api_key_source
=== CONT  TestAccAWSAPIGatewayRestApi_create_disable_execute_api_endpoint
=== CONT  TestAccAWSAPIGatewayRestApi_EndpointConfiguration
=== CONT  TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint
=== CONT  TestAccAWSAPIGatewayRestApi_policy
=== CONT  TestAccAWSAPIGatewayRestApi_tags
=== CONT  TestAccAWSAPIGatewayRestApi_disappears
2020/11/14 15:21:40 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSAPIGatewayRestApi_disappears (40.13s)
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (62.38s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (66.72s)
--- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (92.18s)
--- PASS: TestAccAWSAPIGatewayRestApi_basic (122.44s)
--- PASS: TestAccAWSAPIGatewayRestApi_tags (153.91s)
--- PASS: TestAccAWSAPIGatewayRestApi_policy (182.86s)
--- PASS: TestAccAWSAPIGatewayRestApi_create_disable_execute_api_endpoint (224.86s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (313.89s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (420.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	420.107s


...

[ewbankkit]

Relates: #15959.
Similar: #16198.

[bflad]

Hi @vurt007 👋 Thank you for submitting this. Overall this was implemented well.

We had two similar contributions come in around the same time (#16198) so our typical process is to evaluate them comparatively. We are going to merge in the other contribution only because it does not modify the existing testing so we can ensure that no regressions are introduced. Regardless, this functionality will be part of version 3.24.0 of the Terraform AWS Provider. 👍

I'll also be looking at your other contribution, #16147, very shortly.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!