Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up imports #15901

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Clean up imports #15901

merged 1 commit into from
Oct 30, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 28, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15903
Release note for CHANGELOG:

NONE

Output from acceptance testing: N/A (handled by daily builds)

@YakDriver YakDriver requested a review from a team October 28, 2020 23:51
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/backup Issues and PRs that pertain to the backup service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecr Issues and PRs that pertain to the ecr service. service/efs Issues and PRs that pertain to the efs service. service/glue Issues and PRs that pertain to the glue service. service/kms Issues and PRs that pertain to the kms service. service/ssm Issues and PRs that pertain to the ssm service. service/waf Issues and PRs that pertain to the waf service. service/wafv2 Issues and PRs that pertain to the wafv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 28, 2020
bflad
bflad approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 (may want to keep the issue open for tracking enabling a linter such as gci/goimports/impi)

@bflad bflad self-assigned this Oct 29, 2020
@YakDriver YakDriver added this to the v3.14.0 milestone Oct 30, 2020
@YakDriver YakDriver merged commit 03fcbfb into master Oct 30, 2020
@YakDriver YakDriver deleted the t-import-clean branch October 30, 2020 18:12
@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/backup Issues and PRs that pertain to the backup service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecr Issues and PRs that pertain to the ecr service. service/efs Issues and PRs that pertain to the efs service. service/glue Issues and PRs that pertain to the glue service. service/kms Issues and PRs that pertain to the kms service. service/ssm Issues and PRs that pertain to the ssm service. service/waf Issues and PRs that pertain to the waf service. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @bflad