-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eventbus to cloudwatch event target #15799
Conversation
…s-to-cloudwatch-event-target
Hi I was just wondering if there is a timeline for this to be merged. I am working on some terraform that requires custom bus support for targets. Thank you for all of your work on this thus far! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀
Output from acceptance testing in AWS Commercial:
--- PASS: TestAccAWSCloudWatchEventTarget_basic (49.40s)
--- PASS: TestAccAWSCloudWatchEventTarget_batch (143.71s)
--- PASS: TestAccAWSCloudWatchEventTarget_disappears (18.72s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecs (38.44s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount (37.95s)
--- PASS: TestAccAWSCloudWatchEventTarget_EventBusName (41.19s)
--- PASS: TestAccAWSCloudWatchEventTarget_full (63.69s)
--- PASS: TestAccAWSCloudWatchEventTarget_GeneratedTargetId (22.62s)
--- PASS: TestAccAWSCloudWatchEventTarget_input_transformer (46.70s)
--- PASS: TestAccAWSCloudWatchEventTarget_inputTransformerJsonString (52.47s)
--- PASS: TestAccAWSCloudWatchEventTarget_kinesis (63.79s)
--- PASS: TestAccAWSCloudWatchEventTarget_sqs (21.42s)
--- PASS: TestAccAWSCloudWatchEventTarget_ssmDocument (24.79s)
Output from acceptance testing in AWS GovCloud (US):
--- PASS: TestAccAWSCloudWatchEventTarget_basic (52.62s)
--- PASS: TestAccAWSCloudWatchEventTarget_batch (89.64s)
--- PASS: TestAccAWSCloudWatchEventTarget_disappears (19.71s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecs (39.90s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount (39.95s)
--- PASS: TestAccAWSCloudWatchEventTarget_EventBusName (44.55s)
--- PASS: TestAccAWSCloudWatchEventTarget_full (66.55s)
--- PASS: TestAccAWSCloudWatchEventTarget_GeneratedTargetId (22.58s)
--- PASS: TestAccAWSCloudWatchEventTarget_input_transformer (48.28s)
--- PASS: TestAccAWSCloudWatchEventTarget_inputTransformerJsonString (39.29s)
--- PASS: TestAccAWSCloudWatchEventTarget_kinesis (66.50s)
--- PASS: TestAccAWSCloudWatchEventTarget_sqs (22.96s)
--- PASS: TestAccAWSCloudWatchEventTarget_ssmDocument (27.00s)
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Completes work from #12887 to add custom event bus support to CloudWatch Events targets.
Includes part of #15727
Relates #12887
Relates #9330
Release note for CHANGELOG:
Output from acceptance testing:
TestAccAWSCloudWatchEventTarget_ecs
andTestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount
are pre-existing failures (#15652)