Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acc-tests: Skip EC2Classic tests if platform is not available #1566

Merged
merged 1 commit into from
Sep 5, 2017
Merged

acc-tests: Skip EC2Classic tests if platform is not available #1566

merged 1 commit into from
Sep 5, 2017

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Sep 1, 2017 •
edited
Loading

Example

=== RUN   TestAccAWSEIP_importEc2Classic
--- SKIP: TestAccAWSEIP_importEc2Classic (2.86s)
	provider_test.go:69: This test can only run in EC2 Classic, platforms available in us-west-2: ["VPC"]
PASS

cc @Ninir

Related to #1551 (comment)

Ideally we'd probably want to make both regions (standard + EC2Classic) configurable instead of hard-coded to us-west-2 & us-east-1, but that's a different task with slightly wider scope.

@radeksimko radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 1, 2017
@radeksimko radeksimko mentioned this pull request Sep 1, 2017
Merged
catsby
catsby approved these changes Sep 5, 2017
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko merged commit 6c64d15 into master Sep 5, 2017
@radeksimko radeksimko deleted the ec2classic-skip branch September 5, 2017 20:20
nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this pull request Sep 26, 2017
@radeksimko
Merge pull request hashicorp#1566 from terraform-providers/ec2classic…
55ddb97 
…-skip

acc-tests: Skip EC2Classic tests if platform is not available
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @catsby