Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added appstream stack and fleet resources #14675

Closed
wants to merge 4 commits into from
Closed

Added appstream stack and fleet resources #14675

wants to merge 4 commits into from

Conversation

wrschneider
Copy link
Contributor

@wrschneider wrschneider commented Aug 17, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #6508

Release note for CHANGELOG:

Adds minimal-viable product support for Appstream stack and fleet.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@wrschneider wrschneider requested a review from a team August 17, 2020 01:07
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. needs-triage Waiting for first response or review from a maintainer. service/appstream Issues and PRs that pertain to the appstream service. documentation Introduces or discusses updates to documentation. labels Aug 17, 2020
@wrschneider
Copy link
Contributor Author

How do I add the "help wanted" label?

@wrschneider wrschneider mentioned this pull request Aug 17, 2020
Closed
8 tasks
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Aug 17, 2020
@wrschneider wrschneider changed the title WIP: added appstream stack resource Added appstream stack and fleet resources Aug 17, 2020
@wrschneider
Copy link
Contributor Author

Has anyone looked at this?

@DrFaust92
Copy link
Collaborator

Hey @wrschneider, first of all thank you for your contribution.
To make reviewing for maintainers easier let's split this to PR per resource.

@wrschneider
Copy link
Contributor Author

Closing this and replacing with two new PRs for each individual resource: stack and fleet go in different PRs

@ghost
Copy link

ghost commented Nov 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 12, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appstream Issues and PRs that pertain to the appstream service. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wrschneider @DrFaust92 @bflad @breathingdust