Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DMS docs for creating a dynamodb endpoint. #1449

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

chrisjharding
Copy link
Contributor

This refers to #1002. The docs are missing an argument for this endpoint. As part of this PR, the service_access_role param was added.
It should probably be deployed soon but it's not critical.

@stack72
Copy link
Contributor

stack72 commented Aug 18, 2017

Nice work on this addition!! Sorry i missed this when bringing it over

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@catsby catsby merged commit 28f1e64 into hashicorp:master Aug 18, 2017
nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this pull request Sep 26, 2017
…int-docs

Updated DMS docs for creating a dynamodb endpoint.
@chrisjharding chrisjharding deleted the update-dms-endpoint-docs branch November 9, 2017 16:18
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants