reverse the order the parameter diff

[wburn-sierra-cedar]

do the compare with aws and current first to remove deleted params
then compare with current and aws to modify params

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates to #5728

Release note for CHANGELOG:

Reversed the order of the diffs for how db parameters are updated.  The current order leaves a state where if parameters are updated and deleted in the same apply, updated params get the current aws value as opposed to the modified value.  This persists in state and the only fix is to delete the parameter group.  Changing the order of the sequence fixes this bug.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[bflad]

Hi @wburn-sierra-cedar 👋 Thank you for this contribution. It appears the earlier #12112 was recently merged and released which seems to cover this functionality, so I'm going to close this. Please reach out if that is not the case here. 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!