Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/elasticsearch_domain: allow empty string for EBS volume type validation #13937

Merged
merged 2 commits into from
Jun 25, 2020
Merged

resource/elasticsearch_domain: allow empty string for EBS volume type validation #13937

merged 2 commits into from
Jun 25, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jun 25, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13867

Release note for CHANGELOG:

resource/elasticsearch_domain: allow empty string for EBS volume type validation

Output from acceptance testing:

--- PASS: TestAccAWSElasticSearchDomain_duplicate (516.34s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key (919.19s)
--- PASS: TestAccAWSElasticSearchDomain_basic (1014.49s)
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (1015.40s)
--- PASS: TestAccAWSElasticSearchDomain_vpc (1178.69s)
--- PASS: TestAccAWSElasticSearchDomain_tags (1181.80s)
--- PASS: TestAccAWSElasticSearchDomain_v23 (1259.18s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key (1290.76s)
--- PASS: TestAccAWSElasticSearchDomain_NodeToNodeEncryption (1489.17s)
--- PASS: TestAccAWSElasticSearchDomain_complex (1544.80s)
--- PASS: TestAccAWSElasticSearchDomain_WithVolumeType_Missing (737.85s)
--- PASS: TestAccAWSElasticSearchDomain_policy (1768.78s)
--- PASS: TestAccAWSElasticSearchDomain_vpc_update (1935.11s)
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (1974.92s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (1991.91s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (2341.19s)
--- PASS: TestAccAWSElasticSearchDomain_RequireHTTPS (2632.20s)
--- PASS: TestAccAWSElasticSearchDomain_update (3211.26s)
--- PASS: TestAccAWSElasticSearchDomain_update_volume_type (2755.73s)
--- PASS: TestAccAWSElasticSearchDomain_withDedicatedMaster (4035.40s)
--- PASS: TestAccAWSElasticSearchDomain_warm (4357.87s)
--- PASS: TestAccAWSElasticSearchDomain_update_version (3728.00s)
--- PASS: TestAccAWSElasticSearchDomain_ClusterConfig_ZoneAwarenessConfig (5896.41s)

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 25, 2020
@anGie44 anGie44 marked this pull request as ready for review June 25, 2020 13:40
@anGie44 anGie44 requested a review from a team June 25, 2020 13:40
@bflad bflad added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. labels Jun 25, 2020
bflad
bflad approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

Output from acceptance testing:

--- PASS: TestAccAWSElasticSearchDomain_duplicate (715.11s)
--- PASS: TestAccAWSElasticSearchDomain_tags (860.14s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key (924.69s)
--- PASS: TestAccAWSElasticSearchDomain_complex (946.43s)
--- PASS: TestAccAWSElasticSearchDomain_v23 (974.79s)
--- PASS: TestAccAWSElasticSearchDomain_vpc (1028.02s)
--- PASS: TestAccAWSElasticSearchDomainPolicy_basic (1116.87s)
--- PASS: TestAccAWSElasticSearchDomain_NodeToNodeEncryption (1222.74s)
--- PASS: TestAccAWSElasticSearchDomain_basic (1242.33s)
--- PASS: TestAccAWSElasticSearchDomain_policy (1246.97s)
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (1250.19s)
--- PASS: TestAccAWSElasticSearchDomain_WithVolumeType_Missing (601.06s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (1705.75s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key (1745.57s)
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (1792.14s)
--- PASS: TestAccAWSElasticSearchDomain_RequireHTTPS (2207.65s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (2288.87s)
--- PASS: TestAccAWSElasticSearchDomain_vpc_update (2690.82s)
--- PASS: TestAccAWSElasticSearchDomain_warm (2905.88s)
--- PASS: TestAccAWSElasticSearchDomain_update (2259.09s)
--- PASS: TestAccAWSElasticSearchDomain_withDedicatedMaster (3172.54s)
--- PASS: TestAccAWSElasticSearchDomain_update_volume_type (3298.01s)
--- PASS: TestAccAWSElasticSearchDomain_update_version (3729.28s)
--- PASS: TestAccAWSElasticSearchDomain_ClusterConfig_ZoneAwarenessConfig (6172.53s)

@anGie44 anGie44 merged commit b7463c5 into master Jun 25, 2020
@anGie44 anGie44 deleted the b-elasticsearch-domain-validation branch June 25, 2020 16:30
@anGie44 anGie44 added this to the v2.68.0 milestone Jun 25, 2020
anGie44 added a commit that referenced this pull request Jun 25, 2020
@anGie44
Update CHANGELOG for #13937
d1ec2ae
c4po added a commit to c4po/terraform-provider-aws that referenced this pull request Jun 25, 2020
@c4po
Merge remote-tracking branch 'origin/master' into issue-1146
4e3fb60 
* origin/master: (59 commits)
  Update CHANGELOG for hashicorp#13935
  resource/aws_batch_compute_environment: Remove resource from Terraform state when not found instead of returning error (hashicorp#13935)
  resource/aws_dynamodb_table: Return error instead of panic on empty CreateTable response (hashicorp#13925)
  Update CHANGELOG for hashicorp#13918
  New Data Source: aws_efs_access_points (hashicorp#13918)
  tests/resource/aws_instance: Ensure sweeper has dependencies on resources that manage EC2 Instances (hashicorp#13917)
  Update CHANGELOG for hashicorp#13937
  Update CHANGELOG for hashicorp#5448
  resource/aws_cloudtrail: Handle single event selector in cloudtrail with non-default read_write_type (hashicorp#5448)
  Update CHANGELOG for hashicorp#13892
  correct retry message to match in error handling
  correct import resource name
  accept empty string in volume_type validation
  Update CHANGELOG for hashicorp#4855
  resource/aws_batch_compute_environment: Support fully optional desired_vcpus and wait for updates
  add retry error handling for SLR
  remove unused WebACL resource name in disappears test
  reference current AWS partition in iam role policy stmt
  remove duplicated disappears test step
  Update CHANGELOG for hashicorp#13926
  ...
@ghost
Copy link

ghost commented Jun 26, 2020

This has been released in version 2.68.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.68.0
Development

Successfully merging this pull request may close these issues.

Validating ebs volume type fails for instances which don't have EBS support
2 participants
@anGie44 @bflad