Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite TypeSet checks with new helpers [Part 4] #13932

Merged
merged 3 commits into from
Jun 26, 2020
Merged

Rewrite TypeSet checks with new helpers [Part 4] #13932

merged 3 commits into from
Jun 26, 2020

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Jun 24, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@appilon appilon requested a review from a team June 24, 2020 22:44
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/applicationautoscaling service/appmesh Issues and PRs that pertain to the appmesh service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/codebuild Issues and PRs that pertain to the codebuild service. service/configservice Issues and PRs that pertain to the configservice service. service/directconnect Issues and PRs that pertain to the directconnect service. service/docdb Issues and PRs that pertain to the docdb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/eks Issues and PRs that pertain to the eks service. service/rds Issues and PRs that pertain to the rds service. service/route53resolver Issues and PRs that pertain to the route53resolver service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 24, 2020
@appilon appilon changed the base branch from master to td-remove-set-checks-3 June 24, 2020 22:44
@appilon appilon force-pushed the td-remove-set-checks-3 branch from 0eed95b to 56f1f99 Compare June 24, 2020 22:57
@appilon appilon force-pushed the td-remove-set-checks-4 branch from d20416d to 8b77052 Compare June 24, 2020 23:01
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Jun 24, 2020
@appilon appilon force-pushed the td-remove-set-checks-3 branch from 56f1f99 to 6deddbd Compare June 25, 2020 19:54
anGie44
anGie44 suggested changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple changes needed but otherwise overall looks good!

Output of acceptance tests:

Changes suggested should fix these up :)
--- FAIL: TestAccAWSDBParameterGroup_withApplyMethod (23.62s)
--- FAIL: TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField (21.97s)
--- FAIL: TestAccAWSDefaultSecurityGroup_classic (6.30s)
--- FAIL: TestAccAWSDefaultSecurityGroup_basic (9.05s)

--- PASS: TestAccAWSDBOptionGroupConfig_OptionGroupDescription (16.19s)
--- PASS: TestAccAWSCognitoUserPoolClient_disappears (16.41s)
--- PASS: TestAccAWSDBOptionGroup_basic (17.08s)
--- PASS: TestAccAWSDBOptionGroup_multipleOptions (17.23s)
--- PASS: TestAccAWSCognitoUserPoolClient_basic (17.95s)
--- PASS: TestAccAWSDBOptionGroup_timeoutBlock (17.91s)
--- PASS: TestAccAWSDBOptionGroup_generatedName (18.02s)
--- PASS: TestAccAWSDBOptionGroup_namePrefix (17.92s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFields (18.00s)
--- SKIP: TestAccAWSDBSecurityGroup_basic (1.20s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_MultipleNonDefault (24.79s)
--- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (24.96s)
--- PASS: TestAccAWSCognitoUserPoolClient_RefreshTokenValidity (27.25s)
--- PASS: TestAccAWSCognitoUserPoolClient_Name (28.09s)
--- PASS: TestAccAWSDBOptionGroup_OracleOptionsUpdate (34.28s)
--- PASS: TestAccAWSCognitoUserPoolClient_analyticsConfig (41.58s)
--- PASS: TestAccAWSDBParameterGroup_namePrefix (23.63s)
--- PASS: TestAccAWSDBParameterGroup_MatchDefault (24.15s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_IAMRole (56.26s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Description (16.32s)
--- PASS: TestAccAWSDBOptionGroup_Tags (62.49s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (20.55s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (22.49s)
--- PASS: TestAccAWSDBParameterGroup_Disappears (49.32s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_basic (32.84s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (30.02s)
--- PASS: TestAccAWSDBParameterGroup_generatedName (54.74s)
--- PASS: TestAccAWSDBParameterGroup_basic (59.24s)
--- PASS: TestAccAWSDBParameterGroup_Only (58.87s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (21.05s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (19.74s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings (83.84s)
--- PASS: TestAccAWSDBOptionGroup_Tags_WithOptions (74.29s)
--- PASS: TestAccAWSDBParameterGroup_limit (76.10s)
--- PASS: TestAccAWSDmsEventSubscription_basic (448.65s)
--- PASS: TestAccAWSDmsEventSubscription_disappears (487.63s)
--- PASS: TestAccAWSDmsEventSubscription_Tags (502.57s)
--- PASS: TestAccAWSDmsEventSubscription_EventCategories (525.49s)
--- PASS: TestAccAWSDmsEventSubscription_Enabled (613.97s)
--- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (663.54s)
--- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount (999.37s)
--- PASS: TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount (1320.16s)
--- PASS: TestAccAwsDxGatewayAssociation_deprecatedSingleAccount (1324.58s)
--- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount (1325.13s)
--- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount (1775.10s)

--- PASS: TestAccAwsDxGatewayAssociationProposal_disappears (120.35s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_VpnGatewayId (133.61s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_basicTransitGateway (198.56s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_AllowedPrefixes (110.61s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_basicVpnGateway (80.31s)

aws/resource_aws_default_security_group_test.go Outdated Show resolved Hide resolved
aws/resource_aws_default_security_group_test.go Outdated Show resolved Hide resolved
aws/resource_aws_db_parameter_group_test.go Outdated Show resolved Hide resolved
aws/resource_aws_cognito_user_pool_client_test.go Outdated Show resolved Hide resolved
Base automatically changed from td-remove-set-checks-3 to master June 25, 2020 21:46
@appilon appilon force-pushed the td-remove-set-checks-4 branch 2 times, most recently from f936d6d to a0b9f69 Compare June 26, 2020 00:34
@appilon appilon force-pushed the td-remove-set-checks-4 branch from 63758ff to 7b35856 Compare June 26, 2020 02:51
@appilon appilon requested a review from anGie44 June 26, 2020 02:52
@appilon
Copy link
Contributor Author

appilon commented Jun 26, 2020

Thanks for those catches @anGie44 ! ready for re-review

anGie44
anGie44 reviewed Jun 26, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Down to just the test in db_parameter_group_test :) https://github.com/terraform-providers/terraform-provider-aws/pull/13932/files#r445807596 (not sure if the link actually directs you to the comment 😅 but I think the name attribute in the last check should be character_set_client)

Output of previously failing tests:

--- FAIL: TestAccAWSDBParameterGroup_withApplyMethod (17.17s)
--- PASS: TestAccAWSDefaultSecurityGroup_classic (14.13s)
--- PASS: TestAccAWSDefaultSecurityGroup_basic (36.36s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField (35.78s)

@appilon
Copy link
Contributor Author

appilon commented Jun 26, 2020

@anGie44 fixed!

@appilon appilon requested a review from anGie44 June 26, 2020 18:30
anGie44
anGie44 approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (28.24s)

@appilon appilon merged commit 44de7ab into master Jun 26, 2020
@appilon appilon deleted the td-remove-set-checks-4 branch June 26, 2020 18:39
@ghost
Copy link

ghost commented Jul 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appmesh Issues and PRs that pertain to the appmesh service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/codebuild Issues and PRs that pertain to the codebuild service. service/configservice Issues and PRs that pertain to the configservice service. service/directconnect Issues and PRs that pertain to the directconnect service. service/docdb Issues and PRs that pertain to the docdb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/eks Issues and PRs that pertain to the eks service. service/rds Issues and PRs that pertain to the rds service. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@appilon @anGie44