Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/service/iam: Implement aws_iam_group and aws_iam_policy sweepers, catch additional aws_iam_role and aws_iam_user #13901

Merged
merged 2 commits into from
Jul 1, 2020
Merged

tests/service/iam: Implement aws_iam_group and aws_iam_policy sweepers, catch additional aws_iam_role and aws_iam_user #13901

merged 2 commits into from
Jul 1, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 23, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12665

Release note for CHANGELOG:

NONE

Output from sweeper in AWS Commercial (unrelated failure due to missing aws_cognito_user_pool_domain sweeper):

2020/06/23 11:01:37 [DEBUG] Running Sweepers for region (us-west-2):
2020/06/23 11:01:37 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-west-2)
...
2020/06/23 11:01:40 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-west-2)
2020/06/23 11:01:41 [INFO] Deleting Batch Compute Environment: tf-acc-test-1848233312429289030
2020/06/23 11:02:50 [ERROR] Failed to delete Batch Compute Environment tf-acc-test-1848233312429289030: unexpected state 'INVALID', wanted target 'DELETED'. last error: %!s(<nil>)
2020/06/23 11:02:50 [DEBUG] Running Sweeper (aws_cloudformation_stack_set_instance) in region (us-west-2)
2020/06/23 11:02:51 [DEBUG] Running Sweeper (aws_cognito_user_pool) in region (us-west-2)
2020/06/23 11:02:51 [INFO] Deleting Cognito User Pool tf-test-9207420729894523345
2020/06/23 11:02:52 [ERROR] Error running Sweeper (aws_cognito_user_pool) in region (us-west-2): Error deleting Cognito User Pool tf-test-9207420729894523345: InvalidParameterException: User pool cannot be deleted. It has a domain configured that should be deleted first.
2020/06/23 11:02:52 [ERROR] Error running Sweeper (aws_cognito_user_pool) in region (us-west-2): Error deleting Cognito User Pool tf-test-9207420729894523345: InvalidParameterException: User pool cannot be deleted. It has a domain configured that should be deleted first.
2020/06/23 11:02:52 [DEBUG] Running Sweeper (aws_config_configuration_aggregator) in region (us-west-2)
2020/06/23 11:02:52 [DEBUG] No config configuration aggregators to sweep
2020/06/23 11:02:52 [DEBUG] Running Sweeper (aws_config_configuration_recorder) in region (us-west-2)
2020/06/23 11:02:53 [DEBUG] No AWS Config Configuration Recorder to sweep
2020/06/23 11:02:53 [DEBUG] Running Sweeper (aws_datasync_location_s3) in region (us-west-2)
2020/06/23 11:02:53 [DEBUG] No DataSync Location S3s to sweep
2020/06/23 11:02:53 [DEBUG] Running Sweeper (aws_dax_cluster) in region (us-west-2)
2020/06/23 11:02:54 [DEBUG] No DAX clusters to sweep
2020/06/23 11:02:54 [DEBUG] Running Sweeper (aws_db_instance) in region (us-west-2)
2020/06/23 11:02:54 [INFO] Deleting DB instance: tf-acc-test-5943499196810915120
2020/06/23 11:02:55 [ERROR] Failed to delete DB instance tf-acc-test-5943499196810915120: InvalidParameterCombination: Cannot delete protected DB Instance, please disable deletion protection and try again.
  status code: 400, request id: bb04a0bb-46f3-4a0e-8253-642e94bc88f6
2020/06/23 11:02:55 [DEBUG] Running Sweeper (aws_db_option_group) in region (us-west-2)
2020/06/23 11:02:55 [DEBUG] Running Sweeper (aws_eks_fargate_profile) in region (us-west-2)
2020/06/23 11:02:56 [DEBUG] Running Sweeper (aws_eks_fargate_node_group) in region (us-west-2)
2020/06/23 11:02:56 [DEBUG] Running Sweeper (aws_eks_cluster) in region (us-west-2)
2020/06/23 11:02:57 [DEBUG] Running Sweeper (aws_elastic_beanstalk_environment) in region (us-west-2)
2020/06/23 11:02:57 [DEBUG] No aws beanstalk environments to sweep
2020/06/23 11:02:57 [DEBUG] Running Sweeper (aws_elastic_beanstalk_application) in region (us-west-2)
2020/06/23 11:02:58 [DEBUG] No aws beanstalk applications to sweep
2020/06/23 11:02:58 [DEBUG] Running Sweeper (aws_glue_crawler) in region (us-west-2)
2020/06/23 11:02:58 [INFO] No Glue Crawlers to sweep
2020/06/23 11:02:58 [DEBUG] Running Sweeper (aws_glue_job) in region (us-west-2)
2020/06/23 11:02:59 [INFO] No Glue Jobs to sweep
2020/06/23 11:02:59 [DEBUG] Running Sweeper (aws_instance) in region (us-west-2)
2020/06/23 11:02:59 [INFO] Skipping terminated EC2 Instance: i-0445c844e1741f39a
2020/06/23 11:02:59 [INFO] Skipping terminated EC2 Instance: i-063decaa71f8cc018
2020/06/23 11:02:59 [DEBUG] Running Sweeper (aws_lambda_function) in region (us-west-2)
2020/06/23 11:03:00 [DEBUG] No aws lambda functions to sweep
2020/06/23 11:03:00 [DEBUG] Running Sweeper (aws_autoscaling_group) in region (us-west-2)
2020/06/23 11:03:01 [DEBUG] No aws autoscaling groups to sweep
2020/06/23 11:03:01 [DEBUG] Running Sweeper (aws_launch_configuration) in region (us-west-2)
2020/06/23 11:03:01 [DEBUG] No aws launch configurations to sweep
2020/06/23 11:03:01 [DEBUG] Running Sweeper (aws_redshift_cluster) in region (us-west-2)
2020/06/23 11:03:02 [DEBUG] No Redshift clusters to sweep
2020/06/23 11:03:02 [DEBUG] Running Sweeper (aws_spot_fleet_request) in region (us-west-2)
2020/06/23 11:03:02 [INFO] Deleting Spot Fleet Request: sfr-022f966d-cc06-41a7-bd1e-653b040ef537
...
2020/06/23 11:04:45 [INFO] Deleting Spot Fleet Request: sfr-fca43b3b-4a31-4aa8-b3b3-60027d0528fe
2020/06/23 11:04:46 [DEBUG] Active instance count is 0 for Spot Fleet Request (sfr-fca43b3b-4a31-4aa8-b3b3-60027d0528fe), removing
2020/06/23 11:04:46 [DEBUG] Running Sweeper (aws_iam_role) in region (us-west-2)
2020/06/23 11:04:46 [DEBUG] No IAM Roles to sweep
2020/06/23 11:04:46 [DEBUG] Running Sweeper (aws_iam_user) in region (us-west-2)
2020/06/23 11:04:46 [DEBUG] No IAM Users to sweep
2020/06/23 11:04:46 [DEBUG] Running Sweeper (aws_iam_group) in region (us-west-2)
2020/06/23 11:04:47 [INFO] Deleting IAM Group: Jen20PackageManagers
2020/06/23 11:04:47 [INFO] Deleting IAM Group: packer_devtest
2020/06/23 11:04:48 [INFO] Deleting IAM Group: test_group_4300747935912896569
2020/06/23 11:04:49 [INFO] Deleting IAM Group: test_group_4551761326358113148
2020/06/23 11:04:49 [INFO] Deleting IAM Group: test_group_6384270922873243256
2020/06/23 11:04:50 [INFO] Deleting IAM Group: test_group_6453479404941257412
2020/06/23 11:04:51 [INFO] Deleting IAM Group: tf-acc-group-gpa-basic-2k8r8kyi
2020/06/23 11:04:51 [INFO] Deleting IAM Group: tf-acc-group-gpa-basic-fw30x9bh
2020/06/23 11:04:52 [INFO] Deleting IAM Group: tf-acc-group-gpa-basic-plcrmesc
2020/06/23 11:04:53 [INFO] Deleting IAM Group: tf-acc-group-gpa-basic-r2b8yh4q
2020/06/23 11:04:54 [DEBUG] Running Sweeper (aws_iam_policy) in region (us-west-2)
2020/06/23 11:04:54 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-83dbef66-c594-40a3-b9dc-8fbfac2dfb27
2020/06/23 11:04:54 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-83dbef66-c594-40a3-b9dc-8fbfac2dfb27) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 94d727e5-329a-4bee-a307-7d43fbff9054
2020/06/23 11:04:54 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-8f380aca-93a0-4251-9cf5-3b9d0203a8aa
2020/06/23 11:04:54 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-8f380aca-93a0-4251-9cf5-3b9d0203a8aa) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 47a3204f-40d3-4488-8674-b288f82defbe
2020/06/23 11:04:54 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/tf-acc-policy-gpa-basic-r2b8yh4q
2020/06/23 11:04:55 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-2170c6e1-f042-4043-8ee4-1f34fe7b3e19
2020/06/23 11:04:55 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-2170c6e1-f042-4043-8ee4-1f34fe7b3e19) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: a65efdf0-76a6-4595-b050-8f0963261ed4
2020/06/23 11:04:55 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/DynamoDBAutoscalePolicy
2020/06/23 11:04:55 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/DynamoDBAutoscalePolicy) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 771f641f-541a-4b8d-83c3-63850d530cec
2020/06/23 11:04:55 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/tf-acc-policy-gpa-basic-2k8r8kyi
2020/06/23 11:04:56 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/tf-acc-policy-gpa-basic-plcrmesc
2020/06/23 11:04:56 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-1c644075-d585-472f-aa94-6ac8e22bd9c4
2020/06/23 11:04:56 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-1c644075-d585-472f-aa94-6ac8e22bd9c4) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 718655d9-7595-445d-b82c-80fe05b4bb30
2020/06/23 11:04:56 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/tf-acc-policy-gpa-basic-fw30x9bh
2020/06/23 11:04:57 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1545427989858
2020/06/23 11:04:57 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1545427989858) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: b0a93b33-db39-40ed-8630-c826b4444085
2020/06/23 11:04:57 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-17bf07fa-21f9-466a-9ff9-be55c306b8a1
2020/06/23 11:04:57 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-17bf07fa-21f9-466a-9ff9-be55c306b8a1) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 7fdbc3e4-3e78-4ef2-aa95-aea81e4f570d
2020/06/23 11:04:57 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-6530ebd9-562e-47db-a2fe-4a3006b3b1b7
2020/06/23 11:04:58 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-6530ebd9-562e-47db-a2fe-4a3006b3b1b7) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 32f78915-5cd1-47ff-9fee-b4497abf2e26
2020/06/23 11:04:58 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1576802182101
2020/06/23 11:04:58 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1576802182101) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: e0c3b0e8-05f5-4d71-8086-d62f854d46f7
2020/06/23 11:04:58 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/2d2ak2kxpm
2020/06/23 11:04:58 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/svq0lcogg9
2020/06/23 11:04:59 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-980247647930366397
2020/06/23 11:04:59 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/1ta1orz19f
2020/06/23 11:05:00 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/xslp2w7e04
2020/06/23 11:05:00 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/uf6zn1c77l
2020/06/23 11:05:01 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/badmr3flr2
2020/06/23 11:05:01 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/vqmfi82auh
2020/06/23 11:05:02 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/it62rkeun8
2020/06/23 11:05:02 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/psddw9bijv
2020/06/23 11:05:03 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/drrqw7qhi0
2020/06/23 11:05:03 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/sb931cqri1
2020/06/23 11:05:04 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/wlk4oq4n81
2020/06/23 11:05:04 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/qm4t70afzb
2020/06/23 11:05:04 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/fqb81qengp
2020/06/23 11:05:05 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/esyrg76aph
2020/06/23 11:05:05 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/qpdat9h7lx
2020/06/23 11:05:06 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/my39ac618b
2020/06/23 11:05:06 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/fcnae1dvky
2020/06/23 11:05:06 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/zd1bx1lo1y
2020/06/23 11:05:07 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/h3iyn3k8n4
2020/06/23 11:05:07 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/q3oczat8ci
2020/06/23 11:05:08 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/mnk842a97s
2020/06/23 11:05:08 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/v6pb27wpxq
2020/06/23 11:05:08 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/kbedalpe2x
2020/06/23 11:05:09 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/qgli19bkhy
2020/06/23 11:05:09 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1583946813474
2020/06/23 11:05:10 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1583946813474) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 60fee89e-4bec-4c29-bdc1-48555bad8e4f
2020/06/23 11:05:10 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/im0aiq3vja
2020/06/23 11:05:10 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/m0o0ouji6s
2020/06/23 11:05:10 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/gs6oje6v2v
2020/06/23 11:05:11 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/w7nhq8oa30
2020/06/23 11:05:11 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/qvw24io6o3
2020/06/23 11:05:11 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/qg0g8gq04k
2020/06/23 11:05:12 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/mv2jew1dtz
2020/06/23 11:05:12 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/ndzkh29tu2
2020/06/23 11:05:12 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/nejwxos2rl
2020/06/23 11:05:13 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/tkzw1gi2nn
2020/06/23 11:05:13 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/dzjdutb6sn
2020/06/23 11:05:14 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/n0qgfbkmxb
2020/06/23 11:05:14 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/y19ou0duux
2020/06/23 11:05:14 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/circleci-release-to-terraform-staging-bucket
2020/06/23 11:05:15 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/circleci-release-to-terraform-staging-bucket) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: a4ee263f-80c3-4fc6-8008-1aaf8d996de7
2020/06/23 11:05:15 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/imem09sygd
2020/06/23 11:05:15 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/kyx4vew2gy
2020/06/23 11:05:15 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/k12qwb8qza
2020/06/23 11:05:16 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-1324429311463140858
2020/06/23 11:05:16 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-2685267303998413546
2020/06/23 11:05:17 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/0hesp26ppd
2020/06/23 11:05:17 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/ab98qf2slf
2020/06/23 11:05:18 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-8485035891327664742
2020/06/23 11:05:18 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-1177423856893953126
2020/06/23 11:05:18 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-1258709812998549268
2020/06/23 11:05:19 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-2525313560886109212
2020/06/23 11:05:19 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/iam_emr_default_policy_4994407545241189113
2020/06/23 11:05:20 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-4899620462186745471
2020/06/23 11:05:20 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-8832128821340190199
2020/06/23 11:05:20 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/6zmo6jpu6y
2020/06/23 11:05:21 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-2460821864535779827
2020/06/23 11:05:21 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test_policy_3o14r
2020/06/23 11:05:21 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-2732735875133651964
2020/06/23 11:05:22 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/bpz08yavyn
2020/06/23 11:05:22 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/jarncii0u3
2020/06/23 11:05:23 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-83151575579866002
2020/06/23 11:05:23 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-7757884585288753487
2020/06/23 11:05:24 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-7473641939956146640
2020/06/23 11:05:24 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/mqce6mepv4
2020/06/23 11:05:24 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-7647389029266414934
2020/06/23 11:05:25 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/nt3ad6vzpf
2020/06/23 11:05:25 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-8380959359348172962
2020/06/23 11:05:26 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test_policy_99t11
2020/06/23 11:05:26 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-6476517509636948928
2020/06/23 11:05:26 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-3803991435167010202
2020/06/23 11:05:27 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-3488440981064797860
2020/06/23 11:05:27 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/48fj7edpoa
2020/06/23 11:05:28 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-8885714602706546381
2020/06/23 11:05:28 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-5746312202030533522
2020/06/23 11:05:28 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-1336331454645551108
2020/06/23 11:05:29 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-2377880229490114112
2020/06/23 11:05:29 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-5299087410043412056
2020/06/23 11:05:29 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/tf-acc-s3-import-test-6820402778073111835-policy
2020/06/23 11:05:30 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-8324344107021273733
2020/06/23 11:05:30 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/eaist3rzkb
2020/06/23 11:05:31 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-7777423058503145218
2020/06/23 11:05:31 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-5516836139511686956
2020/06/23 11:05:31 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-128289926542221709
2020/06/23 11:05:32 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/iam_emr_profile_policy_6473488463221601170
2020/06/23 11:05:32 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-4257878149682965462
2020/06/23 11:05:33 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/gyr7vlof1i
2020/06/23 11:05:33 Sweeper Tests ran successfully:
  - aws_batch_compute_environment
  - aws_db_option_group
  - aws_redshift_cluster
  - aws_datasync_location_s3
  - aws_db_instance
  - aws_eks_fargate_node_group
  - aws_iam_policy
  - aws_config_configuration_aggregator
  - aws_elastic_beanstalk_environment
  - aws_launch_configuration
  - aws_batch_job_queue
  - aws_eks_fargate_profile
  - aws_eks_cluster
  - aws_elastic_beanstalk_application
  - aws_glue_crawler
  - aws_glue_job
  - aws_cloudformation_stack_set_instance
  - aws_lambda_function
  - aws_autoscaling_group
  - aws_iam_user
  - aws_instance
  - aws_config_configuration_recorder
  - aws_dax_cluster
  - aws_iam_role
  - aws_spot_fleet_request
  - aws_iam_group
2020/06/23 11:05:33 Sweeper Tests ran unsuccessfully:
  - aws_cognito_user_pool: Error deleting Cognito User Pool tf-test-9207420729894523345: InvalidParameterException: User pool cannot be deleted. It has a domain configured that should be deleted first.
2020/06/23 11:05:33 [DEBUG] Running Sweepers for region (us-east-1):
2020/06/23 11:05:33 [DEBUG] Running Sweeper (aws_lambda_function) in region (us-east-1)
...
2020/06/23 11:05:36 [DEBUG] No aws lambda functions to sweep
2020/06/23 11:05:36 [DEBUG] Running Sweeper (aws_spot_fleet_request) in region (us-east-1)
2020/06/23 11:05:36 [DEBUG] No Spot Fleet Requests to sweep
2020/06/23 11:05:36 [DEBUG] Running Sweeper (aws_eks_fargate_profile) in region (us-east-1)
2020/06/23 11:05:36 [DEBUG] Running Sweeper (aws_iam_user) in region (us-east-1)
2020/06/23 11:05:36 [DEBUG] No IAM Users to sweep
2020/06/23 11:05:36 [DEBUG] Running Sweeper (aws_iam_group) in region (us-east-1)
2020/06/23 11:05:36 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-east-1)
2020/06/23 11:05:37 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-east-1)
2020/06/23 11:05:37 [DEBUG] Running Sweeper (aws_elastic_beanstalk_environment) in region (us-east-1)
2020/06/23 11:05:37 [DEBUG] No aws beanstalk environments to sweep
2020/06/23 11:05:37 [DEBUG] Running Sweeper (aws_cognito_user_pool) in region (us-east-1)
2020/06/23 11:05:37 [DEBUG] No Cognito User Pools to sweep
2020/06/23 11:05:37 [DEBUG] Running Sweeper (aws_config_configuration_aggregator) in region (us-east-1)
2020/06/23 11:05:37 [DEBUG] No config configuration aggregators to sweep
2020/06/23 11:05:37 [DEBUG] Running Sweeper (aws_datasync_location_s3) in region (us-east-1)
2020/06/23 11:05:38 [DEBUG] No DataSync Location S3s to sweep
2020/06/23 11:05:38 [DEBUG] Running Sweeper (aws_config_configuration_recorder) in region (us-east-1)
2020/06/23 11:05:38 [DEBUG] No AWS Config Configuration Recorder to sweep
2020/06/23 11:05:38 [DEBUG] Running Sweeper (aws_db_option_group) in region (us-east-1)
2020/06/23 11:05:38 [DEBUG] Running Sweeper (aws_cloudformation_stack_set_instance) in region (us-east-1)
2020/06/23 11:05:38 [DEBUG] Running Sweeper (aws_dax_cluster) in region (us-east-1)
2020/06/23 11:05:39 [DEBUG] No DAX clusters to sweep
2020/06/23 11:05:39 [DEBUG] Running Sweeper (aws_db_instance) in region (us-east-1)
2020/06/23 11:05:39 [DEBUG] Running Sweeper (aws_eks_fargate_node_group) in region (us-east-1)
2020/06/23 11:05:39 [DEBUG] Running Sweeper (aws_eks_cluster) in region (us-east-1)
2020/06/23 11:05:39 [DEBUG] Running Sweeper (aws_elastic_beanstalk_application) in region (us-east-1)
2020/06/23 11:05:39 [DEBUG] No aws beanstalk applications to sweep
2020/06/23 11:05:39 [DEBUG] Running Sweeper (aws_glue_crawler) in region (us-east-1)
2020/06/23 11:05:39 [INFO] No Glue Crawlers to sweep
2020/06/23 11:05:39 [DEBUG] Running Sweeper (aws_glue_job) in region (us-east-1)
2020/06/23 11:05:40 [INFO] No Glue Jobs to sweep
2020/06/23 11:05:40 [DEBUG] Running Sweeper (aws_instance) in region (us-east-1)
2020/06/23 11:05:40 [INFO] Skipping terminated EC2 Instance: i-05f499321b2e2e955
2020/06/23 11:05:40 [DEBUG] Running Sweeper (aws_autoscaling_group) in region (us-east-1)
2020/06/23 11:05:40 [DEBUG] No aws autoscaling groups to sweep
2020/06/23 11:05:40 [DEBUG] Running Sweeper (aws_launch_configuration) in region (us-east-1)
2020/06/23 11:05:40 [DEBUG] No aws launch configurations to sweep
2020/06/23 11:05:40 [DEBUG] Running Sweeper (aws_redshift_cluster) in region (us-east-1)
2020/06/23 11:05:41 [DEBUG] No Redshift clusters to sweep
2020/06/23 11:05:41 [DEBUG] Running Sweeper (aws_iam_role) in region (us-east-1)
2020/06/23 11:05:41 [DEBUG] No IAM Roles to sweep
2020/06/23 11:05:41 [DEBUG] Running Sweeper (aws_iam_policy) in region (us-east-1)
2020/06/23 11:05:41 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-83dbef66-c594-40a3-b9dc-8fbfac2dfb27
2020/06/23 11:05:41 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-83dbef66-c594-40a3-b9dc-8fbfac2dfb27) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: afb1708b-6526-46b4-b4c8-1468d359140e
2020/06/23 11:05:41 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-8f380aca-93a0-4251-9cf5-3b9d0203a8aa
2020/06/23 11:05:41 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-8f380aca-93a0-4251-9cf5-3b9d0203a8aa) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: e6f449b5-c95e-4dd1-bf1c-d708057f1f2e
2020/06/23 11:05:41 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-2170c6e1-f042-4043-8ee4-1f34fe7b3e19
2020/06/23 11:05:42 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-2170c6e1-f042-4043-8ee4-1f34fe7b3e19) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 9d5971a2-2ff8-45b8-b0a3-870b8f60a0a5
2020/06/23 11:05:42 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/DynamoDBAutoscalePolicy
2020/06/23 11:05:42 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/DynamoDBAutoscalePolicy) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: c272be72-e6a0-4f09-9db1-fcc7110d22f0
2020/06/23 11:05:42 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-1c644075-d585-472f-aa94-6ac8e22bd9c4
2020/06/23 11:05:42 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-1c644075-d585-472f-aa94-6ac8e22bd9c4) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: ad686230-6de5-4b0a-8936-568094bc0753
2020/06/23 11:05:42 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1545427989858
2020/06/23 11:05:43 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1545427989858) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: d9e5af6e-a4c1-4a7f-9406-4bb27486af9a
2020/06/23 11:05:43 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-17bf07fa-21f9-466a-9ff9-be55c306b8a1
2020/06/23 11:05:43 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-17bf07fa-21f9-466a-9ff9-be55c306b8a1) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: d87483be-0328-4726-a13d-58fb9e01375f
2020/06/23 11:05:43 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-6530ebd9-562e-47db-a2fe-4a3006b3b1b7
2020/06/23 11:05:43 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-6530ebd9-562e-47db-a2fe-4a3006b3b1b7) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 3b7aa0cd-9fbd-488b-806a-13ecf039ee98
2020/06/23 11:05:43 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1576802182101
2020/06/23 11:05:43 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1576802182101) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: b8f79421-5898-4f79-923f-086fef4d0699
2020/06/23 11:05:43 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1583946813474
2020/06/23 11:05:44 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1583946813474) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: a51218ed-567f-4304-b6d4-e441856bf950
2020/06/23 11:05:44 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/circleci-release-to-terraform-staging-bucket
2020/06/23 11:05:44 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/circleci-release-to-terraform-staging-bucket) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 89b6937b-d725-4558-8606-c1ffaf9b5bac
2020/06/23 11:05:44 Sweeper Tests ran successfully:
  - aws_instance
  - aws_eks_fargate_node_group
  - aws_glue_job
  - aws_datasync_location_s3
  - aws_config_configuration_recorder
  - aws_dax_cluster
  - aws_batch_job_queue
  - aws_batch_compute_environment
  - aws_db_instance
  - aws_eks_cluster
  - aws_autoscaling_group
  - aws_launch_configuration
  - aws_cloudformation_stack_set_instance
  - aws_elastic_beanstalk_application
  - aws_iam_group
  - aws_cognito_user_pool
  - aws_db_option_group
  - aws_iam_policy
  - aws_eks_fargate_profile
  - aws_iam_user
  - aws_elastic_beanstalk_environment
  - aws_config_configuration_aggregator
  - aws_iam_role
  - aws_spot_fleet_request
  - aws_glue_crawler
  - aws_redshift_cluster
  - aws_lambda_function
FAIL  github.com/terraform-providers/terraform-provider-aws/aws 247.889s
FAIL

Output from sweeper in AWS GovCloud (US):

2020/06/23 10:03:54 [DEBUG] Running Sweepers for region (us-gov-west-1):
2020/06/23 10:03:54 [DEBUG] Running Sweeper (aws_db_instance) in region (us-gov-west-1)
...
2020/06/23 10:03:58 [DEBUG] Running Sweeper (aws_eks_fargate_profile) in region (us-gov-west-1)
2020/06/23 10:03:58 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-gov-west-1)
2020/06/23 10:04:01 [DEBUG] Running Sweeper (aws_cloudformation_stack_set_instance) in region (us-gov-west-1)
2020/06/23 10:04:02 [DEBUG] Running Sweeper (aws_cognito_user_pool) in region (us-gov-west-1)
2020/06/23 10:04:02 [DEBUG] No Cognito User Pools to sweep
2020/06/23 10:04:02 [DEBUG] Running Sweeper (aws_config_configuration_aggregator) in region (us-gov-west-1)
2020/06/23 10:04:04 [DEBUG] No config configuration aggregators to sweep
2020/06/23 10:04:04 [DEBUG] Running Sweeper (aws_config_configuration_recorder) in region (us-gov-west-1)
2020/06/23 10:04:04 [DEBUG] No AWS Config Configuration Recorder to sweep
2020/06/23 10:04:04 [DEBUG] Running Sweeper (aws_datasync_location_s3) in region (us-gov-west-1)
2020/06/23 10:04:05 [DEBUG] No DataSync Location S3s to sweep
2020/06/23 10:04:05 [DEBUG] Running Sweeper (aws_dax_cluster) in region (us-gov-west-1)
2020/06/23 10:04:06 [WARN] Skipping DAX Cluster sweep for us-gov-west-1: InvalidParameterValueException: Access Denied to API Version: DAX_V3
2020/06/23 10:04:06 [DEBUG] Running Sweeper (aws_db_option_group) in region (us-gov-west-1)
2020/06/23 10:04:06 [DEBUG] Running Sweeper (aws_eks_fargate_node_group) in region (us-gov-west-1)
2020/06/23 10:04:07 [DEBUG] Running Sweeper (aws_eks_cluster) in region (us-gov-west-1)
2020/06/23 10:04:08 [DEBUG] Running Sweeper (aws_elastic_beanstalk_environment) in region (us-gov-west-1)
2020/06/23 10:04:09 [DEBUG] No aws beanstalk environments to sweep
2020/06/23 10:04:09 [DEBUG] Running Sweeper (aws_elastic_beanstalk_application) in region (us-gov-west-1)
2020/06/23 10:04:09 [DEBUG] No aws beanstalk applications to sweep
2020/06/23 10:04:09 [DEBUG] Running Sweeper (aws_glue_crawler) in region (us-gov-west-1)
2020/06/23 10:04:10 [INFO] No Glue Crawlers to sweep
2020/06/23 10:04:10 [DEBUG] Running Sweeper (aws_glue_job) in region (us-gov-west-1)
2020/06/23 10:04:11 [INFO] No Glue Jobs to sweep
2020/06/23 10:04:11 [DEBUG] Running Sweeper (aws_instance) in region (us-gov-west-1)
2020/06/23 10:04:11 [DEBUG] No EC2 Instances to sweep
2020/06/23 10:04:11 [DEBUG] Running Sweeper (aws_lambda_function) in region (us-gov-west-1)
2020/06/23 10:04:12 [DEBUG] No aws lambda functions to sweep
2020/06/23 10:04:12 [DEBUG] Running Sweeper (aws_autoscaling_group) in region (us-gov-west-1)
2020/06/23 10:04:12 [DEBUG] No aws autoscaling groups to sweep
2020/06/23 10:04:12 [DEBUG] Running Sweeper (aws_launch_configuration) in region (us-gov-west-1)
2020/06/23 10:04:13 [DEBUG] No aws launch configurations to sweep
2020/06/23 10:04:13 [DEBUG] Running Sweeper (aws_redshift_cluster) in region (us-gov-west-1)
2020/06/23 10:04:13 [DEBUG] No Redshift clusters to sweep
2020/06/23 10:04:13 [DEBUG] Running Sweeper (aws_spot_fleet_request) in region (us-gov-west-1)
2020/06/23 10:04:14 [INFO] Deleting Spot Fleet Request: sfr-0255889a-8f96-4d77-93ad-78e1d6af8145
2020/06/23 10:04:15 [DEBUG] Active instance count is 0 for Spot Fleet Request (sfr-0255889a-8f96-4d77-93ad-78e1d6af8145), removing
...
2020/06/23 10:04:32 [INFO] Deleting Spot Fleet Request: sfr-ee60a90f-3a35-41e3-b836-61d93cac99b4
2020/06/23 10:04:33 [DEBUG] Active instance count is 0 for Spot Fleet Request (sfr-ee60a90f-3a35-41e3-b836-61d93cac99b4), removing
2020/06/23 10:04:33 [DEBUG] Running Sweeper (aws_iam_role) in region (us-gov-west-1)
2020/06/23 10:04:37 [DEBUG] No IAM Roles to sweep
2020/06/23 10:04:37 [DEBUG] Running Sweeper (aws_iam_user) in region (us-gov-west-1)
2020/06/23 10:04:37 [DEBUG] Deleting IAM User: tf-acc-ugm-basic-user1-0ciyfkyz
2020/06/23 10:04:41 [DEBUG] Deleting IAM User: tf-acc-ugm-basic-user1-3672jelb
2020/06/23 10:04:45 [DEBUG] Deleting IAM User: tf-acc-ugm-basic-user1-3f8czq96
...
2020/06/23 10:09:13 [DEBUG] Deleting IAM User: tf-acc-ugm-basic-user2-w316unor
2020/06/23 10:09:17 [DEBUG] Deleting IAM User: tf-acc-ugm-basic-user2-x803ixmg
2020/06/23 10:09:21 [DEBUG] Deleting IAM User: tf-acc-ugm-basic-user2-ziflg2mg
2020/06/23 10:09:25 [DEBUG] Running Sweeper (aws_iam_group) in region (us-gov-west-1)
2020/06/23 10:09:25 [DEBUG] Running Sweeper (aws_iam_policy) in region (us-gov-west-1)
2020/06/23 10:09:25 [INFO] Deleting IAM Policy: arn:aws-us-gov:iam::--OMITTED--:policy/iam_emr_default_policy_7114142747117564308
2020/06/23 10:09:26 [INFO] Deleting IAM Policy: arn:aws-us-gov:iam::--OMITTED--:policy/iam_emr_profile_policy_6731769006029286756
2020/06/23 10:09:27 [INFO] Deleting IAM Policy: arn:aws-us-gov:iam::--OMITTED--:policy/iam_emr_default_policy_4202203677099729083
...
2020/06/23 10:16:46 [INFO] Deleting IAM Policy: arn:aws-us-gov:iam::--OMITTED--:policy/iam_emr_profile_policy_6109457006451323744
2020/06/23 10:16:46 [INFO] Deleting IAM Policy: arn:aws-us-gov:iam::--OMITTED--:policy/iam_emr_profile_policy_181902630721762349
2020/06/23 10:16:47 [INFO] Deleting IAM Policy: arn:aws-us-gov:iam::--OMITTED--:policy/iam_emr_default_policy_84369998123182835
2020/06/23 10:16:49 Sweeper Tests ran successfully:
  - aws_lambda_function
  - aws_redshift_cluster
  - aws_iam_role
  - aws_iam_policy
  - aws_cloudformation_stack_set_instance
  - aws_config_configuration_recorder
  - aws_datasync_location_s3
  - aws_dax_cluster
  - aws_spot_fleet_request
  - aws_db_instance
  - aws_eks_fargate_node_group
  - aws_elastic_beanstalk_application
  - aws_batch_job_queue
  - aws_glue_crawler
  - aws_autoscaling_group
  - aws_iam_user
  - aws_iam_group
  - aws_db_option_group
  - aws_eks_cluster
  - aws_instance
  - aws_launch_configuration
  - aws_eks_fargate_profile
  - aws_batch_compute_environment
  - aws_cognito_user_pool
  - aws_config_configuration_aggregator
  - aws_elastic_beanstalk_environment
  - aws_glue_job
ok    github.com/terraform-providers/terraform-provider-aws/aws 775.037s

@bflad
tests/service/iam: Implement aws_iam_group and aws_iam_policy sweeper…
fbd3070 
…s, catch additional aws_iam_role and aws_iam_user

Reference: #12665

Output from sweeper in AWS Commercial (unrelated failure due to missing `aws_cognito_user_pool_domain` sweeper):

```
2020/06/23 11:01:37 [DEBUG] Running Sweepers for region (us-west-2):
2020/06/23 11:01:37 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-west-2)
...
2020/06/23 11:01:40 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-west-2)
2020/06/23 11:01:41 [INFO] Deleting Batch Compute Environment: tf-acc-test-1848233312429289030
2020/06/23 11:02:50 [ERROR] Failed to delete Batch Compute Environment tf-acc-test-1848233312429289030: unexpected state 'INVALID', wanted target 'DELETED'. last error: %!s(<nil>)
2020/06/23 11:02:50 [DEBUG] Running Sweeper (aws_cloudformation_stack_set_instance) in region (us-west-2)
2020/06/23 11:02:51 [DEBUG] Running Sweeper (aws_cognito_user_pool) in region (us-west-2)
2020/06/23 11:02:51 [INFO] Deleting Cognito User Pool tf-test-9207420729894523345
2020/06/23 11:02:52 [ERROR] Error running Sweeper (aws_cognito_user_pool) in region (us-west-2): Error deleting Cognito User Pool tf-test-9207420729894523345: InvalidParameterException: User pool cannot be deleted. It has a domain configured that should be deleted first.
2020/06/23 11:02:52 [ERROR] Error running Sweeper (aws_cognito_user_pool) in region (us-west-2): Error deleting Cognito User Pool tf-test-9207420729894523345: InvalidParameterException: User pool cannot be deleted. It has a domain configured that should be deleted first.
2020/06/23 11:02:52 [DEBUG] Running Sweeper (aws_config_configuration_aggregator) in region (us-west-2)
2020/06/23 11:02:52 [DEBUG] No config configuration aggregators to sweep
2020/06/23 11:02:52 [DEBUG] Running Sweeper (aws_config_configuration_recorder) in region (us-west-2)
2020/06/23 11:02:53 [DEBUG] No AWS Config Configuration Recorder to sweep
2020/06/23 11:02:53 [DEBUG] Running Sweeper (aws_datasync_location_s3) in region (us-west-2)
2020/06/23 11:02:53 [DEBUG] No DataSync Location S3s to sweep
2020/06/23 11:02:53 [DEBUG] Running Sweeper (aws_dax_cluster) in region (us-west-2)
2020/06/23 11:02:54 [DEBUG] No DAX clusters to sweep
2020/06/23 11:02:54 [DEBUG] Running Sweeper (aws_db_instance) in region (us-west-2)
2020/06/23 11:02:54 [INFO] Deleting DB instance: tf-acc-test-5943499196810915120
2020/06/23 11:02:55 [ERROR] Failed to delete DB instance tf-acc-test-5943499196810915120: InvalidParameterCombination: Cannot delete protected DB Instance, please disable deletion protection and try again.
  status code: 400, request id: bb04a0bb-46f3-4a0e-8253-642e94bc88f6
2020/06/23 11:02:55 [DEBUG] Running Sweeper (aws_db_option_group) in region (us-west-2)
2020/06/23 11:02:55 [DEBUG] Running Sweeper (aws_eks_fargate_profile) in region (us-west-2)
2020/06/23 11:02:56 [DEBUG] Running Sweeper (aws_eks_fargate_node_group) in region (us-west-2)
2020/06/23 11:02:56 [DEBUG] Running Sweeper (aws_eks_cluster) in region (us-west-2)
2020/06/23 11:02:57 [DEBUG] Running Sweeper (aws_elastic_beanstalk_environment) in region (us-west-2)
2020/06/23 11:02:57 [DEBUG] No aws beanstalk environments to sweep
2020/06/23 11:02:57 [DEBUG] Running Sweeper (aws_elastic_beanstalk_application) in region (us-west-2)
2020/06/23 11:02:58 [DEBUG] No aws beanstalk applications to sweep
2020/06/23 11:02:58 [DEBUG] Running Sweeper (aws_glue_crawler) in region (us-west-2)
2020/06/23 11:02:58 [INFO] No Glue Crawlers to sweep
2020/06/23 11:02:58 [DEBUG] Running Sweeper (aws_glue_job) in region (us-west-2)
2020/06/23 11:02:59 [INFO] No Glue Jobs to sweep
2020/06/23 11:02:59 [DEBUG] Running Sweeper (aws_instance) in region (us-west-2)
2020/06/23 11:02:59 [INFO] Skipping terminated EC2 Instance: i-0445c844e1741f39a
2020/06/23 11:02:59 [INFO] Skipping terminated EC2 Instance: i-063decaa71f8cc018
2020/06/23 11:02:59 [DEBUG] Running Sweeper (aws_lambda_function) in region (us-west-2)
2020/06/23 11:03:00 [DEBUG] No aws lambda functions to sweep
2020/06/23 11:03:00 [DEBUG] Running Sweeper (aws_autoscaling_group) in region (us-west-2)
2020/06/23 11:03:01 [DEBUG] No aws autoscaling groups to sweep
2020/06/23 11:03:01 [DEBUG] Running Sweeper (aws_launch_configuration) in region (us-west-2)
2020/06/23 11:03:01 [DEBUG] No aws launch configurations to sweep
2020/06/23 11:03:01 [DEBUG] Running Sweeper (aws_redshift_cluster) in region (us-west-2)
2020/06/23 11:03:02 [DEBUG] No Redshift clusters to sweep
2020/06/23 11:03:02 [DEBUG] Running Sweeper (aws_spot_fleet_request) in region (us-west-2)
2020/06/23 11:03:02 [INFO] Deleting Spot Fleet Request: sfr-022f966d-cc06-41a7-bd1e-653b040ef537
...
2020/06/23 11:04:45 [INFO] Deleting Spot Fleet Request: sfr-fca43b3b-4a31-4aa8-b3b3-60027d0528fe
2020/06/23 11:04:46 [DEBUG] Active instance count is 0 for Spot Fleet Request (sfr-fca43b3b-4a31-4aa8-b3b3-60027d0528fe), removing
2020/06/23 11:04:46 [DEBUG] Running Sweeper (aws_iam_role) in region (us-west-2)
2020/06/23 11:04:46 [DEBUG] No IAM Roles to sweep
2020/06/23 11:04:46 [DEBUG] Running Sweeper (aws_iam_user) in region (us-west-2)
2020/06/23 11:04:46 [DEBUG] No IAM Users to sweep
2020/06/23 11:04:46 [DEBUG] Running Sweeper (aws_iam_group) in region (us-west-2)
2020/06/23 11:04:47 [INFO] Deleting IAM Group: Jen20PackageManagers
2020/06/23 11:04:47 [INFO] Deleting IAM Group: packer_devtest
2020/06/23 11:04:48 [INFO] Deleting IAM Group: test_group_4300747935912896569
2020/06/23 11:04:49 [INFO] Deleting IAM Group: test_group_4551761326358113148
2020/06/23 11:04:49 [INFO] Deleting IAM Group: test_group_6384270922873243256
2020/06/23 11:04:50 [INFO] Deleting IAM Group: test_group_6453479404941257412
2020/06/23 11:04:51 [INFO] Deleting IAM Group: tf-acc-group-gpa-basic-2k8r8kyi
2020/06/23 11:04:51 [INFO] Deleting IAM Group: tf-acc-group-gpa-basic-fw30x9bh
2020/06/23 11:04:52 [INFO] Deleting IAM Group: tf-acc-group-gpa-basic-plcrmesc
2020/06/23 11:04:53 [INFO] Deleting IAM Group: tf-acc-group-gpa-basic-r2b8yh4q
2020/06/23 11:04:54 [DEBUG] Running Sweeper (aws_iam_policy) in region (us-west-2)
2020/06/23 11:04:54 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-83dbef66-c594-40a3-b9dc-8fbfac2dfb27
2020/06/23 11:04:54 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-83dbef66-c594-40a3-b9dc-8fbfac2dfb27) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 94d727e5-329a-4bee-a307-7d43fbff9054
2020/06/23 11:04:54 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-8f380aca-93a0-4251-9cf5-3b9d0203a8aa
2020/06/23 11:04:54 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-8f380aca-93a0-4251-9cf5-3b9d0203a8aa) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 47a3204f-40d3-4488-8674-b288f82defbe
2020/06/23 11:04:54 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/tf-acc-policy-gpa-basic-r2b8yh4q
2020/06/23 11:04:55 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-2170c6e1-f042-4043-8ee4-1f34fe7b3e19
2020/06/23 11:04:55 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-2170c6e1-f042-4043-8ee4-1f34fe7b3e19) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: a65efdf0-76a6-4595-b050-8f0963261ed4
2020/06/23 11:04:55 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/DynamoDBAutoscalePolicy
2020/06/23 11:04:55 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/DynamoDBAutoscalePolicy) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 771f641f-541a-4b8d-83c3-63850d530cec
2020/06/23 11:04:55 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/tf-acc-policy-gpa-basic-2k8r8kyi
2020/06/23 11:04:56 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/tf-acc-policy-gpa-basic-plcrmesc
2020/06/23 11:04:56 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-1c644075-d585-472f-aa94-6ac8e22bd9c4
2020/06/23 11:04:56 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-1c644075-d585-472f-aa94-6ac8e22bd9c4) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 718655d9-7595-445d-b82c-80fe05b4bb30
2020/06/23 11:04:56 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/tf-acc-policy-gpa-basic-fw30x9bh
2020/06/23 11:04:57 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1545427989858
2020/06/23 11:04:57 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1545427989858) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: b0a93b33-db39-40ed-8630-c826b4444085
2020/06/23 11:04:57 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-17bf07fa-21f9-466a-9ff9-be55c306b8a1
2020/06/23 11:04:57 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-17bf07fa-21f9-466a-9ff9-be55c306b8a1) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 7fdbc3e4-3e78-4ef2-aa95-aea81e4f570d
2020/06/23 11:04:57 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-6530ebd9-562e-47db-a2fe-4a3006b3b1b7
2020/06/23 11:04:58 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-6530ebd9-562e-47db-a2fe-4a3006b3b1b7) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 32f78915-5cd1-47ff-9fee-b4497abf2e26
2020/06/23 11:04:58 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1576802182101
2020/06/23 11:04:58 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1576802182101) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: e0c3b0e8-05f5-4d71-8086-d62f854d46f7
2020/06/23 11:04:58 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/2d2ak2kxpm
2020/06/23 11:04:58 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/svq0lcogg9
2020/06/23 11:04:59 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-980247647930366397
2020/06/23 11:04:59 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/1ta1orz19f
2020/06/23 11:05:00 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/xslp2w7e04
2020/06/23 11:05:00 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/uf6zn1c77l
2020/06/23 11:05:01 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/badmr3flr2
2020/06/23 11:05:01 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/vqmfi82auh
2020/06/23 11:05:02 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/it62rkeun8
2020/06/23 11:05:02 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/psddw9bijv
2020/06/23 11:05:03 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/drrqw7qhi0
2020/06/23 11:05:03 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/sb931cqri1
2020/06/23 11:05:04 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/wlk4oq4n81
2020/06/23 11:05:04 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/qm4t70afzb
2020/06/23 11:05:04 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/fqb81qengp
2020/06/23 11:05:05 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/esyrg76aph
2020/06/23 11:05:05 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/qpdat9h7lx
2020/06/23 11:05:06 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/my39ac618b
2020/06/23 11:05:06 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/fcnae1dvky
2020/06/23 11:05:06 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/zd1bx1lo1y
2020/06/23 11:05:07 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/h3iyn3k8n4
2020/06/23 11:05:07 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/q3oczat8ci
2020/06/23 11:05:08 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/mnk842a97s
2020/06/23 11:05:08 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/v6pb27wpxq
2020/06/23 11:05:08 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/kbedalpe2x
2020/06/23 11:05:09 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/qgli19bkhy
2020/06/23 11:05:09 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1583946813474
2020/06/23 11:05:10 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1583946813474) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 60fee89e-4bec-4c29-bdc1-48555bad8e4f
2020/06/23 11:05:10 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/im0aiq3vja
2020/06/23 11:05:10 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/m0o0ouji6s
2020/06/23 11:05:10 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/gs6oje6v2v
2020/06/23 11:05:11 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/w7nhq8oa30
2020/06/23 11:05:11 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/qvw24io6o3
2020/06/23 11:05:11 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/qg0g8gq04k
2020/06/23 11:05:12 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/mv2jew1dtz
2020/06/23 11:05:12 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/ndzkh29tu2
2020/06/23 11:05:12 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/nejwxos2rl
2020/06/23 11:05:13 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/tkzw1gi2nn
2020/06/23 11:05:13 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/dzjdutb6sn
2020/06/23 11:05:14 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/n0qgfbkmxb
2020/06/23 11:05:14 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/y19ou0duux
2020/06/23 11:05:14 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/circleci-release-to-terraform-staging-bucket
2020/06/23 11:05:15 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/circleci-release-to-terraform-staging-bucket) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: a4ee263f-80c3-4fc6-8008-1aaf8d996de7
2020/06/23 11:05:15 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/imem09sygd
2020/06/23 11:05:15 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/kyx4vew2gy
2020/06/23 11:05:15 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/k12qwb8qza
2020/06/23 11:05:16 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-1324429311463140858
2020/06/23 11:05:16 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-2685267303998413546
2020/06/23 11:05:17 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/0hesp26ppd
2020/06/23 11:05:17 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/ab98qf2slf
2020/06/23 11:05:18 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-8485035891327664742
2020/06/23 11:05:18 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-1177423856893953126
2020/06/23 11:05:18 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-1258709812998549268
2020/06/23 11:05:19 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-2525313560886109212
2020/06/23 11:05:19 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/iam_emr_default_policy_4994407545241189113
2020/06/23 11:05:20 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-4899620462186745471
2020/06/23 11:05:20 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-8832128821340190199
2020/06/23 11:05:20 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/6zmo6jpu6y
2020/06/23 11:05:21 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-2460821864535779827
2020/06/23 11:05:21 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test_policy_3o14r
2020/06/23 11:05:21 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-2732735875133651964
2020/06/23 11:05:22 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/bpz08yavyn
2020/06/23 11:05:22 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/jarncii0u3
2020/06/23 11:05:23 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-83151575579866002
2020/06/23 11:05:23 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-7757884585288753487
2020/06/23 11:05:24 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-7473641939956146640
2020/06/23 11:05:24 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/mqce6mepv4
2020/06/23 11:05:24 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-7647389029266414934
2020/06/23 11:05:25 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/nt3ad6vzpf
2020/06/23 11:05:25 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-8380959359348172962
2020/06/23 11:05:26 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test_policy_99t11
2020/06/23 11:05:26 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-6476517509636948928
2020/06/23 11:05:26 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-3803991435167010202
2020/06/23 11:05:27 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-3488440981064797860
2020/06/23 11:05:27 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/48fj7edpoa
2020/06/23 11:05:28 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-8885714602706546381
2020/06/23 11:05:28 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-5746312202030533522
2020/06/23 11:05:28 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-1336331454645551108
2020/06/23 11:05:29 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-2377880229490114112
2020/06/23 11:05:29 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-5299087410043412056
2020/06/23 11:05:29 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/tf-acc-s3-import-test-6820402778073111835-policy
2020/06/23 11:05:30 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-8324344107021273733
2020/06/23 11:05:30 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/eaist3rzkb
2020/06/23 11:05:31 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-7777423058503145218
2020/06/23 11:05:31 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-5516836139511686956
2020/06/23 11:05:31 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-128289926542221709
2020/06/23 11:05:32 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/iam_emr_profile_policy_6473488463221601170
2020/06/23 11:05:32 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/test-policy-4257878149682965462
2020/06/23 11:05:33 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/gyr7vlof1i
2020/06/23 11:05:33 Sweeper Tests ran successfully:
  - aws_batch_compute_environment
  - aws_db_option_group
  - aws_redshift_cluster
  - aws_datasync_location_s3
  - aws_db_instance
  - aws_eks_fargate_node_group
  - aws_iam_policy
  - aws_config_configuration_aggregator
  - aws_elastic_beanstalk_environment
  - aws_launch_configuration
  - aws_batch_job_queue
  - aws_eks_fargate_profile
  - aws_eks_cluster
  - aws_elastic_beanstalk_application
  - aws_glue_crawler
  - aws_glue_job
  - aws_cloudformation_stack_set_instance
  - aws_lambda_function
  - aws_autoscaling_group
  - aws_iam_user
  - aws_instance
  - aws_config_configuration_recorder
  - aws_dax_cluster
  - aws_iam_role
  - aws_spot_fleet_request
  - aws_iam_group
2020/06/23 11:05:33 Sweeper Tests ran unsuccessfully:
  - aws_cognito_user_pool: Error deleting Cognito User Pool tf-test-9207420729894523345: InvalidParameterException: User pool cannot be deleted. It has a domain configured that should be deleted first.
2020/06/23 11:05:33 [DEBUG] Running Sweepers for region (us-east-1):
2020/06/23 11:05:33 [DEBUG] Running Sweeper (aws_lambda_function) in region (us-east-1)
...
2020/06/23 11:05:36 [DEBUG] No aws lambda functions to sweep
2020/06/23 11:05:36 [DEBUG] Running Sweeper (aws_spot_fleet_request) in region (us-east-1)
2020/06/23 11:05:36 [DEBUG] No Spot Fleet Requests to sweep
2020/06/23 11:05:36 [DEBUG] Running Sweeper (aws_eks_fargate_profile) in region (us-east-1)
2020/06/23 11:05:36 [DEBUG] Running Sweeper (aws_iam_user) in region (us-east-1)
2020/06/23 11:05:36 [DEBUG] No IAM Users to sweep
2020/06/23 11:05:36 [DEBUG] Running Sweeper (aws_iam_group) in region (us-east-1)
2020/06/23 11:05:36 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-east-1)
2020/06/23 11:05:37 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-east-1)
2020/06/23 11:05:37 [DEBUG] Running Sweeper (aws_elastic_beanstalk_environment) in region (us-east-1)
2020/06/23 11:05:37 [DEBUG] No aws beanstalk environments to sweep
2020/06/23 11:05:37 [DEBUG] Running Sweeper (aws_cognito_user_pool) in region (us-east-1)
2020/06/23 11:05:37 [DEBUG] No Cognito User Pools to sweep
2020/06/23 11:05:37 [DEBUG] Running Sweeper (aws_config_configuration_aggregator) in region (us-east-1)
2020/06/23 11:05:37 [DEBUG] No config configuration aggregators to sweep
2020/06/23 11:05:37 [DEBUG] Running Sweeper (aws_datasync_location_s3) in region (us-east-1)
2020/06/23 11:05:38 [DEBUG] No DataSync Location S3s to sweep
2020/06/23 11:05:38 [DEBUG] Running Sweeper (aws_config_configuration_recorder) in region (us-east-1)
2020/06/23 11:05:38 [DEBUG] No AWS Config Configuration Recorder to sweep
2020/06/23 11:05:38 [DEBUG] Running Sweeper (aws_db_option_group) in region (us-east-1)
2020/06/23 11:05:38 [DEBUG] Running Sweeper (aws_cloudformation_stack_set_instance) in region (us-east-1)
2020/06/23 11:05:38 [DEBUG] Running Sweeper (aws_dax_cluster) in region (us-east-1)
2020/06/23 11:05:39 [DEBUG] No DAX clusters to sweep
2020/06/23 11:05:39 [DEBUG] Running Sweeper (aws_db_instance) in region (us-east-1)
2020/06/23 11:05:39 [DEBUG] Running Sweeper (aws_eks_fargate_node_group) in region (us-east-1)
2020/06/23 11:05:39 [DEBUG] Running Sweeper (aws_eks_cluster) in region (us-east-1)
2020/06/23 11:05:39 [DEBUG] Running Sweeper (aws_elastic_beanstalk_application) in region (us-east-1)
2020/06/23 11:05:39 [DEBUG] No aws beanstalk applications to sweep
2020/06/23 11:05:39 [DEBUG] Running Sweeper (aws_glue_crawler) in region (us-east-1)
2020/06/23 11:05:39 [INFO] No Glue Crawlers to sweep
2020/06/23 11:05:39 [DEBUG] Running Sweeper (aws_glue_job) in region (us-east-1)
2020/06/23 11:05:40 [INFO] No Glue Jobs to sweep
2020/06/23 11:05:40 [DEBUG] Running Sweeper (aws_instance) in region (us-east-1)
2020/06/23 11:05:40 [INFO] Skipping terminated EC2 Instance: i-05f499321b2e2e955
2020/06/23 11:05:40 [DEBUG] Running Sweeper (aws_autoscaling_group) in region (us-east-1)
2020/06/23 11:05:40 [DEBUG] No aws autoscaling groups to sweep
2020/06/23 11:05:40 [DEBUG] Running Sweeper (aws_launch_configuration) in region (us-east-1)
2020/06/23 11:05:40 [DEBUG] No aws launch configurations to sweep
2020/06/23 11:05:40 [DEBUG] Running Sweeper (aws_redshift_cluster) in region (us-east-1)
2020/06/23 11:05:41 [DEBUG] No Redshift clusters to sweep
2020/06/23 11:05:41 [DEBUG] Running Sweeper (aws_iam_role) in region (us-east-1)
2020/06/23 11:05:41 [DEBUG] No IAM Roles to sweep
2020/06/23 11:05:41 [DEBUG] Running Sweeper (aws_iam_policy) in region (us-east-1)
2020/06/23 11:05:41 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-83dbef66-c594-40a3-b9dc-8fbfac2dfb27
2020/06/23 11:05:41 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-83dbef66-c594-40a3-b9dc-8fbfac2dfb27) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: afb1708b-6526-46b4-b4c8-1468d359140e
2020/06/23 11:05:41 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-8f380aca-93a0-4251-9cf5-3b9d0203a8aa
2020/06/23 11:05:41 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-8f380aca-93a0-4251-9cf5-3b9d0203a8aa) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: e6f449b5-c95e-4dd1-bf1c-d708057f1f2e
2020/06/23 11:05:41 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-2170c6e1-f042-4043-8ee4-1f34fe7b3e19
2020/06/23 11:05:42 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-2170c6e1-f042-4043-8ee4-1f34fe7b3e19) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 9d5971a2-2ff8-45b8-b0a3-870b8f60a0a5
2020/06/23 11:05:42 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/DynamoDBAutoscalePolicy
2020/06/23 11:05:42 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/DynamoDBAutoscalePolicy) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: c272be72-e6a0-4f09-9db1-fcc7110d22f0
2020/06/23 11:05:42 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-1c644075-d585-472f-aa94-6ac8e22bd9c4
2020/06/23 11:05:42 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaS3ExecutionRole-1c644075-d585-472f-aa94-6ac8e22bd9c4) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: ad686230-6de5-4b0a-8936-568094bc0753
2020/06/23 11:05:42 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1545427989858
2020/06/23 11:05:43 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1545427989858) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: d9e5af6e-a4c1-4a7f-9406-4bb27486af9a
2020/06/23 11:05:43 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-17bf07fa-21f9-466a-9ff9-be55c306b8a1
2020/06/23 11:05:43 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-17bf07fa-21f9-466a-9ff9-be55c306b8a1) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: d87483be-0328-4726-a13d-58fb9e01375f
2020/06/23 11:05:43 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-6530ebd9-562e-47db-a2fe-4a3006b3b1b7
2020/06/23 11:05:43 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/AWSLambdaBasicExecutionRole-6530ebd9-562e-47db-a2fe-4a3006b3b1b7) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 3b7aa0cd-9fbd-488b-806a-13ecf039ee98
2020/06/23 11:05:43 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1576802182101
2020/06/23 11:05:43 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1576802182101) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: b8f79421-5898-4f79-923f-086fef4d0699
2020/06/23 11:05:43 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1583946813474
2020/06/23 11:05:44 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/service-role/Cognito-1583946813474) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: a51218ed-567f-4304-b6d4-e441856bf950
2020/06/23 11:05:44 [INFO] Deleting IAM Policy: arn:aws:iam::--OMITTED--:policy/circleci-release-to-terraform-staging-bucket
2020/06/23 11:05:44 [WARN] Ignoring IAM Policy (arn:aws:iam::--OMITTED--:policy/circleci-release-to-terraform-staging-bucket) deletion error: DeleteConflict: Cannot delete a policy attached to entities.
  status code: 409, request id: 89b6937b-d725-4558-8606-c1ffaf9b5bac
2020/06/23 11:05:44 Sweeper Tests ran successfully:
  - aws_instance
  - aws_eks_fargate_node_group
  - aws_glue_job
  - aws_datasync_location_s3
  - aws_config_configuration_recorder
  - aws_dax_cluster
  - aws_batch_job_queue
  - aws_batch_compute_environment
  - aws_db_instance
  - aws_eks_cluster
  - aws_autoscaling_group
  - aws_launch_configuration
  - aws_cloudformation_stack_set_instance
  - aws_elastic_beanstalk_application
  - aws_iam_group
  - aws_cognito_user_pool
  - aws_db_option_group
  - aws_iam_policy
  - aws_eks_fargate_profile
  - aws_iam_user
  - aws_elastic_beanstalk_environment
  - aws_config_configuration_aggregator
  - aws_iam_role
  - aws_spot_fleet_request
  - aws_glue_crawler
  - aws_redshift_cluster
  - aws_lambda_function
FAIL  github.com/terraform-providers/terraform-provider-aws/aws 247.889s
FAIL
```

Output from sweeper in AWS GovCloud (US):

```
2020/06/23 10:03:54 [DEBUG] Running Sweepers for region (us-gov-west-1):
2020/06/23 10:03:54 [DEBUG] Running Sweeper (aws_db_instance) in region (us-gov-west-1)
...
2020/06/23 10:03:58 [DEBUG] Running Sweeper (aws_eks_fargate_profile) in region (us-gov-west-1)
2020/06/23 10:03:58 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-gov-west-1)
2020/06/23 10:04:01 [DEBUG] Running Sweeper (aws_cloudformation_stack_set_instance) in region (us-gov-west-1)
2020/06/23 10:04:02 [DEBUG] Running Sweeper (aws_cognito_user_pool) in region (us-gov-west-1)
2020/06/23 10:04:02 [DEBUG] No Cognito User Pools to sweep
2020/06/23 10:04:02 [DEBUG] Running Sweeper (aws_config_configuration_aggregator) in region (us-gov-west-1)
2020/06/23 10:04:04 [DEBUG] No config configuration aggregators to sweep
2020/06/23 10:04:04 [DEBUG] Running Sweeper (aws_config_configuration_recorder) in region (us-gov-west-1)
2020/06/23 10:04:04 [DEBUG] No AWS Config Configuration Recorder to sweep
2020/06/23 10:04:04 [DEBUG] Running Sweeper (aws_datasync_location_s3) in region (us-gov-west-1)
2020/06/23 10:04:05 [DEBUG] No DataSync Location S3s to sweep
2020/06/23 10:04:05 [DEBUG] Running Sweeper (aws_dax_cluster) in region (us-gov-west-1)
2020/06/23 10:04:06 [WARN] Skipping DAX Cluster sweep for us-gov-west-1: InvalidParameterValueException: Access Denied to API Version: DAX_V3
2020/06/23 10:04:06 [DEBUG] Running Sweeper (aws_db_option_group) in region (us-gov-west-1)
2020/06/23 10:04:06 [DEBUG] Running Sweeper (aws_eks_fargate_node_group) in region (us-gov-west-1)
2020/06/23 10:04:07 [DEBUG] Running Sweeper (aws_eks_cluster) in region (us-gov-west-1)
2020/06/23 10:04:08 [DEBUG] Running Sweeper (aws_elastic_beanstalk_environment) in region (us-gov-west-1)
2020/06/23 10:04:09 [DEBUG] No aws beanstalk environments to sweep
2020/06/23 10:04:09 [DEBUG] Running Sweeper (aws_elastic_beanstalk_application) in region (us-gov-west-1)
2020/06/23 10:04:09 [DEBUG] No aws beanstalk applications to sweep
2020/06/23 10:04:09 [DEBUG] Running Sweeper (aws_glue_crawler) in region (us-gov-west-1)
2020/06/23 10:04:10 [INFO] No Glue Crawlers to sweep
2020/06/23 10:04:10 [DEBUG] Running Sweeper (aws_glue_job) in region (us-gov-west-1)
2020/06/23 10:04:11 [INFO] No Glue Jobs to sweep
2020/06/23 10:04:11 [DEBUG] Running Sweeper (aws_instance) in region (us-gov-west-1)
2020/06/23 10:04:11 [DEBUG] No EC2 Instances to sweep
2020/06/23 10:04:11 [DEBUG] Running Sweeper (aws_lambda_function) in region (us-gov-west-1)
2020/06/23 10:04:12 [DEBUG] No aws lambda functions to sweep
2020/06/23 10:04:12 [DEBUG] Running Sweeper (aws_autoscaling_group) in region (us-gov-west-1)
2020/06/23 10:04:12 [DEBUG] No aws autoscaling groups to sweep
2020/06/23 10:04:12 [DEBUG] Running Sweeper (aws_launch_configuration) in region (us-gov-west-1)
2020/06/23 10:04:13 [DEBUG] No aws launch configurations to sweep
2020/06/23 10:04:13 [DEBUG] Running Sweeper (aws_redshift_cluster) in region (us-gov-west-1)
2020/06/23 10:04:13 [DEBUG] No Redshift clusters to sweep
2020/06/23 10:04:13 [DEBUG] Running Sweeper (aws_spot_fleet_request) in region (us-gov-west-1)
2020/06/23 10:04:14 [INFO] Deleting Spot Fleet Request: sfr-0255889a-8f96-4d77-93ad-78e1d6af8145
2020/06/23 10:04:15 [DEBUG] Active instance count is 0 for Spot Fleet Request (sfr-0255889a-8f96-4d77-93ad-78e1d6af8145), removing
...
2020/06/23 10:04:32 [INFO] Deleting Spot Fleet Request: sfr-ee60a90f-3a35-41e3-b836-61d93cac99b4
2020/06/23 10:04:33 [DEBUG] Active instance count is 0 for Spot Fleet Request (sfr-ee60a90f-3a35-41e3-b836-61d93cac99b4), removing
2020/06/23 10:04:33 [DEBUG] Running Sweeper (aws_iam_role) in region (us-gov-west-1)
2020/06/23 10:04:37 [DEBUG] No IAM Roles to sweep
2020/06/23 10:04:37 [DEBUG] Running Sweeper (aws_iam_user) in region (us-gov-west-1)
2020/06/23 10:04:37 [DEBUG] Deleting IAM User: tf-acc-ugm-basic-user1-0ciyfkyz
2020/06/23 10:04:41 [DEBUG] Deleting IAM User: tf-acc-ugm-basic-user1-3672jelb
2020/06/23 10:04:45 [DEBUG] Deleting IAM User: tf-acc-ugm-basic-user1-3f8czq96
...
2020/06/23 10:09:13 [DEBUG] Deleting IAM User: tf-acc-ugm-basic-user2-w316unor
2020/06/23 10:09:17 [DEBUG] Deleting IAM User: tf-acc-ugm-basic-user2-x803ixmg
2020/06/23 10:09:21 [DEBUG] Deleting IAM User: tf-acc-ugm-basic-user2-ziflg2mg
2020/06/23 10:09:25 [DEBUG] Running Sweeper (aws_iam_group) in region (us-gov-west-1)
2020/06/23 10:09:25 [DEBUG] Running Sweeper (aws_iam_policy) in region (us-gov-west-1)
2020/06/23 10:09:25 [INFO] Deleting IAM Policy: arn:aws-us-gov:iam::--OMITTED--:policy/iam_emr_default_policy_7114142747117564308
2020/06/23 10:09:26 [INFO] Deleting IAM Policy: arn:aws-us-gov:iam::--OMITTED--:policy/iam_emr_profile_policy_6731769006029286756
2020/06/23 10:09:27 [INFO] Deleting IAM Policy: arn:aws-us-gov:iam::--OMITTED--:policy/iam_emr_default_policy_4202203677099729083
...
2020/06/23 10:16:46 [INFO] Deleting IAM Policy: arn:aws-us-gov:iam::--OMITTED--:policy/iam_emr_profile_policy_6109457006451323744
2020/06/23 10:16:46 [INFO] Deleting IAM Policy: arn:aws-us-gov:iam::--OMITTED--:policy/iam_emr_profile_policy_181902630721762349
2020/06/23 10:16:47 [INFO] Deleting IAM Policy: arn:aws-us-gov:iam::--OMITTED--:policy/iam_emr_default_policy_84369998123182835
2020/06/23 10:16:49 Sweeper Tests ran successfully:
  - aws_lambda_function
  - aws_redshift_cluster
  - aws_iam_role
  - aws_iam_policy
  - aws_cloudformation_stack_set_instance
  - aws_config_configuration_recorder
  - aws_datasync_location_s3
  - aws_dax_cluster
  - aws_spot_fleet_request
  - aws_db_instance
  - aws_eks_fargate_node_group
  - aws_elastic_beanstalk_application
  - aws_batch_job_queue
  - aws_glue_crawler
  - aws_autoscaling_group
  - aws_iam_user
  - aws_iam_group
  - aws_db_option_group
  - aws_eks_cluster
  - aws_instance
  - aws_launch_configuration
  - aws_eks_fargate_profile
  - aws_batch_compute_environment
  - aws_cognito_user_pool
  - aws_config_configuration_aggregator
  - aws_elastic_beanstalk_environment
  - aws_glue_job
ok    github.com/terraform-providers/terraform-provider-aws/aws 775.037s
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Jun 23, 2020
@bflad bflad requested a review from a team June 23, 2020 15:11
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 23, 2020
@anGie44 anGie44 self-requested a review June 30, 2020 21:09
anGie44
anGie44 approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , just noted some additional prefixes that could be added to this list

aws/resource_aws_iam_role_test.go Outdated
Comment on lines 53 to 72
prefixes := []string{
"batch_tf_acc_test",
"codepipeline-",
"cognito_authenticated_",
"cognito_unauthenticated_",
"ecs_instance_role",
"ecs_tf",
"EMR_AutoScaling_DefaultRole_",
"enhanced-monitoring-role-",
"es-domain-role-",
"foo_role",
"foo-role",
"iam_emr",
"iam_for_lambda",
"iam_for_sfn",
"ssm_role",
"terraform-",
"test",
"tf",
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also noted these prefixes in role name attributes across tests:

  • foobar : L143 & L233 of resource_aws_autoscaling_lifecycle_hook_test.go
  • event_ : L855 & L1014 of resource_aws_cloudwatch_event_target_test.go
  • CWLtoKinesisRole_ : L109 of resource_aws_cloudwatch_log_destination_policy_test.go and L109 of resource_aws_cloudwatch_log_destination_test.go
  • rds : (rds_backup) L748 of resource_aws_db_option_group_test.go, (rds_sample_role) L2607, 2700 of resource_aws_rds_cluster_test.go
  • another_rds : L2644, 2737, 2794 of resource_aws_rds_cluster_test.go
  • role : L125-271 of resource_aws_iot_role_alias_test.go
  • firehose : L1072 of resource_aws_msk_cluster_test.go
  • sns-delivery-status : L686 of resource_aws_sns_topic_test.go
  • ssm-role : L470 of resource_aws_ssm_maintenance_window_task_test.go

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew! We really need to wrangle these in. 😅 Thank you so much for going through and finding these, I'll add them to a technical debt issue to standardize and add them to this list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue created: #14003

@bflad bflad mentioned this pull request Jun 30, 2020
Closed
9 tasks
@bflad bflad added this to the v2.69.0 milestone Jul 1, 2020
@bflad bflad merged commit b7cecbf into master Jul 1, 2020
@bflad bflad deleted the t-aws_iam_policy-sweeper branch July 1, 2020 00:33
@ghost
Copy link

ghost commented Jul 3, 2020

This has been released in version 2.69.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
service/iam Issues and PRs that pertain to the iam service. size/L Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.69.0
Development

Successfully merging this pull request may close these issues.

Implement aws_iam_policy Sweeper
2 participants
@bflad @anGie44