tests/resource/aws_db_snapshot: Ensure sweeper runs after aws_db_instance and skips automated snapshots #13897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance and skips automated snapshots Reference: #13800 Looks like the `aws_db_instance` sweeper separately needs to be updated to handle API deletion protection. Output from sweeper in AWS Commercial: ``` 2020/06/23 09:05:56 [DEBUG] Running Sweepers for region (us-west-2): 2020/06/23 09:05:56 [DEBUG] Running Sweeper (aws_db_instance) in region (us-west-2) ... 2020/06/23 09:05:59 [INFO] Deleting DB instance: tf-acc-test-5943499196810915120 2020/06/23 09:06:00 [ERROR] Failed to delete DB instance tf-acc-test-5943499196810915120: InvalidParameterCombination: Cannot delete protected DB Instance, please disable deletion protection and try again. status code: 400, request id: 90caa3c3-9f82-4ad5-ad74-a68238240564 2020/06/23 09:06:00 [DEBUG] Running Sweeper (aws_db_snapshot) in region (us-west-2) 2020/06/23 09:06:00 Sweeper Tests ran successfully: - aws_db_instance - aws_db_snapshot 2020/06/23 09:06:00 [DEBUG] Running Sweepers for region (us-east-1): 2020/06/23 09:06:00 [DEBUG] Running Sweeper (aws_db_instance) in region (us-east-1) ... 2020/06/23 09:06:02 [DEBUG] Running Sweeper (aws_db_snapshot) in region (us-east-1) 2020/06/23 09:06:02 Sweeper Tests ran successfully: - aws_db_instance - aws_db_snapshot ok github.com/terraform-providers/terraform-provider-aws/aws 6.798s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/06/23 09:06:15 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/06/23 09:06:15 [DEBUG] Running Sweeper (aws_db_instance) in region (us-gov-west-1) ... 2020/06/23 09:06:17 [DEBUG] Running Sweeper (aws_db_snapshot) in region (us-gov-west-1) 2020/06/23 09:06:18 Sweeper Tests ran successfully: - aws_db_instance - aws_db_snapshot ok github.com/terraform-providers/terraform-provider-aws/aws 4.148s ```
bflad
added
tests
ghost
added
size/XS
anGie44
approved these changes
Jun 24, 2020
|
This has been released in version 2.68.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #13800
Release note for CHANGELOG:
Looks like the
aws_db_instancesweeper separately needs to be updated to handle API deletion protection.Output from sweeper in AWS Commercial:
Output from sweeper in AWS GovCloud (US):