fix KMS name validation check

[drexler]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12891

Release note for CHANGELOG:

fix KMS name validation check

Output from acceptance testing:

$  make testacc TEST=./aws TESTARGS='-run=TestValidateAwsKmsName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestValidateAwsKmsName -timeout 120m
=== RUN   TestValidateAwsKmsName
--- PASS: TestValidateAwsKmsName (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.069s

...

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[anGie44]

Output of acceptance tests:

--- PASS: TestAccKMSAliasDataSource_awsService (15.30s)
--- PASS: TestAccKMSAlias_disappears (20.19s)
--- PASS: TestAccKMSAliasDataSource_cmk (20.68s)
--- PASS: TestAccKMSAlias_basic (22.71s)
--- PASS: TestAccKMSAlias_namePrefix (22.99s)
--- PASS: TestAccKMSAlias_Name_generated (23.00s)
--- PASS: TestAccKMSAlias_multipleAliasesForSameKey (23.09s)
--- PASS: TestAccKMSAlias_arnDiffSuppress (30.79s)
--- PASS: TestAccKMSAlias_updateKeyID (35.19s)

--- PASS: TestValidNameForDataSource (0.00s)
--- PASS: TestValidNameForResource (0.00s)

[anGie44]

Thanks for this contribution @drexler , LGTM 🚀

[github-actions]

This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[ArchiFleKs]

I think the PR checks against alias/aws and not alias/aws/ I have a KMS key :

│ Error: "name" cannot begin with reserved AWS CMK prefix 'alias/aws'
│ 
│   with aws_kms_alias.aws-ebs-csi-driver[0],
│   on aws-ebs-csi-driver.tf line 212, in resource "aws_kms_alias" "aws-ebs-csi-driver":
│  212:   name          = "alias/aws-ebs-csi-driver-${local.aws-ebs-csi-driver.override_kms_alias != null ? local.aws-ebs-csi-driver.override_kms_alias : var.cluster-name}"

Which failed. Is the AWS API enforce alias/aws/* or alias/aws*

[anGie44]

Hi @ArchiFleKs , thanks for commenting here! The API enforces alias/aws/* , though I could of sworn i read in the docs yesterday it was alias/aws*. Apologies for the regression. Will add a PR shortly to address this.

[anGie44]

@ArchiFleKs , just wanted to let you know the fix was released recently in v4.12.1

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.