Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix lb_listener_rule attribute names #11985

Merged
merged 1 commit into from
Feb 10, 2020
Merged

docs: fix lb_listener_rule attribute names #11985

merged 1 commit into from
Feb 10, 2020

Conversation

danieladams456
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11856

Release note for CHANGELOG:

fix aws_alb_listener_rule condition block attribute names from `value` to `values`

Output from acceptance testing:

docs only

@danieladams456 danieladams456 requested a review from a team February 10, 2020 21:05
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Feb 10, 2020
@danieladams456 danieladams456 changed the title fix lb_listener_rule attribute names docs: fix lb_listener_rule attribute names Feb 10, 2020
bflad
bflad approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for these fixes, @danieladams456 🚀

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Feb 10, 2020
@bflad bflad added this to the v2.49.0 milestone Feb 10, 2020
@bflad bflad merged commit 67e501b into hashicorp:master Feb 10, 2020
@ghost
Copy link

ghost commented Feb 14, 2020

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.49.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danieladams456 @bflad