Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_appmesh_route,r/aws_appmesh_virtual_node,r/aws_appmesh_virtual_router: Support gRPC and HTTP/2 services #11669

Merged
merged 13 commits into from
Oct 1, 2020
+1,364 −248
Merged

r/aws_appmesh_route,r/aws_appmesh_virtual_node,r/aws_appmesh_virtual_router: Support gRPC and HTTP/2 services #11669

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0d18fcb
r/aws_appmesh_route: Add support for retry policies.
ewbankkit Jan 18, 2020
872f98d
r/aws_appmesh_route: Add support for retry policies.
ewbankkit Jan 18, 2020
794115c
r/aws_appmesh_route: Support gRPC and HTTP/2 services.
ewbankkit Jan 18, 2020
402f353
Support new grpc, http2 port protocols for app mesh virtual router
stijndehaes Apr 9, 2020
8e6d4d5
r/aws_appmesh_virtual_router: Test gRPC and HTTP/2 listener protocols.
ewbankkit Apr 16, 2020
3a9bae4
r/aws_appmesh_virtual_node: Add gRPC and HTTP/2 listener protocols.
ewbankkit May 18, 2020
cb70df6
r/aws_appmesh_route: Correct acceptance tests after removing custom h…
ewbankkit May 21, 2020
9499bb0
r/aws_appmesh_route: Correct acceptance tests after merge of https://…
ewbankkit Jun 7, 2020
3330750
r/aws_appmesh_route: Modify acceptance tests for #13556.
ewbankkit Jul 5, 2020
79a3d85
r/aws_appmesh_route: Update resource testing and documentation to 0.1…
ewbankkit Aug 24, 2020
1053fb6
r/aws_appmesh_virtual_node: Use '_Values()' (#14601).
ewbankkit Aug 24, 2020
c010e5a
Remove duplicate example in aws_appmesh_route documentation.
ewbankkit Sep 14, 2020
db690d1
r/aws_appmesh_route: Additional checks for 'mesh_owner' and 'resource…
ewbankkit Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
r/aws_appmesh_virtual_node: Use '_Values()' (#14601). 
r/aws_appmesh_virtual_router: Use '_Values()' (#14601).

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh/Route/'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/ -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/tags
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpHeader
=== RUN   TestAccAWSAppmesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/routePriority
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh_serial (445.49s)
    --- PASS: TestAccAWSAppmesh_serial/Route (365.54s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (53.92s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (54.25s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (53.66s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (37.42s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (37.67s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (37.44s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (53.63s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (37.54s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (79.94s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (32.84s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (47.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	445.526s
@ewbankkit
ewbankkit committed Oct 1, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 1053fb601e9516047693d5a371be11431224893c
26 changes: 8 additions & 18 deletions aws/resource_aws_appmesh_virtual_node.go
View file
Original file line number Diff line number Diff line change
@@ -131,18 +131,13 @@ func resourceAwsAppmeshVirtualNode() *schema.Resource {
Type: schema.TypeInt,
Optional: true,
Computed: true,
ValidateFunc: validation.IntBetween(1, 65535),
ValidateFunc: validation.IsPortNumber,
},

"protocol": {
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice([]string{
appmesh.PortProtocolHttp,
appmesh.PortProtocolTcp,
appmesh.PortProtocolGrpc,
appmesh.PortProtocolHttp2,
}, false),
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice(appmesh.PortProtocol_Values(), false),
},

"timeout_millis": {
@@ -170,18 +165,13 @@ func resourceAwsAppmeshVirtualNode() *schema.Resource {
"port": {
Type: schema.TypeInt,
Required: true,
ValidateFunc: validation.IntBetween(1, 65535),
ValidateFunc: validation.IsPortNumber,
},

"protocol": {
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice([]string{
appmesh.PortProtocolHttp,
appmesh.PortProtocolTcp,
appmesh.PortProtocolGrpc,
appmesh.PortProtocolHttp2,
}, false),
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice(appmesh.PortProtocol_Values(), false),
},
},
},
13 changes: 4 additions & 9 deletions aws/resource_aws_appmesh_virtual_router.go
View file
Original file line number Diff line number Diff line change
@@ -74,18 +74,13 @@ func resourceAwsAppmeshVirtualRouter() *schema.Resource {
"port": {
Type: schema.TypeInt,
Required: true,
ValidateFunc: validation.IntBetween(1, 65535),
ValidateFunc: validation.IsPortNumber,
},

"protocol": {
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice([]string{
appmesh.PortProtocolHttp,
appmesh.PortProtocolTcp,
appmesh.PortProtocolGrpc,
appmesh.PortProtocolHttp2,
}, false),
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice(appmesh.PortProtocol_Values(), false),
},
},
},