Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale issue closer behavior #10839

Merged
merged 3 commits into from
Nov 18, 2019
Merged

Add stale issue closer behavior #10839

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab97e05
Add stale issue closer behavior
aeschright Nov 11, 2019
21091e9
Update stale issue closer schedule to not overlap with other uses
aeschright Nov 12, 2019
ec3e415
Updating params for closing stale issues
aeschright Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .hashibot.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,20 @@ poll "closed_issue_locker" "locker" {
EOF
}

poll "stale_issue_closer" "closer" {
schedule = "0 50 12 * * *"
Copy link
Contributor

@appilon appilon Nov 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a brittle aspect of the system 🙈, I'd like to avoid polls all waking at this same time (to clarify other providers have pasted around similar configs and I think a few happen at 12:50 now), let's pick some new arbitrary point in the day, say 3:10? 0 10 3 * * *

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine, updated

no_reply_in_last = "2160h" # 90 days
max_issues = 500
sleep_between_issues = "5s"
created_after = "2019-11-11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain on why we only want to consider issues after today, but that is outside the context of the review, I'm sure this was very intentional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some concerns about inflicting this on people who might have other expectations -- I'll ping the rest of the team to make sure we couldn't go earlier.

exclude_labels = ["needs-triage"]
message = <<-EOF
I'm going to close this issue due to inactivity (_90 days_ without response ⏳ ). This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!
EOF
}

behavior "deprecated_import_commenter" "hashicorp_terraform" {
import_regexp = "github.com/hashicorp/terraform/"
marker_label = "terraform-plugin-sdk-migration"
Expand Down