Add import support for aws_waf_xss_match_set resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9212

Release note for CHANGELOG:

resource/aws_waf_xss_match_set: Support resource import

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSWafXssMatchSet_'


=== RUN   TestAccAWSWafXssMatchSet_basic
=== PAUSE TestAccAWSWafXssMatchSet_basic
=== CONT  TestAccAWSWafXssMatchSet_basic
--- PASS: TestAccAWSWafXssMatchSet_basic (45.46s)
=== RUN   TestAccAWSWafXssMatchSet_changeNameForceNew
=== PAUSE TestAccAWSWafXssMatchSet_changeNameForceNew
=== CONT  TestAccAWSWafXssMatchSet_changeNameForceNew
--- PASS: TestAccAWSWafXssMatchSet_changeNameForceNew (69.28s)
=== RUN   TestAccAWSWafXssMatchSet_disappears
=== PAUSE TestAccAWSWafXssMatchSet_disappears
=== CONT  TestAccAWSWafXssMatchSet_disappears
--- PASS: TestAccAWSWafXssMatchSet_disappears (37.57s)
=== RUN   TestAccAWSWafXssMatchSet_changeTuples
=== PAUSE TestAccAWSWafXssMatchSet_changeTuples
=== CONT  TestAccAWSWafXssMatchSet_changeTuples
--- FAIL: TestAccAWSWafXssMatchSet_changeTuples (59.77s)
    testing.go:569: Step 1 error: After applying this step and refreshing, the plan was not empty:
        
        DIFF:
        
        UPDATE: aws_waf_xss_match_set.xss_match_set
          arn:                                      "arn:aws:waf::476956259333:xssmatchset/b160fc22-72d0-4d26-a8b7-877f28a5a7ac" => "arn:aws:waf::476956259333:xssmatchset/b160fc22-72d0-4d26-a8b7-877f28a5a7ac"
          id:                                       "b160fc22-72d0-4d26-a8b7-877f28a5a7ac" => "b160fc22-72d0-4d26-a8b7-877f28a5a7ac"
          name:                                     "xssMatchSet-omj93" => "xssMatchSet-omj93"
          xss_match_tuples.#:                       "2" => "2"
          xss_match_tuples.0.field_to_match.#:      "1" => "1"
          xss_match_tuples.0.field_to_match.0.data: "" => "GET"
          xss_match_tuples.0.field_to_match.0.type: "BODY" => "METHOD"
          xss_match_tuples.0.text_transformation:   "CMD_LINE" => "HTML_ENTITY_DECODE"
          xss_match_tuples.1.field_to_match.#:      "1" => "1"
          xss_match_tuples.1.field_to_match.0.data: "" => ""
          xss_match_tuples.1.field_to_match.0.type: "METHOD" => "BODY"
          xss_match_tuples.1.text_transformation:   "HTML_ENTITY_DECODE" => "CMD_LINE"
        
        
        
        STATE:
        
        aws_waf_xss_match_set.xss_match_set:
          ID = b160fc22-72d0-4d26-a8b7-877f28a5a7ac
          provider = provider.aws
          arn = arn:aws:waf::476956259333:xssmatchset/b160fc22-72d0-4d26-a8b7-877f28a5a7ac
          name = xssMatchSet-omj93
          xss_match_tuples.# = 2
          xss_match_tuples.0.field_to_match.# = 1
          xss_match_tuples.0.field_to_match.0.data = 
          xss_match_tuples.0.field_to_match.0.type = BODY
          xss_match_tuples.0.text_transformation = CMD_LINE
          xss_match_tuples.1.field_to_match.# = 1
          xss_match_tuples.1.field_to_match.0.data = 
          xss_match_tuples.1.field_to_match.0.type = METHOD
          xss_match_tuples.1.text_transformation = HTML_ENTITY_DECODE
=== RUN   TestAccAWSWafXssMatchSet_noTuples
=== PAUSE TestAccAWSWafXssMatchSet_noTuples
=== CONT  TestAccAWSWafXssMatchSet_noTuples
--- PASS: TestAccAWSWafXssMatchSet_noTuples (33.17s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	108.755s

...

[DrFaust92]

FYI, TestAccAWSWafXssMatchSet_changeTuples fails regardless of the change

[bflad]

LGTM, thanks @DrFaust92 🚀

Output from acceptance testing (test failure unrelated):

--- PASS: TestAccAWSWafXssMatchSet_noTuples (18.48s)
--- FAIL: TestAccAWSWafXssMatchSet_changeTuples (20.84s)
--- PASS: TestAccAWSWafXssMatchSet_basic (27.02s)
--- PASS: TestAccAWSWafXssMatchSet_changeNameForceNew (39.22s)
--- PASS: TestAccAWSWafXssMatchSet_disappears (44.35s)

[ghost]

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!