Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/service/storagegateway: Blacklist usw2-az4 from test configuration due to instance type unavailability #10427

Merged
merged 1 commit into from
Oct 11, 2019
Merged

tests/service/storagegateway: Blacklist usw2-az4 from test configuration due to instance type unavailability #10427

merged 1 commit into from
Oct 11, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 8, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

Previously, could receive these errors:

--- FAIL: TestAccAWSStorageGatewayGateway_GatewayName (19.06s)
    testing.go:569: Step 0 error: errors during apply:

        Error: Error launching source instance: Unsupported: Your requested instance type (m4.xlarge) is not supported in your requested Availability Zone (us-west-2d). Please retry your request by not specifying an Availability Zone or choosing us-west-2a, us-west-2b, us-west-2c.

--- FAIL: TestAccAWSStorageGatewayNfsFileShare_basic (19.07s)
    testing.go:569: Step 0 error: errors during apply:

        Error: Error launching source instance: Unsupported: Your requested instance type (m4.xlarge) is not supported in your requested Availability Zone (us-west-2d). Please retry your request by not specifying an Availability Zone or choosing us-west-2a, us-west-2b, us-west-2c.

Output from acceptance testing (one unrelated failure):

--- SKIP: TestAccAWSStorageGatewayCachedIscsiVolume_SourceVolumeArn (0.00s)
--- PASS: TestAccAWSStorageGatewayLocalDiskDataSource_DiskNode (147.71s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (163.73s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (211.47s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (212.70s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (218.82s)
--- PASS: TestAccAWSStorageGatewayCache_TapeAndVolumeGateway (229.49s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (230.27s)
--- PASS: TestAccAWSStorageGatewayCachedIscsiVolume_SnapshotId (234.99s)
--- PASS: TestAccAWSStorageGatewayCachedIscsiVolume_Basic (235.95s)
--- FAIL: TestAccAWSStorageGatewayCache_FileGateway (243.30s)
    testing.go:569: Step 0 error: After applying this step, the plan was not empty:

        DIFF:

        DESTROY/CREATE: aws_storagegateway_cache.test
          disk_id:     "1236ea07-49f2-4a5f-a1ca-9946a412c0b4" => "/dev/xvdb" (forces new resource)
          gateway_arn: "arn:aws:storagegateway:us-west-2:*******:gateway/sgw-F532DE9C" => "arn:aws:storagegateway:us-west-2:*******:gateway/sgw-F532DE9C"
          id:          "arn:aws:storagegateway:us-west-2:*******:gateway/sgw-F532DE9C:1236ea07-49f2-4a5f-a1ca-9946a412c0b4" => "<computed>"

--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (276.81s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass (280.34s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted (298.93s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn (317.55s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (346.94s)
--- PASS: TestAccAWSStorageGatewayLocalDiskDataSource_DiskPath (379.81s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults (243.49s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (405.04s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (413.34s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (221.46s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled (475.32s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ReadOnly (289.72s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (234.47s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_RequesterPays (312.04s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (296.97s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (260.51s)
--- PASS: TestAccAWSStorageGatewayUploadBuffer_Basic (227.74s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (340.45s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (300.51s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ObjectACL (476.09s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (468.50s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_Squash (487.55s)
--- PASS: TestAccAWSStorageGatewayWorkingStorage_Basic (306.62s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (468.39s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (807.33s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (775.94s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (951.58s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (1095.85s)

@bflad
tests/service/storagegateway: Blacklist usw2-az4 from test configurat…
8e88796 
…ion due to instance type unavailability

Previously, could receive these errors:

```
--- FAIL: TestAccAWSStorageGatewayGateway_GatewayName (19.06s)
    testing.go:569: Step 0 error: errors during apply:

        Error: Error launching source instance: Unsupported: Your requested instance type (m4.xlarge) is not supported in your requested Availability Zone (us-west-2d). Please retry your request by not specifying an Availability Zone or choosing us-west-2a, us-west-2b, us-west-2c.

--- FAIL: TestAccAWSStorageGatewayNfsFileShare_basic (19.07s)
    testing.go:569: Step 0 error: errors during apply:

        Error: Error launching source instance: Unsupported: Your requested instance type (m4.xlarge) is not supported in your requested Availability Zone (us-west-2d). Please retry your request by not specifying an Availability Zone or choosing us-west-2a, us-west-2b, us-west-2c.
```

Output from acceptance testing (one unrelated failure):

```
--- SKIP: TestAccAWSStorageGatewayCachedIscsiVolume_SourceVolumeArn (0.00s)
--- PASS: TestAccAWSStorageGatewayLocalDiskDataSource_DiskNode (147.71s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (163.73s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (211.47s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (212.70s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (218.82s)
--- PASS: TestAccAWSStorageGatewayCache_TapeAndVolumeGateway (229.49s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (230.27s)
--- PASS: TestAccAWSStorageGatewayCachedIscsiVolume_SnapshotId (234.99s)
--- PASS: TestAccAWSStorageGatewayCachedIscsiVolume_Basic (235.95s)
--- FAIL: TestAccAWSStorageGatewayCache_FileGateway (243.30s)
    testing.go:569: Step 0 error: After applying this step, the plan was not empty:

        DIFF:

        DESTROY/CREATE: aws_storagegateway_cache.test
          disk_id:     "1236ea07-49f2-4a5f-a1ca-9946a412c0b4" => "/dev/xvdb" (forces new resource)
          gateway_arn: "arn:aws:storagegateway:us-west-2:*******:gateway/sgw-F532DE9C" => "arn:aws:storagegateway:us-west-2:*******:gateway/sgw-F532DE9C"
          id:          "arn:aws:storagegateway:us-west-2:*******:gateway/sgw-F532DE9C:1236ea07-49f2-4a5f-a1ca-9946a412c0b4" => "<computed>"

--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (276.81s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass (280.34s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted (298.93s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn (317.55s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (346.94s)
--- PASS: TestAccAWSStorageGatewayLocalDiskDataSource_DiskPath (379.81s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults (243.49s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (405.04s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (413.34s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (221.46s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled (475.32s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ReadOnly (289.72s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (234.47s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_RequesterPays (312.04s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (296.97s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (260.51s)
--- PASS: TestAccAWSStorageGatewayUploadBuffer_Basic (227.74s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (340.45s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (300.51s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ObjectACL (476.09s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (468.50s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_Squash (487.55s)
--- PASS: TestAccAWSStorageGatewayWorkingStorage_Basic (306.62s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (468.39s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (807.33s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (775.94s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (951.58s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (1095.85s)
```
@bflad bflad requested a review from a team October 8, 2019 21:55
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 8, 2019
@aeschright aeschright self-assigned this Oct 9, 2019
nywilken
nywilken approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@bflad bflad added this to the v2.33.0 milestone Oct 11, 2019
@bflad bflad merged commit 63dfd10 into master Oct 11, 2019
@bflad bflad deleted the t-storagegateway-blacklist-usw2-az4 branch October 11, 2019 14:02
@ghost
Copy link

ghost commented Nov 10, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees

@aeschright aeschright

Labels
service/storagegateway Issues and PRs that pertain to the storagegateway service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.33.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bflad @nywilken @aeschright