Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/resource/aws_lb_listener_rule: Use internal implementation for TLS key/certificate #10295

Merged
merged 1 commit into from
Sep 30, 2019
Merged

tests/resource/aws_lb_listener_rule: Use internal implementation for TLS key/certificate #10295

merged 1 commit into from
Sep 30, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 29, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #10023

Release note for CHANGELOG:

NONE

Output from acceptance testing:

--- PASS: TestAccAWSLBListenerRule_oidc (198.18s)
--- PASS: TestAccAWSLBListenerRule_Action_Order (202.37s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (243.71s)
--- PASS: TestAccAWSLBListenerRule_cognito (243.72s)

@bflad
tests/resource/aws_listener_rule: Use internal implementation for TLS…
99ab002 
… key/certificate

Reference: #10023

Output from acceptance testing:

```
--- PASS: TestAccAWSLBListenerRule_oidc (198.18s)
--- PASS: TestAccAWSLBListenerRule_Action_Order (202.37s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (243.71s)
--- PASS: TestAccAWSLBListenerRule_cognito (243.72s)
```
@bflad bflad requested a review from a team September 29, 2019 15:49
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 29, 2019
@bflad bflad changed the title tests/resource/aws_listener_rule: Use internal implementation for TLS key/certificate tests/resource/aws_lb_listener_rule: Use internal implementation for TLS key/certificate Sep 30, 2019
nywilken
nywilken approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

--- PASS: TestAccAWSLBListenerRule_oidc (240.95s)
--- PASS: TestAccAWSLBListenerRule_Action_Order (199.40s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (210.34s)

@bflad bflad added this to the v2.31.0 milestone Sep 30, 2019
@bflad bflad merged commit 3a5bc83 into master Sep 30, 2019
@bflad bflad deleted the t-aws_lb_listener_rule-remove-tls-provider branch September 30, 2019 17:52
@ghost
Copy link

ghost commented Oct 3, 2019

This has been released in version 2.31.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
service/elbv2 Issues and PRs that pertain to the elbv2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @nywilken