Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LocalStack r53 reference to route53 #10133

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Update LocalStack r53 reference to route53 #10133

merged 1 commit into from
Sep 24, 2019

Conversation

tlvince
Copy link
Contributor

@tlvince tlvince commented Sep 17, 2019

r53 is the deprecated name of route53. The following warning is otherwise thrown if copy/pasting the example config:

Warning: "endpoints.0.r53": [DEPRECATED] use `endpoints` configuration block `route53` argument instead

@tlvince
Update LocalStack r53 reference to route53
bd14195 
`r53` is the deprecated name of `route53`.
@tlvince tlvince requested a review from a team September 17, 2019 15:49
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Sep 17, 2019
bflad
bflad approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix, @tlvince 🚀

@bflad bflad added this to the v2.30.0 milestone Sep 24, 2019
@bflad bflad added the provider Pertains to the provider itself, rather than any interaction with AWS. label Sep 24, 2019
@bflad bflad merged commit 94e6b9f into hashicorp:master Sep 24, 2019
@tlvince tlvince deleted the patch-1 branch September 25, 2019 08:49
@ghost
Copy link

ghost commented Sep 26, 2019

This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tlvince @bflad