Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WAF regional rate based rule data source #10125

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Add WAF regional rate based rule data source #10125

merged 3 commits into from
Oct 11, 2019

Conversation

diogoazevedos
Copy link
Contributor

@diogoazevedos diogoazevedos commented Sep 17, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Add the `aws_wafregional_rate_based_rule` data source.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsWafRegionalRateBasedRule_Basic'
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccDataSourceAwsWafRegionalRateBasedRule_Basic -timeout 120m
=== RUN   TestAccDataSourceAwsWafRegionalRateBasedRule_Basic
=== PAUSE TestAccDataSourceAwsWafRegionalRateBasedRule_Basic
=== CONT  TestAccDataSourceAwsWafRegionalRateBasedRule_Basic
--- PASS: TestAccDataSourceAwsWafRegionalRateBasedRule_Basic (50.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	50.259s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 17, 2019
@diogoazevedos diogoazevedos marked this pull request as ready for review September 17, 2019 12:47
@diogoazevedos diogoazevedos requested a review from a team September 17, 2019 12:47
@diogoazevedos diogoazevedos force-pushed the data-wafregional-rate-based-rule branch from 76ad534 to 82bfb82 Compare September 17, 2019 13:18
@diogoazevedos
Copy link
Contributor Author

@bflad is it possible to incorporate this new data source in the next release?

@bflad bflad added the new-data-source Introduces a new data source. label Sep 27, 2019
@bflad bflad modified the milestones: v2.31.0, v2.32.0 Sep 27, 2019
@bflad bflad modified the milestones: v2.32.0, v2.33.0 Oct 10, 2019
bflad
bflad suggested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @diogoazevedos 👋 Sorry for the pushed back review of this -- this is looking really good, just missing a sidebar link then we can get this in. Thanks so much.

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Oct 10, 2019
@diogoazevedos diogoazevedos force-pushed the data-wafregional-rate-based-rule branch from 1e8e7a1 to b1eee9b Compare October 11, 2019 00:38
@diogoazevedos diogoazevedos requested a review from bflad October 11, 2019 01:08
bflad
bflad approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, @diogoazevedos! 🚀

--- PASS: TestAccDataSourceAwsWafRegionalRateBasedRule_Basic (11.54s)

@bflad bflad merged commit b8f655c into hashicorp:master Oct 11, 2019
bflad added a commit that referenced this pull request Oct 11, 2019
@bflad
Update CHANGELOG for #10125
7a7e0f3
@diogoazevedos diogoazevedos deleted the data-wafregional-rate-based-rule branch October 11, 2019 17:43
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/waf Issues and PRs that pertain to the waf service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.33.0
Development

Successfully merging this pull request may close these issues.
3 participants
@diogoazevedos @bflad @breathingdust