test/resource/aws_s3_bucket: Add EMR bootstrap prefix to sweeper list #10106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the EMR cluster test configuration creates a s3 bucket that is publicly accessible. These buckets are not currently cleaned up after testing so this change updates the s3 sweeper to remove test buckets starting with the prefix `tf-emr-bootstrap`. In the long term, we should determine if EMR bootstrapping supports non-public buckets and update the test configurations with the proper bucket permissions. Before the change: ``` > go test ./aws -v -sweep=us-gov-west-1 -sweep-run=aws_s3_bucket -timeout 10h 2019/09/13 13:22:08 [DEBUG] Running Sweepers for region (us-gov-west-1): 2019/09/13 13:22:08 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3_bucket_object), running.. 2019/09/13 13:22:08 [INFO] Building AWS auth structure 2019/09/13 13:22:08 [INFO] Setting AWS metadata API timeout to 100ms 2019/09/13 13:22:08 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id ... 2019/09/13 13:22:11 [INFO] Skipping S3 Bucket: tf-emr-bootstrap-396768694530128871 ... 2019/09/13 13:22:13 [DEBUG] Sweeper (aws_s3_bucket_object) already ran in region (us-gov-west-1) 2019/09/13 13:22:13 Sweeper Tests ran: - aws_s3_bucket_object - aws_s3_bucket ok github.com/terraform-providers/terraform-provider-aws/aws 5.138s ``` After the change ``` > go test ./aws -v -sweep=us-gov-west-1 -sweep-run=aws_s3_bucket -timeout 10h 2019/09/13 13:34:30 [DEBUG] Running Sweepers for region (us-gov-west-1): 2019/09/13 13:34:30 [DEBUG] Sweeper (aws_s3_bucket) has dependency (aws_s3_bucket_object), running.. 2019/09/13 13:34:30 [INFO] Building AWS auth structure 2019/09/13 13:34:30 [INFO] Setting AWS metadata API timeout to 100ms 2019/09/13 13:34:30 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id ... 2019/09/13 13:34:33 [INFO] Deleting S3 Bucket (tf-emr-bootstrap-396768694530128871) Object (testscript.sh) Version: null ... 2019/09/13 13:34:38 [DEBUG] Sweeper (aws_s3_bucket_object) already ran in region (us-gov-west-1) 2019/09/13 13:34:38 Sweeper Tests ran: - aws_s3_bucket_object - aws_s3_bucket ok github.com/terraform-providers/terraform-provider-aws/aws 8.158s ```
ghost
added
size/XS
|
This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Currently the EMR cluster test configuration creates a s3 bucket that is publicly accessible. These buckets are not currently cleaned up after testing so this change updates the s3 sweeper to remove test buckets starting with the prefix
tf-emr-bootstrap. In the long term, we should determine if EMR bootstrapping supports non-public buckets and update the test configurations with the proper bucket permissions.Before the change:
After the change