Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding multiple tags to a cloudHSM cluster does not work #9871

Closed
mudlark opened this issue Aug 23, 2019 · 3 comments · Fixed by #9741 or #10309
Closed

Adding multiple tags to a cloudHSM cluster does not work #9871

mudlark opened this issue Aug 23, 2019 · 3 comments · Fixed by #9741 or #10309
Assignees
Labels
bug Addresses a defect in current functionality. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service.
Milestone

Comments

@mudlark
Copy link
Contributor

mudlark commented Aug 23, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

$ terraform -v
Terraform v0.12.6

  • provider.aws v2.24.0

Affected Resource(s)

  • aws_cloudhsm_v2_cluster

Debug Output

https://gist.github.com/mudlark/0a917aa4863023da1b5843d23ba63d1e

Panic Output

Expected Behavior

4 tags created:

    tags.Name:                "test_hsm_cluster"
    tags.ProjectName:         "infra/cloudhsm-test"
    tags.budget:              "infra"
    tags.org:                 "infra"

Actual Behavior

1 tag created (org: infra in this case, but it's random)

Steps to Reproduce

Create a cloudHSM cluster resource with more than 1 tag.

  1. terraform apply

Important Factoids

I've fixed this in PR 9741

References

@ghost ghost added the service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. label Aug 23, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 23, 2019
@bflad bflad added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 24, 2019
@bflad bflad self-assigned this Sep 24, 2019
bflad added a commit that referenced this issue Sep 30, 2019
Reference: #9871

Output from acceptance testing:

```
--- PASS: TestAccAWSCloudHsm2Cluster_Tags (281.94s)
--- PASS: TestAccAWSCloudHsm2Cluster_basic (286.25s)
```
bflad added a commit that referenced this issue Sep 30, 2019
Reference: #9871

Output from acceptance testing:

```
--- PASS: TestAccAWSCloudHsm2Cluster_Tags (281.94s)
--- PASS: TestAccAWSCloudHsm2Cluster_basic (286.25s)
```
@bflad bflad added this to the v2.34.0 milestone Oct 25, 2019
@bflad
Copy link
Contributor

bflad commented Oct 25, 2019

The fix for this has been merged and will release with version 2.34.0 of the Terraform AWS Provider, between now and next Thursday.

@bflad
Copy link
Contributor

bflad commented Oct 31, 2019

This has been released in version 2.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service.
Projects
None yet
2 participants