Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully Expand Elasticache Cluster and Replication Group Resource Schemas #4828

Closed
bflad opened this issue Jun 13, 2018 · 1 comment · Fixed by #5896
Closed

Fully Expand Elasticache Cluster and Replication Group Resource Schemas #4828

bflad opened this issue Jun 13, 2018 · 1 comment · Fixed by #5896
Labels
service/elasticache Issues and PRs that pertain to the elasticache service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Jun 13, 2018

Currently the aws_elasticache_cluster and aws_elasticache_replication_group resource schemas are generated by functions:

https://github.com/terraform-providers/terraform-provider-aws/blob/7a46d54b4fe593735db4daa118fe30353a0cdd62/aws/resource_aws_elasticache_cluster.go#L21-L243

https://github.com/terraform-providers/terraform-provider-aws/blob/7a46d54b4fe593735db4daa118fe30353a0cdd62/aws/resource_aws_elasticache_replication_group.go#L16-L132

The result is a complicated structure to create a working mental model of what the schema actually is for each attribute, especially when there are bits like this mixed in:

resourceSchema["engine"].Computed = true

Let's just expand each of the resource schemas so no mental gymnastics are required. Tangentially this would also help make the schema more lint-able without runtime handling.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/elasticache Issues and PRs that pertain to the elasticache service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
1 participant