Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New DataSource for Service Catalog AppRegistry Attribute Group #38188

Merged
merged 18 commits into from
Dec 6, 2024
Merged

New DataSource for Service Catalog AppRegistry Attribute Group #38188

merged 18 commits into from
Dec 6, 2024

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Jun 28, 2024 •
edited
Loading

Description

New Datasource for Attribute Group

Relations

Depends on #38183

Output from Acceptance Testing

%  make testacc TESTS=TestAccServiceCatalogAppRegistryAttributeGroupDataSource PKG=servicecatalogappregistry
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogAppRegistryAttributeGroupDataSource'  -timeout 360m
=== RUN   TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags
=== PAUSE TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags
=== RUN   TestAccServiceCatalogAppRegistryAttributeGroupDataSource_basic
=== PAUSE TestAccServiceCatalogAppRegistryAttributeGroupDataSource_basic
=== CONT  TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags
=== CONT  TestAccServiceCatalogAppRegistryAttributeGroupDataSource_basic
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags (16.68s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_basic (17.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry  22.195s

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jun 28, 2024
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/servicecatalogappregistry Issues and PRs that pertain to the servicecatalogappregistry service. labels Jun 28, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jun 28, 2024
@drewtul drewtul marked this pull request as ready for review June 28, 2024 19:27
@drewtul drewtul requested a review from a team as a code owner June 28, 2024 19:27
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 2, 2024
@drewtul drewtul mentioned this pull request Jul 3, 2024
Merged
@drewtul drewtul force-pushed the f-sc-appregistry-attribute-group-ds branch from 88e1217 to e4e46e2 Compare November 29, 2024 14:58
@drewtul drewtul force-pushed the f-sc-appregistry-attribute-group-ds branch from 75481af to b152231 Compare December 5, 2024 16:50
@jar-b jar-b self-assigned this Dec 5, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 5, 2024
jar-b
jar-b approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=servicecatalogappregistry TESTS=TestAccServiceCatalogAppRegistryAttributeGroupDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogAppRegistryAttributeGroupDataSource_'  -timeout 360m
2024/12/05 16:29:45 Initializing Terraform AWS Provider...

--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_NullMap (15.41s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags (15.50s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_EmptyMap (15.96s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_DefaultTags_nonOverlapping (16.21s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_IgnoreTags_Overlap_DefaultTag (16.24s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_basic (16.38s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_IgnoreTags_Overlap_ResourceTag (17.34s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry  22.456s

@jar-b
Copy link
Member

jar-b commented Dec 5, 2024

Thanks for your contribution, @drewtul! 👍

nam054
nam054 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@nam054 nam054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

> make testacc PKG=servicecatalogappregistry TESTS=TestAccServiceCatalogAppRegistryAttributeGroupDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogAppRegistryAttributeGroupDataSource_'  -timeout 360m
2024/12/06 00:13:59 Initializing Terraform AWS Provider...
=== RUN   TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags
=== PAUSE TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags
=== RUN   TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_NullMap
=== PAUSE TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_NullMap
=== RUN   TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_EmptyMap
=== PAUSE TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_EmptyMap
=== RUN   TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccServiceCatalogAppRegistryAttributeGroupDataSource_basic
=== PAUSE TestAccServiceCatalogAppRegistryAttributeGroupDataSource_basic
=== CONT  TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags
=== CONT  TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccServiceCatalogAppRegistryAttributeGroupDataSource_basic
=== CONT  TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_EmptyMap
=== CONT  TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_DefaultTags_nonOverlapping
=== CONT  TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_NullMap
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_EmptyMap (14.33s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_NullMap (14.54s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags (14.77s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_IgnoreTags_Overlap_ResourceTag (14.83s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_IgnoreTags_Overlap_DefaultTag (14.85s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_basic (14.90s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupDataSource_tags_DefaultTags_nonOverlapping (14.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry  21.390s

@nam054 nam054 merged commit 145fc0c into hashicorp:main Dec 6, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.81.0 milestone Dec 6, 2024
@drewtul drewtul deleted the f-sc-appregistry-attribute-group-ds branch December 6, 2024 11:21
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 12, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nam054 nam054 nam054 approved these changes

@jar-b jar-b jar-b approved these changes

Assignees

@jar-b jar-b

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. partner Contribution from a partner. service/servicecatalogappregistry Issues and PRs that pertain to the servicecatalogappregistry service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.81.0
Development

Successfully merging this pull request may close these issues.
4 participants
@drewtul @jar-b @nam054 @justinretzolk