-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add provisioned throughput support to aws_bedrockagent_agent_alias #37520
feat: Add provisioned throughput support to aws_bedrockagent_agent_alias #37520
Conversation
Community NoteVoting for Prioritization
For Submitters
|
57b273c
to
75a2e98
Compare
75a2e98
to
66d3136
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccBedrockAgentAgentAlias_' PKG=bedrockagent ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/bedrockagent/... -v -count 1 -parallel 3 -run=TestAccBedrockAgentAgentAlias_ -timeout 360m
=== RUN TestAccBedrockAgentAgentAlias_basic
=== PAUSE TestAccBedrockAgentAgentAlias_basic
=== RUN TestAccBedrockAgentAgentAlias_disappears
=== PAUSE TestAccBedrockAgentAgentAlias_disappears
=== RUN TestAccBedrockAgentAgentAlias_update
=== PAUSE TestAccBedrockAgentAgentAlias_update
=== RUN TestAccBedrockAgentAgentAlias_routingUpdate
=== PAUSE TestAccBedrockAgentAgentAlias_routingUpdate
=== RUN TestAccBedrockAgentAgentAlias_tags
=== PAUSE TestAccBedrockAgentAgentAlias_tags
=== RUN TestAccBedrockAgentAgentAlias_provisionedThroughput
agent_alias_test.go:227: Bedrock Provisioned Model Throughput for Antropic Claude 2 has a minimum 1 month commitment and costs > $45K/month
--- SKIP: TestAccBedrockAgentAgentAlias_provisionedThroughput (0.00s)
=== CONT TestAccBedrockAgentAgentAlias_basic
=== CONT TestAccBedrockAgentAgentAlias_routingUpdate
=== CONT TestAccBedrockAgentAgentAlias_tags
--- PASS: TestAccBedrockAgentAgentAlias_basic (26.67s)
=== CONT TestAccBedrockAgentAgentAlias_update
--- PASS: TestAccBedrockAgentAgentAlias_routingUpdate (39.23s)
=== CONT TestAccBedrockAgentAgentAlias_disappears
--- PASS: TestAccBedrockAgentAgentAlias_tags (46.58s)
--- PASS: TestAccBedrockAgentAgentAlias_update (34.11s)
--- PASS: TestAccBedrockAgentAgentAlias_disappears (24.40s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent 68.499s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add the
provisioned_throughput
argument to therouting_configuration
block of theaws_bedrockagent_agent_alias
resource. Note that it is cost prohibitive to test this feature, so I've added a test case but set it to skip similar to how it's done for theaws_bedrock_provisioned_model_throughput
tests.Relations
Closes #37489
References
Referred to AgentAliasRoutingConfigurationListItem for specs and wordings.
Output from Acceptance Testing