f-aws_pipes_pipe: support for logging

[nikhil-goenka]

Description

Relations

Closes #35933
Closes #35216

References

Output from Acceptance Testing

% make testacc TESTS=TestAccPipesPipe_ PKG=pipes       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/pipes/... -v -count 1 -parallel 20 -run='TestAccPipesPipe_'  -timeout 360m
=== RUN   TestAccPipesPipe_basicSQS
=== PAUSE TestAccPipesPipe_basicSQS
=== RUN   TestAccPipesPipe_disappears
=== PAUSE TestAccPipesPipe_disappears
=== RUN   TestAccPipesPipe_description
=== PAUSE TestAccPipesPipe_description
=== RUN   TestAccPipesPipe_desiredState
=== PAUSE TestAccPipesPipe_desiredState
=== RUN   TestAccPipesPipe_enrichment
=== PAUSE TestAccPipesPipe_enrichment
=== RUN   TestAccPipesPipe_enrichmentParameters
=== PAUSE TestAccPipesPipe_enrichmentParameters
=== RUN   TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination
=== PAUSE TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination
=== RUN   TestAccPipesPipe_update_logConfiguration_cloudwatchLogsLogDestination
=== PAUSE TestAccPipesPipe_update_logConfiguration_cloudwatchLogsLogDestination
=== RUN   TestAccPipesPipe_sourceParameters_filterCriteria
=== PAUSE TestAccPipesPipe_sourceParameters_filterCriteria
=== RUN   TestAccPipesPipe_nameGenerated
=== PAUSE TestAccPipesPipe_nameGenerated
=== RUN   TestAccPipesPipe_namePrefix
=== PAUSE TestAccPipesPipe_namePrefix
=== RUN   TestAccPipesPipe_roleARN
=== PAUSE TestAccPipesPipe_roleARN
=== RUN   TestAccPipesPipe_tags
=== PAUSE TestAccPipesPipe_tags
=== RUN   TestAccPipesPipe_targetUpdate
=== PAUSE TestAccPipesPipe_targetUpdate
=== RUN   TestAccPipesPipe_targetParameters_inputTemplate
=== PAUSE TestAccPipesPipe_targetParameters_inputTemplate
=== RUN   TestAccPipesPipe_kinesisSourceAndTarget
=== PAUSE TestAccPipesPipe_kinesisSourceAndTarget
=== RUN   TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget
=== PAUSE TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget
=== RUN   TestAccPipesPipe_activeMQSourceStepFunctionTarget
=== PAUSE TestAccPipesPipe_activeMQSourceStepFunctionTarget
=== RUN   TestAccPipesPipe_rabbitMQSourceEventBusTarget
=== PAUSE TestAccPipesPipe_rabbitMQSourceEventBusTarget
=== RUN   TestAccPipesPipe_mskSourceHTTPTarget
    pipe_test.go:1043: DependencyViolation errors deleting subnets and security group
--- SKIP: TestAccPipesPipe_mskSourceHTTPTarget (0.00s)
=== RUN   TestAccPipesPipe_selfManagedKafkaSourceLambdaFunctionTarget
    pipe_test.go:1119: DependencyViolation errors deleting subnets and security group
--- SKIP: TestAccPipesPipe_selfManagedKafkaSourceLambdaFunctionTarget (0.00s)
=== RUN   TestAccPipesPipe_sqsSourceRedshiftTarget
=== PAUSE TestAccPipesPipe_sqsSourceRedshiftTarget
=== RUN   TestAccPipesPipe_SourceSageMakerTarget
    pipe_test.go:1266: aws_sagemaker_pipeline resource not yet implemented
--- SKIP: TestAccPipesPipe_SourceSageMakerTarget (0.00s)
=== RUN   TestAccPipesPipe_sqsSourceBatchJobTarget
=== PAUSE TestAccPipesPipe_sqsSourceBatchJobTarget
=== RUN   TestAccPipesPipe_sqsSourceECSTaskTarget
    pipe_test.go:1417: ValidationException: [numeric instance is lower than the required minimum (minimum: 1, found: 0)]
--- SKIP: TestAccPipesPipe_sqsSourceECSTaskTarget (0.00s)
=== CONT  TestAccPipesPipe_basicSQS
=== CONT  TestAccPipesPipe_roleARN
=== CONT  TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination
=== CONT  TestAccPipesPipe_sqsSourceBatchJobTarget
=== CONT  TestAccPipesPipe_targetParameters_inputTemplate
=== CONT  TestAccPipesPipe_activeMQSourceStepFunctionTarget
=== CONT  TestAccPipesPipe_targetUpdate
=== CONT  TestAccPipesPipe_sourceParameters_filterCriteria
=== CONT  TestAccPipesPipe_enrichment
=== CONT  TestAccPipesPipe_tags
=== CONT  TestAccPipesPipe_nameGenerated
=== CONT  TestAccPipesPipe_kinesisSourceAndTarget
=== CONT  TestAccPipesPipe_desiredState
=== CONT  TestAccPipesPipe_sqsSourceRedshiftTarget
=== CONT  TestAccPipesPipe_enrichmentParameters
=== CONT  TestAccPipesPipe_namePrefix
=== CONT  TestAccPipesPipe_update_logConfiguration_cloudwatchLogsLogDestination
=== CONT  TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget
=== CONT  TestAccPipesPipe_disappears
=== CONT  TestAccPipesPipe_rabbitMQSourceEventBusTarget
--- PASS: TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget (117.74s)
=== CONT  TestAccPipesPipe_description
--- PASS: TestAccPipesPipe_disappears (267.74s)
--- PASS: TestAccPipesPipe_namePrefix (286.67s)
--- PASS: TestAccPipesPipe_nameGenerated (287.18s)
--- PASS: TestAccPipesPipe_basicSQS (293.20s)
--- PASS: TestAccPipesPipe_kinesisSourceAndTarget (300.79s)
--- PASS: TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination (311.79s)
--- PASS: TestAccPipesPipe_update_logConfiguration_cloudwatchLogsLogDestination (359.06s)
--- PASS: TestAccPipesPipe_enrichmentParameters (375.79s)
--- PASS: TestAccPipesPipe_roleARN (377.13s)
--- PASS: TestAccPipesPipe_tags (381.01s)
--- PASS: TestAccPipesPipe_sqsSourceBatchJobTarget (384.12s)
--- PASS: TestAccPipesPipe_targetUpdate (393.50s)
--- PASS: TestAccPipesPipe_enrichment (403.58s)
--- PASS: TestAccPipesPipe_targetParameters_inputTemplate (422.84s)
--- PASS: TestAccPipesPipe_desiredState (432.29s)
--- PASS: TestAccPipesPipe_description (364.23s)
--- PASS: TestAccPipesPipe_sourceParameters_filterCriteria (514.43s)
--- PASS: TestAccPipesPipe_sqsSourceRedshiftTarget (544.66s)
--- PASS: TestAccPipesPipe_rabbitMQSourceEventBusTarget (792.54s)
--- PASS: TestAccPipesPipe_activeMQSourceStepFunctionTarget (1102.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pipes	1115.398s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[johnsonaj]

LGTM 🚀

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccPipesPipe_' PKG=pipes

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/pipes/... -v -count 1 -parallel 20  -run=TestAccPipesPipe_ -timeout 360m
    pipe_test.go:1043: DependencyViolation errors deleting subnets and security group
--- SKIP: TestAccPipesPipe_mskSourceHTTPTarget (0.00s)
    pipe_test.go:1119: DependencyViolation errors deleting subnets and security group
--- SKIP: TestAccPipesPipe_selfManagedKafkaSourceLambdaFunctionTarget (0.00s)
    pipe_test.go:1266: aws_sagemaker_pipeline resource not yet implemented
--- SKIP: TestAccPipesPipe_SourceSageMakerTarget (0.00s)
    pipe_test.go:1417: ValidationException: [numeric instance is lower than the required minimum (minimum: 1, found: 0)]
--- SKIP: TestAccPipesPipe_sqsSourceECSTaskTarget (0.00s)
--- PASS: TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget (64.22s)
--- PASS: TestAccPipesPipe_kinesisSourceAndTarget (81.62s)
--- PASS: TestAccPipesPipe_namePrefix (84.15s)
--- PASS: TestAccPipesPipe_basicSQS (85.54s)
--- PASS: TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination (85.57s)
--- PASS: TestAccPipesPipe_tags (102.58s)
--- PASS: TestAccPipesPipe_nameGenerated (112.12s)
--- PASS: TestAccPipesPipe_update_logConfiguration_cloudwatchLogsLogDestination (131.18s)
--- PASS: TestAccPipesPipe_roleARN (136.91s)
--- PASS: TestAccPipesPipe_enrichmentParameters (138.64s)
--- PASS: TestAccPipesPipe_desiredState (156.90s)
--- PASS: TestAccPipesPipe_targetUpdate (157.66s)
--- PASS: TestAccPipesPipe_sqsSourceBatchJobTarget (161.82s)
--- PASS: TestAccPipesPipe_disappears (97.92s)
--- PASS: TestAccPipesPipe_targetParameters_inputTemplate (163.96s)
--- PASS: TestAccPipesPipe_enrichment (164.90s)
--- PASS: TestAccPipesPipe_description (175.17s)
--- PASS: TestAccPipesPipe_sourceParameters_filterCriteria (240.79s)
--- PASS: TestAccPipesPipe_sqsSourceRedshiftTarget (499.61s)
--- PASS: TestAccPipesPipe_rabbitMQSourceEventBusTarget (810.45s)
--- PASS: TestAccPipesPipe_activeMQSourceStepFunctionTarget (985.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pipes	990.821s

[johnsonaj]

@nikhil-goenka thank you for the contribution! 🎉

[github-actions]

This functionality has been released in v5.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.