Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add logging configuration for the event bridge pipe #35216

Closed
srilavanyapaleti opened this issue Jan 10, 2024 · 8 comments · Fixed by #37135
Closed

[Enhancement]: Add logging configuration for the event bridge pipe #35216

srilavanyapaleti opened this issue Jan 10, 2024 · 8 comments · Fixed by #37135
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/events Issues and PRs that pertain to the events service.
Milestone

Comments

@srilavanyapaleti
Copy link

srilavanyapaleti commented Jan 10, 2024

Description

Logging is supported for Event bridge pipes since Nov, 2023. How ever, in the current terraform event bridge pipe configuration, the logging is not supported. This enhancement request should add the logging configuration support so that the logging settings are configurable via terraform

Affected Resource(s) and/or Data Source(s)

No response

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

No

@srilavanyapaleti srilavanyapaleti added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 10, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 10, 2024
@justinretzolk justinretzolk added service/events Issues and PRs that pertain to the events service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 10, 2024
@andreswebs
Copy link

Hello, I'm interested in working on this feature.

@Wool3673
Copy link

Has this issue been resolved else where? The latest docs suggest it has been, but it doesn't seem to work.

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/pipes_pipe#cloudwatch_logs_parameters

Sample error:
Error: updating Amazon EventBridge Pipes Pipe (foo): operation error Pipes: UpdatePipe, https response error StatusCode: 400, RequestID: foo, ValidationException: {"ValidationErrorFields":[{"Name":"CloudWatchLogsParameters","Message":"Invalid target parameter provided for target."}]}

@andreswebs
Copy link

andreswebs commented Apr 23, 2024 via email

@Wool3673
Copy link

Wool3673 commented Apr 24, 2024

Actually no, it's still pending. The docs you linked refer to using CloudWatch logs as a target. This issue is to enable logging from the pipe, but not as a target.

On Monday, April 22nd, 2024 at 5:28 AM, Wool3673 @.> wrote: Has this issue been resolved else where? The latest docs suggest it has been, but it doesn't seem to work. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/pipes_pipe#cloudwatch_logs_parameters Sample error: Error: updating Amazon EventBridge Pipes Pipe (foo): operation error Pipes: UpdatePipe, https response error StatusCode: 400, RequestID: foo, ValidationException: {"ValidationErrorFields":[{"Name":"CloudWatchLogsParameters","Message":"Invalid target parameter provided for target."}]} — Reply to this email directly, [view it on GitHub](#35216 (comment)), or unsubscribe. You are receiving this because you commented.Message ID: @.>

Hello Andres, thanks for replying. I'm sorry but I dont quite understand your response (my fault). I don't understand what you mean by "logging from the pipe but not as the target", is there other means of logging available without using a target? I see different destinations/services, but they seem to be targets.

Slightly off topic question, do you happen to know if due to the cloudwatch_logs_parameters being listed in the documents it should work (seems like that is the case)? I'm trying to figure out if I'm doing something wrong or if there's an issue with this being a relatively new AWS Service to Terraform. I've found issues raised with the sources being a problem, but not for CW as a target.

Edit: I've score out the comment as I realise the error now. I've left it here as I've mentioned it else where.

Copy link

github-actions bot commented Jun 3, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.53.0 milestone Jun 3, 2024
Copy link

github-actions bot commented Jun 7, 2024

This functionality has been released in v5.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jul 8, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/events Issues and PRs that pertain to the events service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants