Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f-aws_iot_topic_rule-support for log group batch mode #36772

Merged
merged 15 commits into from
Jul 3, 2024
Merged

f-aws_iot_topic_rule-support for log group batch mode #36772

merged 15 commits into from
Jul 3, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 7, 2024 •
edited
Loading

Description

Relations

Closes #35444

References

Output from Acceptance Testing

% make testacc TESTS=TestAccIoTTopicRule_cloudWatchLogs PKG=iot           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTTopicRule_cloudWatchLogs'  -timeout 360m
=== RUN   TestAccIoTTopicRule_cloudWatchLogs
=== PAUSE TestAccIoTTopicRule_cloudWatchLogs
=== RUN   TestAccIoTTopicRule_cloudWatchLogs_batch_mode
=== PAUSE TestAccIoTTopicRule_cloudWatchLogs_batch_mode
=== CONT  TestAccIoTTopicRule_cloudWatchLogs
=== CONT  TestAccIoTTopicRule_cloudWatchLogs_batch_mode
--- PASS: TestAccIoTTopicRule_cloudWatchLogs (211.28s)
--- PASS: TestAccIoTTopicRule_cloudWatchLogs_batch_mode (211.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	289.282s
% make testacc TESTS=TestAccIoTTopicRule_ PKG=iot
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTTopicRule_'  -timeout 360m
=== RUN   TestAccIoTTopicRule_basic
=== PAUSE TestAccIoTTopicRule_basic
=== RUN   TestAccIoTTopicRule_disappears
=== PAUSE TestAccIoTTopicRule_disappears
=== RUN   TestAccIoTTopicRule_tags
=== PAUSE TestAccIoTTopicRule_tags
=== RUN   TestAccIoTTopicRule_cloudWatchAlarm
=== PAUSE TestAccIoTTopicRule_cloudWatchAlarm
=== RUN   TestAccIoTTopicRule_cloudWatchLogs
=== PAUSE TestAccIoTTopicRule_cloudWatchLogs
=== RUN   TestAccIoTTopicRule_cloudWatchLogs_batch_mode
=== PAUSE TestAccIoTTopicRule_cloudWatchLogs_batch_mode
=== RUN   TestAccIoTTopicRule_cloudWatchMetric
=== PAUSE TestAccIoTTopicRule_cloudWatchMetric
=== RUN   TestAccIoTTopicRule_dynamoDB
=== PAUSE TestAccIoTTopicRule_dynamoDB
=== RUN   TestAccIoTTopicRule_dynamoDBv2
=== PAUSE TestAccIoTTopicRule_dynamoDBv2
=== RUN   TestAccIoTTopicRule_elasticSearch
=== PAUSE TestAccIoTTopicRule_elasticSearch
=== RUN   TestAccIoTTopicRule_firehose
=== PAUSE TestAccIoTTopicRule_firehose
=== RUN   TestAccIoTTopicRule_Firehose_separator
=== PAUSE TestAccIoTTopicRule_Firehose_separator
=== RUN   TestAccIoTTopicRule_Firehose_batch_mode
=== PAUSE TestAccIoTTopicRule_Firehose_batch_mode
=== RUN   TestAccIoTTopicRule_http
=== PAUSE TestAccIoTTopicRule_http
=== RUN   TestAccIoTTopicRule_IoT_analytics
=== PAUSE TestAccIoTTopicRule_IoT_analytics
=== RUN   TestAccIoTTopicRule_IoT_analytics_batch_mode
=== PAUSE TestAccIoTTopicRule_IoT_analytics_batch_mode
=== RUN   TestAccIoTTopicRule_IoT_events
=== PAUSE TestAccIoTTopicRule_IoT_events
=== RUN   TestAccIoTTopicRule_IoT_events_batch_mode
=== PAUSE TestAccIoTTopicRule_IoT_events_batch_mode
=== RUN   TestAccIoTTopicRule_kafka
=== PAUSE TestAccIoTTopicRule_kafka
=== RUN   TestAccIoTTopicRule_kinesis
=== PAUSE TestAccIoTTopicRule_kinesis
=== RUN   TestAccIoTTopicRule_lambda
=== PAUSE TestAccIoTTopicRule_lambda
=== RUN   TestAccIoTTopicRule_republish
=== PAUSE TestAccIoTTopicRule_republish
=== RUN   TestAccIoTTopicRule_republishWithQos
=== PAUSE TestAccIoTTopicRule_republishWithQos
=== RUN   TestAccIoTTopicRule_s3
=== PAUSE TestAccIoTTopicRule_s3
=== RUN   TestAccIoTTopicRule_sns
=== PAUSE TestAccIoTTopicRule_sns
=== RUN   TestAccIoTTopicRule_sqs
=== PAUSE TestAccIoTTopicRule_sqs
=== RUN   TestAccIoTTopicRule_Step_functions
=== PAUSE TestAccIoTTopicRule_Step_functions
=== RUN   TestAccIoTTopicRule_Timestream
=== PAUSE TestAccIoTTopicRule_Timestream
=== RUN   TestAccIoTTopicRule_errorAction
=== PAUSE TestAccIoTTopicRule_errorAction
=== RUN   TestAccIoTTopicRule_updateKinesisErrorAction
=== PAUSE TestAccIoTTopicRule_updateKinesisErrorAction
=== CONT  TestAccIoTTopicRule_basic
=== CONT  TestAccIoTTopicRule_IoT_analytics_batch_mode
=== CONT  TestAccIoTTopicRule_s3
=== CONT  TestAccIoTTopicRule_republishWithQos
=== CONT  TestAccIoTTopicRule_lambda
=== CONT  TestAccIoTTopicRule_Step_functions
=== CONT  TestAccIoTTopicRule_Firehose_separator
=== CONT  TestAccIoTTopicRule_firehose
=== CONT  TestAccIoTTopicRule_dynamoDB
=== CONT  TestAccIoTTopicRule_cloudWatchMetric
=== CONT  TestAccIoTTopicRule_Timestream
=== CONT  TestAccIoTTopicRule_updateKinesisErrorAction
=== CONT  TestAccIoTTopicRule_errorAction
=== CONT  TestAccIoTTopicRule_republish
=== CONT  TestAccIoTTopicRule_kinesis
=== CONT  TestAccIoTTopicRule_sqs
=== CONT  TestAccIoTTopicRule_dynamoDBv2
=== CONT  TestAccIoTTopicRule_IoT_analytics
=== CONT  TestAccIoTTopicRule_http
=== CONT  TestAccIoTTopicRule_Firehose_batch_mode
--- PASS: TestAccIoTTopicRule_basic (302.92s)
--- PASS: TestAccIoTTopicRule_lambda (302.93s)
=== CONT  TestAccIoTTopicRule_cloudWatchLogs_batch_mode
=== CONT  TestAccIoTTopicRule_cloudWatchAlarm
--- PASS: TestAccIoTTopicRule_errorAction (363.17s)
=== CONT  TestAccIoTTopicRule_cloudWatchLogs
--- PASS: TestAccIoTTopicRule_republishWithQos (367.41s)
=== CONT  TestAccIoTTopicRule_tags
--- PASS: TestAccIoTTopicRule_IoT_analytics_batch_mode (525.83s)
=== CONT  TestAccIoTTopicRule_IoT_events
--- PASS: TestAccIoTTopicRule_dynamoDBv2 (526.46s)
=== CONT  TestAccIoTTopicRule_IoT_events_batch_mode
--- PASS: TestAccIoTTopicRule_IoT_analytics (526.60s)
=== CONT  TestAccIoTTopicRule_kafka
--- PASS: TestAccIoTTopicRule_dynamoDB (620.82s)
=== CONT  TestAccIoTTopicRule_elasticSearch
--- PASS: TestAccIoTTopicRule_Firehose_separator (620.99s)
=== CONT  TestAccIoTTopicRule_sns
--- PASS: TestAccIoTTopicRule_republish (621.00s)
=== CONT  TestAccIoTTopicRule_disappears
--- PASS: TestAccIoTTopicRule_Firehose_batch_mode (621.57s)
--- PASS: TestAccIoTTopicRule_cloudWatchMetric (621.58s)
--- PASS: TestAccIoTTopicRule_kinesis (622.21s)
--- PASS: TestAccIoTTopicRule_s3 (622.81s)
--- PASS: TestAccIoTTopicRule_updateKinesisErrorAction (622.93s)
--- PASS: TestAccIoTTopicRule_firehose (623.03s)
--- PASS: TestAccIoTTopicRule_Timestream (623.50s)
--- PASS: TestAccIoTTopicRule_sqs (623.59s)
--- PASS: TestAccIoTTopicRule_Step_functions (624.20s)
--- PASS: TestAccIoTTopicRule_IoT_events (188.86s)
--- PASS: TestAccIoTTopicRule_disappears (131.84s)
--- PASS: TestAccIoTTopicRule_cloudWatchAlarm (460.74s)
--- PASS: TestAccIoTTopicRule_cloudWatchLogs_batch_mode (466.41s)
--- PASS: TestAccIoTTopicRule_http (788.64s)
--- PASS: TestAccIoTTopicRule_cloudWatchLogs (428.60s)
--- PASS: TestAccIoTTopicRule_IoT_events_batch_mode (273.34s)
--- PASS: TestAccIoTTopicRule_tags (464.58s)
--- PASS: TestAccIoTTopicRule_elasticSearch (215.09s)
--- PASS: TestAccIoTTopicRule_sns (216.25s)
--- PASS: TestAccIoTTopicRule_kafka (345.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	887.251s

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iot Issues and PRs that pertain to the iot service. labels Apr 7, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 7, 2024
@nikhil-goenka nikhil-goenka marked this pull request as ready for review April 7, 2024 11:14
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Apr 7, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 8, 2024
@nikhil-goenka nikhil-goenka requested a review from a team as a code owner June 16, 2024 13:13
@ewbankkit ewbankkit self-assigned this Jul 3, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 3, 2024
ewbankkit
ewbankkit approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIoTTopicRule_' PKG=iot ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/iot/... -v -count 1 -parallel 3  -run=TestAccIoTTopicRule_ -timeout 360m
=== RUN   TestAccIoTTopicRule_basic
=== PAUSE TestAccIoTTopicRule_basic
=== RUN   TestAccIoTTopicRule_disappears
=== PAUSE TestAccIoTTopicRule_disappears
=== RUN   TestAccIoTTopicRule_tags
=== PAUSE TestAccIoTTopicRule_tags
=== RUN   TestAccIoTTopicRule_cloudWatchAlarm
=== PAUSE TestAccIoTTopicRule_cloudWatchAlarm
=== RUN   TestAccIoTTopicRule_cloudWatchLogs
=== PAUSE TestAccIoTTopicRule_cloudWatchLogs
=== RUN   TestAccIoTTopicRule_cloudWatchLogs_batch_mode
=== PAUSE TestAccIoTTopicRule_cloudWatchLogs_batch_mode
=== RUN   TestAccIoTTopicRule_cloudWatchMetric
=== PAUSE TestAccIoTTopicRule_cloudWatchMetric
=== RUN   TestAccIoTTopicRule_dynamoDB
=== PAUSE TestAccIoTTopicRule_dynamoDB
=== RUN   TestAccIoTTopicRule_dynamoDBv2
=== PAUSE TestAccIoTTopicRule_dynamoDBv2
=== RUN   TestAccIoTTopicRule_elasticSearch
=== PAUSE TestAccIoTTopicRule_elasticSearch
=== RUN   TestAccIoTTopicRule_firehose
=== PAUSE TestAccIoTTopicRule_firehose
=== RUN   TestAccIoTTopicRule_Firehose_separator
=== PAUSE TestAccIoTTopicRule_Firehose_separator
=== RUN   TestAccIoTTopicRule_Firehose_batch_mode
=== PAUSE TestAccIoTTopicRule_Firehose_batch_mode
=== RUN   TestAccIoTTopicRule_http
=== PAUSE TestAccIoTTopicRule_http
=== RUN   TestAccIoTTopicRule_IoT_analytics
=== PAUSE TestAccIoTTopicRule_IoT_analytics
=== RUN   TestAccIoTTopicRule_IoT_analytics_batch_mode
=== PAUSE TestAccIoTTopicRule_IoT_analytics_batch_mode
=== RUN   TestAccIoTTopicRule_IoT_events
=== PAUSE TestAccIoTTopicRule_IoT_events
=== RUN   TestAccIoTTopicRule_IoT_events_batch_mode
=== PAUSE TestAccIoTTopicRule_IoT_events_batch_mode
=== RUN   TestAccIoTTopicRule_kafka
=== PAUSE TestAccIoTTopicRule_kafka
=== RUN   TestAccIoTTopicRule_kinesis
=== PAUSE TestAccIoTTopicRule_kinesis
=== RUN   TestAccIoTTopicRule_lambda
=== PAUSE TestAccIoTTopicRule_lambda
=== RUN   TestAccIoTTopicRule_republish
=== PAUSE TestAccIoTTopicRule_republish
=== RUN   TestAccIoTTopicRule_republishWithQos
=== PAUSE TestAccIoTTopicRule_republishWithQos
=== RUN   TestAccIoTTopicRule_s3
=== PAUSE TestAccIoTTopicRule_s3
=== RUN   TestAccIoTTopicRule_sns
=== PAUSE TestAccIoTTopicRule_sns
=== RUN   TestAccIoTTopicRule_sqs
=== PAUSE TestAccIoTTopicRule_sqs
=== RUN   TestAccIoTTopicRule_Step_functions
=== PAUSE TestAccIoTTopicRule_Step_functions
=== RUN   TestAccIoTTopicRule_Timestream
=== PAUSE TestAccIoTTopicRule_Timestream
=== RUN   TestAccIoTTopicRule_errorAction
=== PAUSE TestAccIoTTopicRule_errorAction
=== RUN   TestAccIoTTopicRule_updateKinesisErrorAction
=== PAUSE TestAccIoTTopicRule_updateKinesisErrorAction
=== CONT  TestAccIoTTopicRule_basic
=== CONT  TestAccIoTTopicRule_IoT_analytics_batch_mode
=== CONT  TestAccIoTTopicRule_dynamoDBv2
--- PASS: TestAccIoTTopicRule_basic (14.26s)
=== CONT  TestAccIoTTopicRule_Firehose_batch_mode
--- PASS: TestAccIoTTopicRule_IoT_analytics_batch_mode (30.90s)
=== CONT  TestAccIoTTopicRule_IoT_analytics
--- PASS: TestAccIoTTopicRule_dynamoDBv2 (30.92s)
=== CONT  TestAccIoTTopicRule_http
--- PASS: TestAccIoTTopicRule_Firehose_batch_mode (32.38s)
=== CONT  TestAccIoTTopicRule_firehose
--- PASS: TestAccIoTTopicRule_IoT_analytics (29.32s)
=== CONT  TestAccIoTTopicRule_Firehose_separator
--- PASS: TestAccIoTTopicRule_http (38.73s)
=== CONT  TestAccIoTTopicRule_cloudWatchLogs
--- PASS: TestAccIoTTopicRule_firehose (31.29s)
=== CONT  TestAccIoTTopicRule_dynamoDB
--- PASS: TestAccIoTTopicRule_Firehose_separator (31.60s)
=== CONT  TestAccIoTTopicRule_cloudWatchMetric
--- PASS: TestAccIoTTopicRule_cloudWatchLogs (31.46s)
=== CONT  TestAccIoTTopicRule_cloudWatchLogs_batch_mode
--- PASS: TestAccIoTTopicRule_dynamoDB (31.63s)
=== CONT  TestAccIoTTopicRule_tags
--- PASS: TestAccIoTTopicRule_cloudWatchMetric (33.51s)
=== CONT  TestAccIoTTopicRule_cloudWatchAlarm
--- PASS: TestAccIoTTopicRule_cloudWatchLogs_batch_mode (32.27s)
=== CONT  TestAccIoTTopicRule_disappears
--- PASS: TestAccIoTTopicRule_tags (31.56s)
=== CONT  TestAccIoTTopicRule_s3
--- PASS: TestAccIoTTopicRule_disappears (12.47s)
=== CONT  TestAccIoTTopicRule_updateKinesisErrorAction
--- PASS: TestAccIoTTopicRule_cloudWatchAlarm (32.32s)
=== CONT  TestAccIoTTopicRule_errorAction
--- PASS: TestAccIoTTopicRule_s3 (33.52s)
=== CONT  TestAccIoTTopicRule_Timestream
--- PASS: TestAccIoTTopicRule_updateKinesisErrorAction (33.21s)
=== CONT  TestAccIoTTopicRule_Step_functions
--- PASS: TestAccIoTTopicRule_errorAction (24.69s)
=== CONT  TestAccIoTTopicRule_sqs
--- PASS: TestAccIoTTopicRule_Timestream (33.53s)
=== CONT  TestAccIoTTopicRule_elasticSearch
--- PASS: TestAccIoTTopicRule_Step_functions (32.22s)
=== CONT  TestAccIoTTopicRule_sns
--- PASS: TestAccIoTTopicRule_sqs (32.59s)
=== CONT  TestAccIoTTopicRule_kinesis
--- PASS: TestAccIoTTopicRule_elasticSearch (33.32s)
=== CONT  TestAccIoTTopicRule_republishWithQos
--- PASS: TestAccIoTTopicRule_sns (33.35s)
=== CONT  TestAccIoTTopicRule_IoT_events_batch_mode
--- PASS: TestAccIoTTopicRule_kinesis (31.92s)
=== CONT  TestAccIoTTopicRule_republish
--- PASS: TestAccIoTTopicRule_republishWithQos (22.20s)
=== CONT  TestAccIoTTopicRule_lambda
--- PASS: TestAccIoTTopicRule_IoT_events_batch_mode (29.04s)
=== CONT  TestAccIoTTopicRule_kafka
--- PASS: TestAccIoTTopicRule_lambda (13.55s)
=== CONT  TestAccIoTTopicRule_IoT_events
--- PASS: TestAccIoTTopicRule_republish (31.72s)
--- PASS: TestAccIoTTopicRule_IoT_events (21.06s)
--- PASS: TestAccIoTTopicRule_kafka (48.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	326.669s

@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0f55290 into hashicorp:main Jul 3, 2024
63 checks passed
@github-actions github-actions bot added this to the v5.57.0 milestone Jul 3, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@nikhil-goenka nikhil-goenka deleted the f-aws_iot_topic_rule-support-batch-mode branch July 16, 2024 16:59
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.57.0
3 participants
@nikhil-goenka @ewbankkit @justinretzolk